From nobody Mon Feb 9 12:11:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1656425909100795.6314005128372; Tue, 28 Jun 2022 07:18:29 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-184-vUKxvRU1M7qVxpwsDdBVHg-1; Tue, 28 Jun 2022 10:18:25 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E31868FC17B; Tue, 28 Jun 2022 14:17:40 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id CF519141510C; Tue, 28 Jun 2022 14:17:40 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A45C91947058; Tue, 28 Jun 2022 14:17:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BE37C19466DF for ; Tue, 28 Jun 2022 14:17:38 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 9F18E112131E; Tue, 28 Jun 2022 14:17:38 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4AA1D112131B for ; Tue, 28 Jun 2022 14:17:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656425908; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9X4btSi2PVQHAdJV+qALWpbKGsAiR6jWsUJW2Ykgt58=; b=E87h+gxjBbKcFoZJgj6bhIk44EOzkqbx7vV+6EgqAoJ+CKlcxYStW/8pczv/AlfiNwL5C9 /JZM0YF4RVXUsZYfuhWXBPTuDG3rqSZmiMMk5A5DIK3nAO9ik2W4D2wF559nkXZb747SAe WmZPpv7lX0vyT2R+AfnAf6ApDn5GjRo= X-MC-Unique: vUKxvRU1M7qVxpwsDdBVHg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 3/4] virnetdevbandwidthtest: Reformat TC cmd line Date: Tue, 28 Jun 2022 16:17:34 +0200 Message-Id: <902f1c9b7b5632f32957e1e97d935b3ceb10839d.1656425669.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1656425910703100005 Content-Type: text/plain; charset="utf-8"; x-default="true" Our coding style expects a long line to be broken into shorter lines which are then aligned on the first character, for instance: "some string that's broken " "into multiple lines" However, one can argue that there are few cases where shifting the alignment makes the code more readable. And this is the case of expected cmd line for DO_TEST_SET() where a long cmd line can be aligned on the arguments rather than the binary: TC " filter ..." " police ..." Signed-off-by: Michal Privoznik --- tests/virnetdevbandwidthtest.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/virnetdevbandwidthtest.c b/tests/virnetdevbandwidthtest.c index f0873743b4..51e5ec016b 100644 --- a/tests/virnetdevbandwidthtest.c +++ b/tests/virnetdevbandwidthtest.c @@ -127,8 +127,8 @@ mymain(void) TC " qdisc del dev eth0 root\n" TC " qdisc del dev eth0 ingress\n" TC " qdisc add dev eth0 ingress\n" - TC " filter add dev eth0 parent ffff: protocol all u32 mat= ch u32 0 0 " - "police rate 1024kbps burst 1024kb mtu 64kb drop flowid :1= \n"); + TC " filter add dev eth0 parent ffff: protocol all u32 mat= ch u32 0 0" + " police rate 1024kbps burst 1024kb mtu 64kb drop flowi= d :1\n"); =20 DO_TEST_SET("" " " @@ -141,8 +141,8 @@ mymain(void) TC " qdisc add dev eth0 parent 1:1 handle 2: sfq perturb 1= 0\n" TC " filter add dev eth0 parent 1:0 protocol all prio 1 ha= ndle 1 fw flowid 1\n" TC " qdisc add dev eth0 ingress\n" - TC " filter add dev eth0 parent ffff: protocol all u32 mat= ch u32 0 0 " - "police rate 5kbps burst 7kb mtu 64kb drop flowid :1\n"); + TC " filter add dev eth0 parent ffff: protocol all u32 mat= ch u32 0 0" + " police rate 5kbps burst 7kb mtu 64kb drop flowid :1\n= "); =20 DO_TEST_SET("" " " @@ -155,9 +155,9 @@ mymain(void) TC " qdisc add dev eth0 parent 1:1 handle 2: sfq perturb 1= 0\n" TC " filter add dev eth0 parent 1:0 protocol all prio 1 ha= ndle 1 fw flowid 1\n" TC " qdisc add dev eth0 ingress\n" - TC " filter add dev eth0 parent ffff: protocol all u32 mat= ch " - "u32 0 0 police rate 4294967295kbps burst 4194303kb mtu 64= kb " - "drop flowid :1\n"); + TC " filter add dev eth0 parent ffff: protocol all u32 mat= ch" + " u32 0 0 police rate 4294967295kbps burst 4194303kb mt= u 64kb" + " drop flowid :1\n"); =20 return ret =3D=3D 0 ? EXIT_SUCCESS : EXIT_FAILURE; } --=20 2.35.1