From nobody Mon Feb 2 09:12:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1767709762; cv=none; d=zohomail.com; s=zohoarc; b=YyrMTjxhoS/bwUplkzVPMJIu1QgI0QmKaMy+J9MovknWTs2GcJdv9q/VM+DO58JuP4/2FtZSyMyn4fGR+hG75VzbP4oAf1HOgmuAAgYPwnDwJ69xbfurDaDQM5PHapX/E0tOKgwVxqnCqtC8AcBI+MJhl2o8ZuqqtTxEoVBk6FU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767709762; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=crfSVr+15GthxlziooCsXxeTakynVLNMzk7eox+9u9g=; b=JgpZTVyTQEkvBUOc7b0HyuWZMcmabUd7VXxQ28962LiC6XmoUOlfMEE9osgJHmLYa4HOjLvDKO35hu4eWQ47RMHntU3d+/kRBNEgVPCPspPVV84l1xFo0jj7xvHEQmZPnyYwW5AHa9TiUntjRamV8ReiPkmeecachKBAHuaCWzE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1767709762674287.3686356045507; Tue, 6 Jan 2026 06:29:22 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id D9570418B1; Tue, 6 Jan 2026 09:29:21 -0500 (EST) Received: from [172.19.199.83] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id E577641BDB; Tue, 6 Jan 2026 09:26:30 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 51CB3419DF; Tue, 6 Jan 2026 09:25:30 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 7A44E4198C for ; Tue, 6 Jan 2026 09:25:29 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-343-O1RIxEB9N_md0TB4lQitug-1; Tue, 06 Jan 2026 09:25:27 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3377E195FCF5 for ; Tue, 6 Jan 2026 14:25:27 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8BF7B180049F for ; Tue, 6 Jan 2026 14:25:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767709529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=crfSVr+15GthxlziooCsXxeTakynVLNMzk7eox+9u9g=; b=R1SsTThao7HyZxn8ztQ/3HUzh6pEXP1crm3aHYRwEee9qHgHenaSqTrafsGxcJmMEHLmVI /Ixyi856htMKpX4+w7e7BS4sEU1ZFwHdEE1leIiTchg5ITclZ3/gSmjFMxOAyuwDoy80YO 4/64H4qUbNYCaxCHWHZ8oBKz5q6uICI= X-MC-Unique: O1RIxEB9N_md0TB4lQitug-1 X-Mimecast-MFC-AGG-ID: O1RIxEB9N_md0TB4lQitug_1767709527 To: devel@lists.libvirt.org Subject: [PATCH 3/3] qemu_validate: Drop VIR_DOMAIN_HYPERV_STIMER dependency on VIR_DOMAIN_HYPERV_VPINDEX Date: Tue, 6 Jan 2026 15:25:18 +0100 Message-ID: <901c2b380fae5cd080378a60fa7112cd51704727.1767709486.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MQ-giZpe-toIZ1grJWUlhVQJE1kV9VcAZJF3llHerfY_1767709527 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: B2W7FUYY4PXCKQFJDZ4IAUDLGY6SE2MI X-Message-ID-Hash: B2W7FUYY4PXCKQFJDZ4IAUDLGY6SE2MI X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1767709765052158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik The original commit (v11.9.0-rc1~84) added a dependency checking of VIR_DOMAIN_HYPERV_STIMER on VIR_DOMAIN_HYPERV_VPINDEX (meaning, if stimer is on then vpindex must also be on). It justified this by citing QEMU documentation: Per QEMU documentation (docs/system/i386/hyperv.rst): ``hv-stimer`` Enables Hyper-V synthetic timers. Requires: ``hv-vpindex``, ``hv-synic``, ``hv-time`` While the documentation is almost correct (see previous commit when it's incorrect), the code express no dependency on vpindex (kvm_hyperv_properties[] array from target/i386/kvm/kvm.c): [HYPERV_FEAT_STIMER] =3D { .desc =3D "synthetic timers (hv-stimer)", .flags =3D { {.func =3D HV_CPUID_FEATURES, .reg =3D R_EAX, .bits =3D HV_SYNTIMERS_AVAILABLE} }, .dependencies =3D BIT(HYPERV_FEAT_SYNIC) | BIT(HYPERV_FEAT_TIME) }, If transitivity is taken into account then the documentation is of course correct (minus that one aforementioned special case). Well, there's no need for us to implement transitional checks. VIR_DOMAIN_HYPERV_STIMER requires VIR_DOMAIN_HYPERV_SYNIC and whether that requires VIR_DOMAIN_HYPERV_VPINDEX is another question. Just drop the transitive check. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/837 Resolves: https://issues.redhat.com/browse/RHEL-138689 Fixes: da261327ea94300d1aa2d3b76ba9dcd4de6160f6 Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_validate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index a8b1029d0c..ed746ba8dc 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -130,7 +130,6 @@ qemuValidateDomainDefHypervFeatures(const virDomainDef = *def) } } =20 - CHECK_HV_FEAT(VIR_DOMAIN_HYPERV_STIMER, VIR_DOMAIN_HYPERV_VPINDEX); CHECK_HV_FEAT(VIR_DOMAIN_HYPERV_STIMER, VIR_DOMAIN_HYPERV_SYNIC); =20 CHECK_HV_FEAT(VIR_DOMAIN_HYPERV_TLBFLUSH, VIR_DOMAIN_HYPERV_VPINDEX); --=20 2.52.0