[libvirt] [PATCH] qemu: remove comments for qemuDomainSecret.*Destroy functions

Ján Tomko posted 1 patch 5 years, 2 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/900aae2c77355851810790f217627bd6f5091eec.1547624736.git.jtomko@redhat.com
src/qemu/qemu_domain.c | 15 ---------------
1 file changed, 15 deletions(-)
[libvirt] [PATCH] qemu: remove comments for qemuDomainSecret.*Destroy functions
Posted by Ján Tomko 5 years, 2 months ago
These all contain the same copy and pasted '@disk' error,
and only repeat the list of arguments.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/qemu/qemu_domain.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index ec6b340308..6f5e3bd826 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -1475,11 +1475,6 @@ qemuDomainSecretInfoTLSNew(qemuDomainObjPrivatePtr priv,
 }
 
 
-/* qemuDomainSecretDiskDestroy:
- * @disk: Pointer to a disk definition
- *
- * Clears unnecessary data associated with disk secret objects.
- */
 void
 qemuDomainSecretDiskDestroy(virDomainDiskDefPtr disk)
 {
@@ -1590,11 +1585,6 @@ qemuDomainSecretStorageSourcePrepare(qemuDomainObjPrivatePtr priv,
 }
 
 
-/* qemuDomainSecretHostdevDestroy:
- * @disk: Pointer to a hostdev definition
- *
- * Clear and destroy memory associated with the secret
- */
 void
 qemuDomainSecretHostdevDestroy(virDomainHostdevDefPtr hostdev)
 {
@@ -1642,11 +1632,6 @@ qemuDomainSecretHostdevPrepare(qemuDomainObjPrivatePtr priv,
 }
 
 
-/* qemuDomainSecretChardevDestroy:
- * @disk: Pointer to a chardev definition
- *
- * Clear and destroy memory associated with the secret
- */
 void
 qemuDomainSecretChardevDestroy(virDomainChrSourceDefPtr dev)
 {
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] qemu: remove comments for qemuDomainSecret.*Destroy functions
Posted by Peter Krempa 5 years, 2 months ago
On Wed, Jan 16, 2019 at 08:45:39 +0100, Ján Tomko wrote:
> These all contain the same copy and pasted '@disk' error,
> and only repeat the list of arguments.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/qemu/qemu_domain.c | 15 ---------------
>  1 file changed, 15 deletions(-)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list