From nobody Sun Oct 5 01:47:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1757424935; cv=none; d=zohomail.com; s=zohoarc; b=eSK2ZXj8wFqDg+K+msP/uvhqY2aW3FwN8c+alkrLrksdYWp2hJfzzElQHIrEjFPDEwHha5kJaLU3F+lNodWVZtqmN2IfC6GsZaYfJhLKVZ/mPQklDil2x4Gpwn2/HnUbLafoJ11I4f/yO2LteQDABG1J/ia8IOcurUj8QqmiEkY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757424935; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=vgR59rOa7GmamUmFYYSbzM9x6UnBTU2of/6wVA5kJ14=; b=A+zTQOglArzbuKBj+JwjwblN+kHh+SCyNQQxKguBqDeKLqMyPBY6/M5aZU6pYaIaqlTgFnnjhdEfq3bYxRpePk70jFl9Abw0xIimjdnE4s5tlxVjgyGiA5fkRYV/hsVhhLtYYNAbbpBFr5QCZUlrpwJrrwTlz3qW3SXDzKnxTyk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1757424935246944.3984529702153; Tue, 9 Sep 2025 06:35:35 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 4BD8341B66; Tue, 9 Sep 2025 09:35:33 -0400 (EDT) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id F01FB43E16; Tue, 9 Sep 2025 09:32:55 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 8F924418E3; Tue, 9 Sep 2025 09:32:14 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id BC1C341B0E for ; Tue, 9 Sep 2025 09:32:13 -0400 (EDT) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-465-OUEqAIIMMXOSUOOK-XkJkg-1; Tue, 09 Sep 2025 09:32:09 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B301B195609F for ; Tue, 9 Sep 2025 13:32:08 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 05189300018D for ; Tue, 9 Sep 2025 13:32:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757424732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vgR59rOa7GmamUmFYYSbzM9x6UnBTU2of/6wVA5kJ14=; b=FcY8gNCGH6uhAl9oFjJra8sPLMBAk6VINNhykpXLBKIlhPPVKN2DLSxq1Wehsfu/C+9d6K gGV9BUswr+0ywNDmCohdPMNjAgZDXqIqBuJWISUfa8sirSl7pGmggwtu7T3pAyGwy7lt5N 9bFQfHFcYCSuMgS/Yz1GUSpkqFBJ8XM= X-MC-Unique: OUEqAIIMMXOSUOOK-XkJkg-1 X-Mimecast-MFC-AGG-ID: OUEqAIIMMXOSUOOK-XkJkg_1757424728 To: devel@lists.libvirt.org Subject: [PATCH 1/4] virprocess: Report errno if virProcessAbort() fails Date: Tue, 9 Sep 2025 15:31:59 +0200 Message-ID: <8d5e29a120849ec60fbcbc3a9c682403d1679c14.1757424690.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: aPm0Weuafu_CDOP59ehli74DJfetm93AIwVHRC4DuFU_1757424728 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: X2P7WCXE5RKMZUVXSANRWFXDNLH35JNN X-Message-ID-Hash: X2P7WCXE5RKMZUVXSANRWFXDNLH35JNN X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1757424935801116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik The aim of virProcessAbort() is to reap a child process. It does so by waitpid()-ing and possibly sending SIGTERM/SIGKILL to the child process (and waitpid()-ing again). Nevertheless, if everything fails a debug message is printed. But the message mentions only the PID and not errno (set by previous waitpid()) which may be useful. For instance when virProcessAbort() is called over a PID that's not our child: failed to reap child 16325, abandoning it: No child processes Signed-off-by: Michal Privoznik --- src/util/virprocess.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/virprocess.c b/src/util/virprocess.c index 3889ba90f9..e8120c1bdc 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -168,7 +168,8 @@ virProcessAbort(pid_t pid) } } } - VIR_DEBUG("failed to reap child %lld, abandoning it", (long long) pid); + VIR_DEBUG("failed to reap child %lld, abandoning it: %s", + (long long) pid, g_strerror(errno)); =20 cleanup: errno =3D saved_errno; --=20 2.49.1