From nobody Sun Feb 8 13:52:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) client-ip=216.205.24.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584552777; cv=none; d=zohomail.com; s=zohoarc; b=G90jI/+NRlOAyIbtRgdsOOSDsCtwwTZQVoPFdCj01daoS6lDgvH5s1odmRSZXXv1rknaR9MxMTH6MvVEJIyk3C6BJCTDxSxru5YkyDMXdDq+sMbr10xprR78sxxWJzVsFj6HRdKg0dNoEGrnbEs0TxP8j1lIF6CbfrP3eg0/TKM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584552777; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=F7H2kKK0hkzNFe8p9OUgdsmoc6nU9o9LBDyUFWxc+Tk=; b=M9dC2wLjQRLzO4BcsEMOf1Bc93NRubn5sHKIfo7Rd1KDAhrTHENhh1ac4uu+nY/crlSXYWAS6eZB8tctXXHUOtIljwDjhhiu8M1X4kT3MzJIAYnXN3tnvolK+lINOhx6vNOoWCk+bN1+iYsa7t1ZHXdfqlF69rMEcCAZeN6KEaA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by mx.zohomail.com with SMTPS id 158455277750925.755902120053406; Wed, 18 Mar 2020 10:32:57 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-379-XdEKFkucP0KzNZXFnQdhmA-1; Wed, 18 Mar 2020 13:32:53 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5A390100CEA4; Wed, 18 Mar 2020 17:32:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2936219756; Wed, 18 Mar 2020 17:32:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B81CF87005; Wed, 18 Mar 2020 17:32:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02IHWSJD029260 for ; Wed, 18 Mar 2020 13:32:28 -0400 Received: by smtp.corp.redhat.com (Postfix) id 245C917B91; Wed, 18 Mar 2020 17:32:28 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9757093509 for ; Wed, 18 Mar 2020 17:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584552776; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=F7H2kKK0hkzNFe8p9OUgdsmoc6nU9o9LBDyUFWxc+Tk=; b=gnY74Lm2CM+WETq8rBpnPl5p0zn2jsekC2Gk+w9yRxc1tLYvPr3uXlbNn/5OK+NoQgrleZ dSgHyGv6G8L5h3HM2qlFtxTwxp/VxmlMvEfEz6saXvN4F2KOPIfoM7CpRj9a5fKihKThDZ K0sCyM9sYR3M7lUZN0w6TQk/u9RWQdk= X-MC-Unique: XdEKFkucP0KzNZXFnQdhmA-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 3/6] qemuDomainBuildNamespace: Make @devPath const Date: Wed, 18 Mar 2020 18:32:13 +0100 Message-Id: <8cd07f4aadd62af55e6a23f3a121480bbc02faba.1584552044.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The @devPath variable is not modifiable. It merely just points to string containing path where private devtmpfs is being constructed. Make it const so it doesn't look weird that it's not freed. Signed-off-by: Michal Privoznik Reviewed-by: Pavel Mores --- src/qemu/qemu_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 2724607311..a4c07fffcb 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -15176,7 +15176,7 @@ qemuDomainBuildNamespace(virQEMUDriverConfigPtr cfg, virDomainObjPtr vm) { struct qemuDomainCreateDeviceData data; - char *devPath =3D NULL; + const char *devPath =3D NULL; char **devMountsPath =3D NULL, **devMountsSavePath =3D NULL; size_t ndevMountsPath =3D 0, i; int ret =3D -1; --=20 2.24.1