From nobody Tue Mar 3 04:55:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1771245991; cv=none; d=zohomail.com; s=zohoarc; b=JWPeQDTkYgbofJ7Zy1F19d4cPoXsbb62ibNBE5EBfcmh6sUINCHam5KdY9Q30IyXMj9BnwjX6x+Js/K7IwXFngXDG9DB/P09At2Yy+NntLV2PQ5nO4+/BYf9QAVaWqqbf/iLHMLKQCjHZ/BPT2zvmabTOkr1dDaXDZZCiR7MsMs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771245991; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=OaQI+PP68u+69warvWvdbNv99GctrrQ1CIczyt5fwDM=; b=HH6WhyxwpdWtSwXwoNpUy1fOXZXDEvI4PqTTMjU7Zp2ynZQsLbrejMSJ0fObkU5YNZ2jsB0mKR33I9s//Rxkun1LsLreAQlhXkwZj0IcJrth+CG3kGS0zGnZl8tryIpzR+ISSbz50oUYRhZaqP/UlISjARp4mpn1FNS85y/LmJk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1771245991836448.12826847040174; Mon, 16 Feb 2026 04:46:31 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id D73A53F8E5; Mon, 16 Feb 2026 07:46:30 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id B635641D5C; Mon, 16 Feb 2026 07:35:18 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 4E85F418B1; Mon, 16 Feb 2026 07:35:14 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9AAD441A3B for ; Mon, 16 Feb 2026 07:28:45 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-198-1-zdsclPNFieBOelOocvrg-1; Mon, 16 Feb 2026 07:28:43 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2BEAD18004BB for ; Mon, 16 Feb 2026 12:28:43 +0000 (UTC) Received: from antique-laptop.rosnicka.net (unknown [10.45.242.10]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8052730001A5 for ; Mon, 16 Feb 2026 12:28:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771244925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OaQI+PP68u+69warvWvdbNv99GctrrQ1CIczyt5fwDM=; b=G0miQ6HDE0hmc1ZdF5vE7gePz/a3gCgavzk9Q2IaCNC+QmTFND5cAv6EEu4uPbS1VIWn2Q afcIJbRh/RYx5RW1Z0Fb/qBYyCEOjCOzBuEPtycaGrGHpZmGdCFsAoKpIf+SOPjWm8fLl4 4uFJmVtZq906pCNxHpbhqrjlsjpx7VI= X-MC-Unique: 1-zdsclPNFieBOelOocvrg-1 X-Mimecast-MFC-AGG-ID: 1-zdsclPNFieBOelOocvrg_1771244923 To: devel@lists.libvirt.org Subject: [libvirt PATCH 22/24] qemu_hotplug: Add support to hotplug host device with IOMMUFD Date: Mon, 16 Feb 2026 13:28:14 +0100 Message-ID: <8c77b689560484c0d3e51421be7d8c3b9ce92878.1771244723.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6gslXzPF_LeBHB3eIFOCJww6FZTrbaWiM1Ik6EmhVnc_1771244923 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ZDB6GBDEN6CRGYTS62OQLP3MCW77HSM2 X-Message-ID-Hash: ZDB6GBDEN6CRGYTS62OQLP3MCW77HSM2 X-MailFrom: phrdina@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Pavel Hrdina via Devel Reply-To: Pavel Hrdina X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1771245992415158500 Content-Type: text/plain; charset="utf-8"; x-default="true" For first host device we need to add iommufd object as well. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_hotplug.c | 39 +++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_process.c | 4 ++-- src/qemu/qemu_process.h | 3 +++ 3 files changed, 44 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 24fbccccf0..bede4e3ccd 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1553,13 +1553,16 @@ qemuDomainAttachHostPCIDevice(virQEMUDriver *driver, virDomainDeviceDef dev =3D { VIR_DOMAIN_DEVICE_HOSTDEV, { .hostdev =3D hostdev } }; virDomainDeviceInfo *info =3D hostdev->info; + qemuDomainHostdevPrivate *hostdevPriv =3D QEMU_DOMAIN_HOSTDEV_PRIVATE(= hostdev); int ret; g_autoptr(virJSONValue) devprops =3D NULL; + g_autoptr(virJSONValue) objprops =3D NULL; bool releaseaddr =3D false; bool teardowncgroup =3D false; bool teardownlabel =3D false; bool teardowndevice =3D false; bool teardownmemlock =3D false; + bool removeiommufd =3D false; g_autoptr(virQEMUDriverConfig) cfg =3D virQEMUDriverGetConfig(driver); unsigned int flags =3D 0; =20 @@ -1609,11 +1612,38 @@ qemuDomainAttachHostPCIDevice(virQEMUDriver *driver, goto error; } =20 + if (virHostdevIsPCIDeviceWithIOMMUFD(hostdev)) { + if (qemuProcessOpenVfioDeviceFd(hostdev) < 0) + goto error; + + if (!priv->iommufdState) { + if (qemuProcessOpenIommuFd(vm) < 0) + goto error; + + if (!(objprops =3D qemuBuildIOMMUFDProps(priv->iommufd))) + goto error; + } + } + if (!(devprops =3D qemuBuildPCIHostdevDevProps(vm->def, hostdev))) goto error; =20 qemuDomainObjEnterMonitor(vm); =20 + if (objprops) { + if ((ret =3D qemuFDPassDirectTransferMonitor(priv->iommufd, priv->= mon)) < 0) + goto exit_monitor; + + if ((ret =3D qemuMonitorAddObject(priv->mon, &objprops, NULL)) < 0) + goto exit_monitor; + + priv->iommufdState =3D true; + removeiommufd =3D true; + } + + if ((ret =3D qemuFDPassDirectTransferMonitor(hostdevPriv->vfioDeviceFd= , priv->mon)) < 0) + goto exit_monitor; + if ((ret =3D qemuDomainAttachExtensionDevice(priv->mon, hostdev->info)= ) < 0) goto exit_monitor; =20 @@ -1644,6 +1674,15 @@ qemuDomainAttachHostPCIDevice(virQEMUDriver *driver, if (teardownmemlock && qemuDomainAdjustMaxMemLock(vm) < 0) VIR_WARN("Unable to reset maximum locked memory on hotplug fail"); =20 + if (removeiommufd) { + qemuDomainObjEnterMonitor(vm); + ignore_value(qemuMonitorDelObject(priv->mon, "iommufd0", false)); + qemuDomainObjExitMonitor(vm); + } + + qemuFDPassDirectTransferMonitorRollback(hostdevPriv->vfioDeviceFd, pri= v->mon); + qemuFDPassDirectTransferMonitorRollback(priv->iommufd, priv->mon); + if (releaseaddr) qemuDomainReleaseDeviceAddress(vm, info); =20 diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index fc7e7bc980..371b64faac 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7685,7 +7685,7 @@ qemuProcessPrepareHostBackendChardevHotplug(virDomain= Obj *vm, * * Returns: 0 on success, -1 on failure */ -static int +int qemuProcessOpenIommuFd(virDomainObj *vm) { qemuDomainObjPrivate *priv =3D vm->privateData; @@ -7709,7 +7709,7 @@ qemuProcessOpenIommuFd(virDomainObj *vm) * * Returns: 0 on success, -1 on failure */ -static int +int qemuProcessOpenVfioDeviceFd(virDomainHostdevDef *hostdev) { qemuDomainHostdevPrivate *hostdevPriv =3D QEMU_DOMAIN_HOSTDEV_PRIVATE(= hostdev); diff --git a/src/qemu/qemu_process.h b/src/qemu/qemu_process.h index 6ba846b7b1..fccd41e1a6 100644 --- a/src/qemu/qemu_process.h +++ b/src/qemu/qemu_process.h @@ -134,6 +134,9 @@ int qemuProcessPrepareHostBackendChardevHotplug(virDoma= inObj *vm, virDomainDeviceDef *dev) ATTRIBUTE_MOCKABLE; =20 +int qemuProcessOpenIommuFd(virDomainObj *vm); + +int qemuProcessOpenVfioDeviceFd(virDomainHostdevDef *hostdev); =20 int qemuProcessPrepareHost(virQEMUDriver *driver, virDomainObj *vm, --=20 2.53.0