From nobody Mon Feb 9 06:33:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1565340564; cv=none; d=zoho.com; s=zohoarc; b=dytt24TL1FO2OEG4ktLV0fHk+iWm7NLndzz060Ph3OcbTtVM0VupwrNd53R3LOdhjIsRHxehJKi8AxRmCy5GpfAeQReMTCoZWCwIbLc1TBk3tbJzHDAeYpnUoesQpNz8F4b1SmpeWAm05cE9+DgliVpW1hVXpGWLQE9F/h8o8SI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565340564; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=EAlEtKi26Dag32H23QEyby6BsYEb1JLTPg/Y48aF4uk=; b=bEpq4f5id4l2PMNCmhF3S4aIo3Mu9+RO8e4t/UsC/Xoloikv4fyzZfSNGpaYjgAupBOBnlCiokvDBgQPzgI7aGfnnpBJw5zooS2ciJS+jur8TXEmcHN69793X8JMIf4XWod2UCXnfsVOaxYHIHTfdAqp25ZquSdMvt/bKIIdMgQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1565340564792153.31975776346053; Fri, 9 Aug 2019 01:49:24 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B2867821CB; Fri, 9 Aug 2019 08:49:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F58F1000182; Fri, 9 Aug 2019 08:49:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1FF20180B536; Fri, 9 Aug 2019 08:49:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x798nKZT014351 for ; Fri, 9 Aug 2019 04:49:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1EC155D9E1; Fri, 9 Aug 2019 08:49:20 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9EA5B5D9D6 for ; Fri, 9 Aug 2019 08:49:19 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Fri, 9 Aug 2019 10:49:11 +0200 Message-Id: <8c394c1236b25737d5535b9a1cba86b60a9dc3b1.1565340411.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/3] nss: Don't leak memory on parse error X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 09 Aug 2019 08:49:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" If yajl_parse() fails, we try to print an error message. For that, yajl_get_error() is used. However, its documentation say that caller is also responsible for freeing the memory it allocates by using yajl_free_error(). Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 --- tools/nss/libvirt_nss_leases.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/nss/libvirt_nss_leases.c b/tools/nss/libvirt_nss_leases.c index 577b5a2fd1..977e3415f7 100644 --- a/tools/nss/libvirt_nss_leases.c +++ b/tools/nss/libvirt_nss_leases.c @@ -399,9 +399,10 @@ findLeases(const char *file, =20 if (yajl_parse(parser, (const unsigned char *)line, rv) !=3D yajl_status_ok) { - ERROR("Parse failed %s", - yajl_get_error(parser, 1, - (const unsigned char*)line, rv)); + unsigned char *err =3D yajl_get_error(parser, 1, + (const unsigned char*)line= , rv); + ERROR("Parse failed %s", (const char *) err); + yajl_free_error(parser, err); goto cleanup; } } --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list