From nobody Tue Oct 28 08:35:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1760518483; cv=none; d=zohomail.com; s=zohoarc; b=Pqz45Lq+Uyg8kEZV2fZO1gHv7HNpLl/p8OICNEtqQEJEa4npVazctUkMGhBndBb/ZPMp832qQe1OttIbrkAjXfdkwrYzXlybLcPcV7n4yd8cQihY8KQY0+uw62+mqCzdnkiqEc8luDB58osCtIMMyeT4pxzoRB2tfsMep2cUAfI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760518483; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=pylrlqzI4YluptNPyeoUMOlOn2pXsje1AfjZV5Zfy/I=; b=Q0T/nvjcaLOkq7mx5icdAD6J4cUfwM0pE6wfqMNnMu8GxXsPk2ksIsaST4hP/IPUyH0W3j96LEYqzXGC2JkGibRamdsk7duclQ6Z0jJBpngUU2x/wS5yTv1iVvb1yT/wX1fd1q0ozq7jBKvk3Dz9fiIEOrpmiBSguZ2N0Ts4zrU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1760518483776468.63884381684534; Wed, 15 Oct 2025 01:54:43 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id B676444189; Wed, 15 Oct 2025 04:54:42 -0400 (EDT) Received: from [172.19.199.20] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 0391044210; Wed, 15 Oct 2025 04:53:54 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id EA04044150; Wed, 15 Oct 2025 04:52:34 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 1C3AC41C01 for ; Wed, 15 Oct 2025 04:52:34 -0400 (EDT) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-NkjgYiDMMOqUZtAfX_WD0g-1; Wed, 15 Oct 2025 04:52:32 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B8CF219560A0 for ; Wed, 15 Oct 2025 08:52:31 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1D46E1800446 for ; Wed, 15 Oct 2025 08:52:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760518353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pylrlqzI4YluptNPyeoUMOlOn2pXsje1AfjZV5Zfy/I=; b=R6FVsqugF89YCZDYJsh3QWDo04veS99QciI608ycxpJ1LIEqbYjmGkOhFhNK6Nx/O3V49S xMIdUh5ne65ZFUBsLFkr7SeJDY4prRIvzyAP9nQyz0av2BuU2ExJly6W03sH5M5h6CgwIU 6hHhiIDBCAJEM2xSRUT8b/l2C1ZY02E= X-MC-Unique: NkjgYiDMMOqUZtAfX_WD0g-1 X-Mimecast-MFC-AGG-ID: NkjgYiDMMOqUZtAfX_WD0g_1760518351 To: devel@lists.libvirt.org Subject: [PATCH] qemu: Drop reconnectBlockjobs from _qemuDomainObjPrivate struct Date: Wed, 15 Oct 2025 10:52:28 +0200 Message-ID: <8ba28379d4308f5b82a516249ef47fe8125d46fb.1760518338.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 71_bZxkY9lc1Hyiq1QNKg6whFWF0XuWI93hC2KQn8tU_1760518351 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: U4DZG7TQ2R445HMBPQN7WHDIP5MHMC5A X-Message-ID-Hash: U4DZG7TQ2R445HMBPQN7WHDIP5MHMC5A X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1760518493496158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik The 'reconnectBlockjobs' member of the _qemuDomainObjPrivate struct is basically unused after v8.7.0-rc1~110. It's not even formatted into the status XML, just parsed. This makes needless noise. Just drop the member. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/qemu/qemu_domain.c | 7 ------- src/qemu/qemu_domain.h | 3 --- 2 files changed, 10 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 60a4bcc64c..375e0e441a 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1907,7 +1907,6 @@ qemuDomainObjPrivateDataClear(qemuDomainObjPrivate *p= riv) =20 priv->rememberOwner =3D false; =20 - priv->reconnectBlockjobs =3D VIR_TRISTATE_BOOL_ABSENT; priv->allowReboot =3D VIR_TRISTATE_BOOL_ABSENT; =20 g_clear_pointer(&priv->migrationCaps, virBitmapFree); @@ -3211,14 +3210,8 @@ qemuDomainObjPrivateXMLParseBlockjobs(virDomainObj *= vm, { g_autofree xmlNodePtr *nodes =3D NULL; ssize_t nnodes =3D 0; - g_autofree char *active =3D NULL; - int tmp; size_t i; =20 - if ((active =3D virXPathString("string(./blockjobs/@active)", ctxt)) && - (tmp =3D virTristateBoolTypeFromString(active)) > 0) - priv->reconnectBlockjobs =3D tmp; - if ((nnodes =3D virXPathNodeSet("./blockjobs/blockjob", ctxt, &nodes))= < 0) return -1; =20 diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 5ccd3b2dbb..f4945f598a 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -195,9 +195,6 @@ struct _qemuDomainObjPrivate { /* If true virtlogd is used as stdio handler for character devices. */ bool chardevStdioLogd; =20 - /* Tracks blockjob state for vm. Valid only while reconnecting to qemu= . */ - virTristateBool reconnectBlockjobs; - /* Migration capabilities. Rechecked on reconnect, not to be saved in * private XML. */ virBitmap *migrationCaps; --=20 2.51.0