From nobody Mon Feb 9 12:11:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1642772431; cv=none; d=zohomail.com; s=zohoarc; b=erU3icQ15dpoMV784u6F3qoeYS5xeGYj5Aj71cqVf3yZJiYt15J93kLXuOsM26RLM7qxbVVVQp1We25SwlgzglaxZbuPUykVGMS8x1s2qyfROJWVbNoL7EZKcZCLq1USjyT7desKxtnIUskVdEaB21ZOudJt1lUMHpFVKr8ztPE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642772431; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zvLGzup4XBrBpYX38NriuxxM5lWH7Z9YRmu3ogiUnTE=; b=ARwCzbXIq3nx0SJJlVFHMYouY9AXXSLCeKAi3p6WkVcXTo9sEMMDQ6b0mp7TgT0F79AblMwSWiyISlYy8224G/lbhBTEO6Fipj/HjL4etywGrBciWdd6EZoWlreSK+qN8i4pdpyBBeK5hyKQO2is1YzGOqRWeYK9NbXcC+KN3Fs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1642772431075522.970190705359; Fri, 21 Jan 2022 05:40:31 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-125-ep5iy8QVNYCxy7Z0_E6dIg-1; Fri, 21 Jan 2022 08:40:26 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7F65351084; Fri, 21 Jan 2022 13:40:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 58ABD7E227; Fri, 21 Jan 2022 13:40:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EC75D4CA9B; Fri, 21 Jan 2022 13:40:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20LDSRu8011950 for ; Fri, 21 Jan 2022 08:28:27 -0500 Received: by smtp.corp.redhat.com (Postfix) id 4EF451090022; Fri, 21 Jan 2022 13:28:27 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id CD0FF108F850 for ; Fri, 21 Jan 2022 13:28:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642772430; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zvLGzup4XBrBpYX38NriuxxM5lWH7Z9YRmu3ogiUnTE=; b=Iz9mDXdRAS0EKHJh76Q5YB5naVwOWaK33jMjzcceq1aQTjnOSeEY1gHIakE8RMlNvjCNx/ ZvgYEDIcDDHy3mZg1VLpvPuG0mcBUOuJuxslwDfSj+lmF92kzqb6OOBTajJPmIYuqWStsG z9iUC10Qs+w0o8Wax/O6TWsKKQAAVyk= X-MC-Unique: ep5iy8QVNYCxy7Z0_E6dIg-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 03/12] qemuValidateDomainDeviceDefFS: Use correct enum for fs->multidevs comparison Date: Fri, 21 Jan 2022 14:28:10 +0100 Message-Id: <8b1743d483179d39ec6a426a268bd399f12f9206.1642771642.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1642772432825100001 Content-Type: text/plain; charset="utf-8" During validation of a virDomainFSDef QEMU capabilities are check for multidevs support if the FS definition has it enabled. However, the fs->multidevs is really type of virDomainFSMultidevs but is compared against virDomainFSModel enum. Fortunately, both values are the same so no user visible harm done here. Signed-off-by: Michal Privoznik --- src/qemu/qemu_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index ae0ee4e744..24e0866f8c 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -4234,7 +4234,7 @@ qemuValidateDomainDeviceDefFS(virDomainFSDef *fs, _("only supports mount filesystem type")); return -1; } - if (fs->multidevs !=3D VIR_DOMAIN_FS_MODEL_DEFAULT && + if (fs->multidevs !=3D VIR_DOMAIN_FS_MULTIDEVS_DEFAULT && !virQEMUCapsGet(qemuCaps, QEMU_CAPS_FSDEV_MULTIDEVS)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("multidevs is not supported with this QEMU binary= ")); --=20 2.34.1