From nobody Mon Dec 15 23:05:18 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1658846383; cv=none; d=zohomail.com; s=zohoarc; b=i4IY3VgFelh+KwLghC7sBfAy/pWEhVeQ1mTssrwbX25uUpereuSRXi9VzmSOMjneUDR6Vj9tt8ZmHTxKtqlBHxBw/8LaHZlYFjw2ezPPpDklmI3mSYckOeTd8/uc0As16Jkt5/YLMmW5wuFJoTHTC0mVHPMsjsMr3vEvgcus6UE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658846383; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=f7D0XWlfKZlwIbhy7ZfqbtAY68FeNSN54Ouh7mF2I1k=; b=Pi0BSvpxqAMQavTQ7vbIOqFk+i7cZCrleWpyRwsaGe8i5wBAtbUkbSh0BIyJPAUYOna90MxwrDtXGDScQ7fMfGvNl9yk4Zdr5EKZXT/umeMNxv0C645RQzrH2DGQMtlgglQU9K79M9nGgKQbsce+VS9G8nhDhsZvT9HaUCdMxFk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1658846383493418.7705241666928; Tue, 26 Jul 2022 07:39:43 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-665-5kzwOZ9OO9SDAQl8bpJpog-1; Tue, 26 Jul 2022 10:39:36 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7580A858F00; Tue, 26 Jul 2022 14:39:15 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5EB881415125; Tue, 26 Jul 2022 14:39:15 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E08E11940378; Tue, 26 Jul 2022 14:39:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 43E2A194707B for ; Tue, 26 Jul 2022 14:39:08 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 2C06F400DFD7; Tue, 26 Jul 2022 14:39:08 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0ED5540466AA for ; Tue, 26 Jul 2022 14:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658846382; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=f7D0XWlfKZlwIbhy7ZfqbtAY68FeNSN54Ouh7mF2I1k=; b=HsWXiLjYM2BQdDZLAqQiwI01pjIlfsh80Frl7tlCYti0ox0fFb/M/6eZiPqYvs+eMiMrwq o+yLM4WmL7yRqGkjvQLbMWtqmfHRoqZu9HGIna5a4qLv4Z5Vqav//95G/v72mAh3VOsvPv fzpotsY0rJIiRgSG2g2nCkG9CgDtfh0= X-MC-Unique: 5kzwOZ9OO9SDAQl8bpJpog-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 69/80] qemuDomainSecretStorageSourcePrepare: Remove cabapbility check when preparing cookies Date: Tue, 26 Jul 2022 16:37:47 +0200 Message-Id: <8b0c045dbcb5e4b4cb93a777e4a8d95ed05e5f95.1658843187.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1658846384453100009 Content-Type: text/plain; charset="utf-8" The capability is checked when we validate the source in the first place. Also it won't make sense any more. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina --- src/qemu/qemu_domain.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 32319c1503..fb29135179 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1322,7 +1322,6 @@ qemuDomainSecretStorageSourcePrepare(qemuDomainObjPri= vate *priv, } if (src->ncookies && - virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV) && !(srcPriv->httpcookie =3D qemuDomainSecretStorageSourcePrepareCook= ies(priv, = src, = aliasprotocol))) --=20 2.36.1