From nobody Sun Feb 8 15:46:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1636730584; cv=none; d=zohomail.com; s=zohoarc; b=kvx+Azirp6FlvpifH8cMsrczjptC59g0uXKzmQmVIgYtFR6n+Kh+kKdk47lxyBs6v76YJcFHzHoIYsK9u1sFqbfSzW/X2TmMxEAoDLw5u2i0T5AjbbMbuRQfQanep3w6nBSqTwP3Iurm3wkFhLSU7YyiSJP8hzozVeiOZ5jo22s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636730584; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OlbREZKyJ33bqJ5s55LuExLBdznEi73vYtz7ALFcLTE=; b=h5CitD6ROtwGprUrpSwz7Lpf3B1LysqbXef4FljdXxOhStVWyL0R3OasuojsgXZe9XkINJv1Sn39CsX1ehQPL/9Ixm7mN9J0URRB10q/eqVx+O8q6yqdspYAxk2MuvVg1kMzD1BbwcevyZLnM/n0ZI0s0IIEiEiLL4gWhR81pa0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1636730584526289.46683394468846; Fri, 12 Nov 2021 07:23:04 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-206-birSCH0IPd6AHAJu8kmXLg-1; Fri, 12 Nov 2021 10:22:59 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EFF02100CFB3; Fri, 12 Nov 2021 15:22:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CBFE55D6D5; Fri, 12 Nov 2021 15:22:54 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9C84A1832DD6; Fri, 12 Nov 2021 15:22:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1ACFMiwf014373 for ; Fri, 12 Nov 2021 10:22:44 -0500 Received: by smtp.corp.redhat.com (Postfix) id 4BEC560C4A; Fri, 12 Nov 2021 15:22:44 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id C6BB060C17 for ; Fri, 12 Nov 2021 15:22:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636730583; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=OlbREZKyJ33bqJ5s55LuExLBdznEi73vYtz7ALFcLTE=; b=a8/czDLY72uMPsOl5JO8Ill+nxabdb/CxIjmYszyYCpsEMJ91NqWC5fuM2RFqJJ+dIXd2s Lz30NfXImjifTfOqzx7B5JSsWLCjag5c+AzKItAeyWtImlATyoEnqJ6GRmjqtyXwrjd8cT /+xsqDAt9BKmoSaLmAmv5y2m2MjoZBc= X-MC-Unique: birSCH0IPd6AHAJu8kmXLg-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 2/4] examples/dommigrate: Don't set retval in usage() Date: Fri, 12 Nov 2021 16:22:33 +0100 Message-Id: <8b03dcef2bf2dac3f42490472a4273db1757576d.1636730459.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1636730584913100003 Content-Type: text/plain; charset="utf-8" The usage() function should just print expected arguments. Make the function return void then. Signed-off-by: Michal Privoznik --- examples/c/domain/dommigrate.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/examples/c/domain/dommigrate.c b/examples/c/domain/dommigrate.c index 60cfb3fb83..b1641efb9a 100644 --- a/examples/c/domain/dommigrate.c +++ b/examples/c/domain/dommigrate.c @@ -26,11 +26,10 @@ #include =20 =20 -static int -usage(char *prgn, int ret) +static void +usage(char *prgn) { printf("Usage: %s \n", prgn); - return ret; } =20 int @@ -42,7 +41,7 @@ main(int argc, char *argv[]) virDomainPtr dom =3D NULL; =20 if (argc < 4) { - ret =3D usage(argv[0], 1); + usage(argv[0]); goto out; } =20 --=20 2.32.0