From nobody Sat Nov 23 14:26:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1715863770121525.3771693791977; Thu, 16 May 2024 05:49:30 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 0B36D1A8D; Thu, 16 May 2024 08:49:29 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id B5B5A1AE1; Thu, 16 May 2024 08:48:18 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id DD10417DD; Thu, 16 May 2024 08:48:12 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 384661812 for ; Thu, 16 May 2024 08:48:12 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-335-ygmLU_ahP02J2bxQCahQ3g-1; Thu, 16 May 2024 08:48:09 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3A0651C05133 for ; Thu, 16 May 2024 12:48:09 +0000 (UTC) Received: from maggie.brq.redhat.com (unknown [10.43.3.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id D8EA440C6EB7 for ; Thu, 16 May 2024 12:48:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715863691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XhPd9PZcPXcR5UShKHhFEo+WUkGdK4M/FiVQml+EecY=; b=OdhWTSikE5bILqkVO9C+Rg9wh7WIptgMC4akqVfRS0QUVpuKjLMJl6rYNFqwRqIgxReRB8 gvPmAD+TL8mqYyk+lW8fOrKkZ06Ga2kamJo8YhSJMw1WuXYkA6ZIwtC9vqdSPeL5AQ7SMu 0e6hLHNH91qof/majtI1j3jitB0vMrA= X-MC-Unique: ygmLU_ahP02J2bxQCahQ3g-1 From: Michal Privoznik To: devel@lists.libvirt.org Subject: [PATCH 1/2] qemu_process: Issue an info message when subtracting isolcpus Date: Thu, 16 May 2024 14:48:05 +0200 Message-ID: <8a1baa792b24683716ef7aa71286178c773f6ac0.1715863651.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: C5ANOXIYOHWCBUDX66NHEV27EIYYIIV3 X-Message-ID-Hash: C5ANOXIYOHWCBUDX66NHEV27EIYYIIV3 X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1715863770602100001 Content-Type: text/plain; charset="utf-8"; x-default="true" In one of my previous commits I've made us substract isolcpus from all online CPUs when setting affinity on QEMU threads. See commit below for more info on that. Nevertheless, this is something that surely deserves an entry in log. I've chosen INFO priority for now. We can promote that to a regular WARN if users complain. Fixes: da95bcb6b2d9b04958e0f2603202801dd29debb8 Signed-off-by: Michal Privoznik --- src/qemu/qemu_process.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 7ef7040a85..2c33ac3bf7 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -2348,6 +2348,12 @@ qemuProcessGetAllCpuAffinity(virBitmap **cpumapRet) return -1; =20 if (isolCpus) { + g_autofree char *isolCpusStr =3D virBitmapFormat(isolCpus); + g_autofree char *cpumapRetStr =3D virBitmapFormat(*cpumapRet); + + VIR_INFO("Subtracting isolated CPUs %1$s from online CPUs %2$s", + isolCpusStr, cpumapRetStr); + virBitmapSubtract(*cpumapRet, isolCpus); } =20 --=20 2.43.2