From nobody Sun Feb 8 23:37:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.39 as permitted sender) client-ip=209.132.183.39; envelope-from=libvir-list-bounces@redhat.com; helo=mx6-phx2.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.39 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx6-phx2.redhat.com (mx6-phx2.redhat.com [209.132.183.39]) by mx.zohomail.com with SMTPS id 1486369502069913.6331265458881; Mon, 6 Feb 2017 00:25:02 -0800 (PST) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx6-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v168LoSZ042000; Mon, 6 Feb 2017 03:21:50 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v168LUhs022147 for ; Mon, 6 Feb 2017 03:21:30 -0500 Received: from lisa.redhat.com (ovpn-204-17.brq.redhat.com [10.40.204.17]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v168LO2S020197 for ; Mon, 6 Feb 2017 03:21:29 -0500 From: Michal Privoznik To: libvir-list@redhat.com Date: Mon, 6 Feb 2017 09:21:21 +0100 Message-Id: <89d0a6151b06999ebf208530d31426036ffdf8fc.1486369246.git.mprivozn@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 5/5] xenFoxenFormatXLDisk: Don't leak @target X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" =3D=3D11260=3D=3D 1,006 bytes in 1 blocks are definitely lost in loss recor= d 106 of 111 =3D=3D11260=3D=3D at 0x4C2AE5F: malloc (vg_replace_malloc.c:297) =3D=3D11260=3D=3D by 0x4C2BDFF: realloc (vg_replace_malloc.c:693) =3D=3D11260=3D=3D by 0x4EA430B: virReallocN (viralloc.c:245) =3D=3D11260=3D=3D by 0x4EA7C52: virBufferGrow (virbuffer.c:130) =3D=3D11260=3D=3D by 0x4EA7D28: virBufferAdd (virbuffer.c:165) =3D=3D11260=3D=3D by 0x4EA8E10: virBufferStrcat (virbuffer.c:718) =3D=3D11260=3D=3D by 0x42D263: xenFormatXLDiskSrcNet (xen_xl.c:960) =3D=3D11260=3D=3D by 0x42D4EB: xenFormatXLDiskSrc (xen_xl.c:1015) =3D=3D11260=3D=3D by 0x42D870: xenFormatXLDisk (xen_xl.c:1101) =3D=3D11260=3D=3D by 0x42DA89: xenFormatXLDomainDisks (xen_xl.c:1148) =3D=3D11260=3D=3D by 0x42EAF8: xenFormatXL (xen_xl.c:1558) =3D=3D11260=3D=3D by 0x40E85F: testCompareParseXML (xlconfigtest.c:105) Signed-off-by: Michal Privoznik --- src/xenconfig/xen_xl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index 18d9fe369..2c9174e53 100644 --- a/src/xenconfig/xen_xl.c +++ b/src/xenconfig/xen_xl.c @@ -1034,6 +1034,7 @@ xenFormatXLDisk(virConfValuePtr list, virDomainDiskDe= fPtr disk) int format =3D virDomainDiskGetFormat(disk); const char *driver =3D virDomainDiskGetDriver(disk); char *target =3D NULL; + int ret =3D -1; =20 /* format */ virBufferAddLit(&buf, "format=3D"); @@ -1119,12 +1120,12 @@ xenFormatXLDisk(virConfValuePtr list, virDomainDisk= DefPtr disk) tmp->next =3D val; else list->list =3D val; - return 0; + ret =3D 0; =20 cleanup: VIR_FREE(target); virBufferFreeAndReset(&buf); - return -1; + return ret; } =20 =20 --=20 2.11.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list