From nobody Sun Feb 8 18:24:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564155077; cv=none; d=zoho.com; s=zohoarc; b=WivpyC6ZwDbzHNvZIrFkVgc/LEgAM6BMWFhmKovbA0DpB3Mhn/kKtN9jXQ+nJf/vKYc4uQfKZhsPviWEWoyeWyNn7xWRy9EEilT73x5RvwlAxRk8MsLxlw6tgkiYGu8DUH6b+NsHHuBN3c7lVhjPNz/0kV8YLFcH7mdJiwS/ubE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564155077; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=1aAQfGm6PLnBBrWMsl196Ou7XIjxr/tm+PEXwswUM+o=; b=a0ITLIN5z1tO1SGuTvbIKUCxSWoU1djsm9YoDuRscLYWRdcMyVSa47qQkmI9g63VlzV7ihMsjzfc6o2uQl2fFd96zr7uF9DVlgssGWMW8SmsT9nw6xp/rb8Gkii0vn3Y9b+LdKIBO0eWh1757MqWGJymLQ17qsrwMc0iC7Et1Zc= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1564155077488576.1840096248794; Fri, 26 Jul 2019 08:31:17 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4D1AF308FBB4; Fri, 26 Jul 2019 15:31:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1CC8A19729; Fri, 26 Jul 2019 15:31:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D232E18045D3; Fri, 26 Jul 2019 15:31:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6QFV3sD004199 for ; Fri, 26 Jul 2019 11:31:03 -0400 Received: by smtp.corp.redhat.com (Postfix) id 99739396B; Fri, 26 Jul 2019 15:31:03 +0000 (UTC) Received: from virval.usersys.redhat.com (unknown [10.43.2.188]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6F18B1C2 for ; Fri, 26 Jul 2019 15:31:00 +0000 (UTC) Received: by virval.usersys.redhat.com (Postfix, from userid 500) id 93880100115; Fri, 26 Jul 2019 17:30:59 +0200 (CEST) From: Jiri Denemark To: libvir-list@redhat.com Date: Fri, 26 Jul 2019 17:30:55 +0200 Message-Id: <8963841b4fbb876dd158061670a7dd684bf8766a.1564154901.git.jdenemar@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 4/5] cpu: Drop unused KVM features X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Fri, 26 Jul 2019 15:31:16 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Most of the internally defined KVM CPUID features are not actually used by libvirt. The QEMU driver may enable or disable them on the command line, but we don't check for the associated CPU properties or CPUID bits. They would be useless with QEMU 4.1 anyway since their names were only remotely similar to the actual feature names. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 24 ------------------------ src/cpu/cpu_x86_data.h | 8 -------- 2 files changed, 32 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index f8a51dedf6..387c365512 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -73,24 +73,8 @@ struct _virCPUx86Feature { } \ } =20 -KVM_FEATURE_DEF(VIR_CPU_x86_KVM_CLOCKSOURCE, - 0x40000001, 0x00000001); -KVM_FEATURE_DEF(VIR_CPU_x86_KVM_NOP_IO_DELAY, - 0x40000001, 0x00000002); -KVM_FEATURE_DEF(VIR_CPU_x86_KVM_MMU_OP, - 0x40000001, 0x00000004); -KVM_FEATURE_DEF(VIR_CPU_x86_KVM_CLOCKSOURCE2, - 0x40000001, 0x00000008); -KVM_FEATURE_DEF(VIR_CPU_x86_KVM_ASYNC_PF, - 0x40000001, 0x00000010); -KVM_FEATURE_DEF(VIR_CPU_x86_KVM_STEAL_TIME, - 0x40000001, 0x00000020); -KVM_FEATURE_DEF(VIR_CPU_x86_KVM_PV_EOI, - 0x40000001, 0x00000040); KVM_FEATURE_DEF(VIR_CPU_x86_KVM_PV_UNHALT, 0x40000001, 0x00000080); -KVM_FEATURE_DEF(VIR_CPU_x86_KVM_CLOCKSOURCE_STABLE_BIT, - 0x40000001, 0x01000000); =20 KVM_FEATURE_DEF(VIR_CPU_x86_HV_RUNTIME, 0x40000003, 0x00000001); @@ -121,15 +105,7 @@ KVM_FEATURE_DEF(VIR_CPU_x86_HV_EVMCS, =20 static virCPUx86Feature x86_kvm_features[] =3D { - KVM_FEATURE(VIR_CPU_x86_KVM_CLOCKSOURCE), - KVM_FEATURE(VIR_CPU_x86_KVM_NOP_IO_DELAY), - KVM_FEATURE(VIR_CPU_x86_KVM_MMU_OP), - KVM_FEATURE(VIR_CPU_x86_KVM_CLOCKSOURCE2), - KVM_FEATURE(VIR_CPU_x86_KVM_ASYNC_PF), - KVM_FEATURE(VIR_CPU_x86_KVM_STEAL_TIME), - KVM_FEATURE(VIR_CPU_x86_KVM_PV_EOI), KVM_FEATURE(VIR_CPU_x86_KVM_PV_UNHALT), - KVM_FEATURE(VIR_CPU_x86_KVM_CLOCKSOURCE_STABLE_BIT), KVM_FEATURE(VIR_CPU_x86_HV_RUNTIME), KVM_FEATURE(VIR_CPU_x86_HV_SYNIC), KVM_FEATURE(VIR_CPU_x86_HV_STIMER), diff --git a/src/cpu/cpu_x86_data.h b/src/cpu/cpu_x86_data.h index 85aaab709c..2607dd96b1 100644 --- a/src/cpu/cpu_x86_data.h +++ b/src/cpu/cpu_x86_data.h @@ -43,15 +43,7 @@ struct _virCPUx86MSR { #define CPUX86_KVM 0x40000000 #define CPUX86_EXTENDED 0x80000000 =20 -#define VIR_CPU_x86_KVM_CLOCKSOURCE "__kvm_clocksource" -#define VIR_CPU_x86_KVM_NOP_IO_DELAY "__kvm_no_io_delay" -#define VIR_CPU_x86_KVM_MMU_OP "__kvm_mmu_op" -#define VIR_CPU_x86_KVM_CLOCKSOURCE2 "__kvm_clocksource2" -#define VIR_CPU_x86_KVM_ASYNC_PF "__kvm_async_pf" -#define VIR_CPU_x86_KVM_STEAL_TIME "__kvm_steal_time" -#define VIR_CPU_x86_KVM_PV_EOI "__kvm_pv_eoi" #define VIR_CPU_x86_KVM_PV_UNHALT "__kvm_pv_unhalt" -#define VIR_CPU_x86_KVM_CLOCKSOURCE_STABLE_BIT "__kvm_clocksource_stable" =20 /* * The following HyperV feature names suffixes must exactly match correspo= nding --=20 2.22.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list