From nobody Sun Feb 8 10:04:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601039962; cv=none; d=zohomail.com; s=zohoarc; b=ZPxGBw6RHfHFyOk1XMnAjberEcKlm7WV8CZylUR/rmqemf2jsYuJTekE8AwK0jy4lrWT0jYs38wBp/kcgj8YL4GNfHkHeBGF6+sgYwMluTLSWdaHmH7LOwEWSYpxU/FwqZhQuyKAq5ht0ND4mAM63nLhewieIwW30AiEoR/dOXY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601039962; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EOaRN/IEm5VG2EURFWrAhq2KfEUwH9RsxgH4+EKy0Zc=; b=cOXsBj6rJkGQr8AkAEFLxYHgqo2Ni9jw0G3nneqMqe7GReKIMDJWXL62X6+0LVL9Aa6Xffir7KM+RqkjPGDD5xVGzpFWj9AOW/bMpvxgr7a7wxJoeRWnj9/H0S+bxHjQJqP0evsmDkRhO7zEdTVj2AFNeB1mwzvFD69q481tygs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1601039962654899.3305398655039; Fri, 25 Sep 2020 06:19:22 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-555-u-lhTP_IOPC5RYy1ig9-rg-1; Fri, 25 Sep 2020 09:19:18 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0DDB064158; Fri, 25 Sep 2020 13:19:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DAF8555789; Fri, 25 Sep 2020 13:19:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A99DB8C7A9; Fri, 25 Sep 2020 13:19:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08PDGSkv005192 for ; Fri, 25 Sep 2020 09:16:28 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4C1755C1C2; Fri, 25 Sep 2020 13:16:28 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id C52175C1BB for ; Fri, 25 Sep 2020 13:16:25 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601039961; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=EOaRN/IEm5VG2EURFWrAhq2KfEUwH9RsxgH4+EKy0Zc=; b=LyqrnT6cR0NxRSHiPgJlaOpsEHcbHvrrIyAbBqNvuiw6u4AYDgPhNEwpgHjCS5lu0yImlc 8Q4aXIXK14rJ9vn9FGfgk4DHQWTpfxZkd9sjo1cSksZCNU3OQo8uuroZpeY8qyPTBFZBa1 KUTveWp3BJSxdYThbDnbnJUfce90AoY= X-MC-Unique: u-lhTP_IOPC5RYy1ig9-rg-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 6/7] storage: scsi: invert logic in createVport Date: Fri, 25 Sep 2020 15:16:12 +0200 Message-Id: <892da6d53c655bccec88dab3155e7f4f53e7f5f9.1601039656.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Check whether the alloc result is negative (which is cannot happen with current code) to reduce churn in the following commit. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- src/storage/storage_backend_scsi.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/storage/storage_backend_scsi.c b/src/storage/storage_backe= nd_scsi.c index e528d7622c..b5866935d1 100644 --- a/src/storage/storage_backend_scsi.c +++ b/src/storage/storage_backend_scsi.c @@ -329,16 +329,17 @@ createVport(virStoragePoolDefPtr def, * retry logic set to true. If the thread isn't created, then no big * deal since it's still possible to refresh the pool later. */ - if (VIR_ALLOC(cbdata) =3D=3D 0) { - memcpy(cbdata->pool_uuid, def->uuid, VIR_UUID_BUFLEN); - cbdata->fchost_name =3D g_steal_pointer(&name); + if (VIR_ALLOC(cbdata) < 0) + return -1; =20 - if (virThreadCreateFull(&thread, false, virStoragePoolFCRefreshThr= ead, - "scsi-refresh", false, cbdata) < 0) { - /* Oh well - at least someone can still refresh afterwards */ - VIR_DEBUG("Failed to create FC Pool Refresh Thread"); - virStoragePoolFCRefreshDataFree(cbdata); - } + memcpy(cbdata->pool_uuid, def->uuid, VIR_UUID_BUFLEN); + cbdata->fchost_name =3D g_steal_pointer(&name); + + if (virThreadCreateFull(&thread, false, virStoragePoolFCRefreshThread, + "scsi-refresh", false, cbdata) < 0) { + /* Oh well - at least someone can still refresh afterwards */ + VIR_DEBUG("Failed to create FC Pool Refresh Thread"); + virStoragePoolFCRefreshDataFree(cbdata); } =20 return 0; --=20 2.26.2