From nobody Sun Feb 8 22:29:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1748508347; cv=none; d=zohomail.com; s=zohoarc; b=cq3r3pbml6HTK/GzKZBCAmHrssysYlqNz1xf3zSRcRRorChYrYNs7PMviukJ58q9drC+bTiWJGK/M2EHvJ+QRTQlQeFRs5USv3hoM1WP8IDPT1/tvzg7h0oTsf7y7qne21yzjttCnkGpgiy5PUy/48FV/nNG3BmEh0VOOJWc0l4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748508347; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=33nwIiwfi1ziGn5x4ADWj0Kgdk9s++7x4elH0K+uhDw=; b=R5Bj/6UKK0y84xjBc8lLHJ0oUm4DHKNj6GAAlp3ku5GFilGTgoZNzoo2b9OsBgr/buMzA6DMJwuSKHQ0bKuCz7A7DCC0QuqdDb7CV2JHeJTxLGFHIzqV5Cue1zlaf9nPYtadWNvXhaq3aac0Oj/3rEe0gHSAafAkls0hGz2+g/4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1748508347060481.84655516688736; Thu, 29 May 2025 01:45:47 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id D92D11235; Thu, 29 May 2025 04:45:45 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id EE27E14C7; Thu, 29 May 2025 04:43:34 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 7714D1427; Thu, 29 May 2025 04:43:28 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 22ADC14B8 for ; Thu, 29 May 2025 04:43:16 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-A_4AM7xUM_GVPRFNdOzxvA-1; Thu, 29 May 2025 04:43:14 -0400 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2693E18004A7 for ; Thu, 29 May 2025 08:43:13 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.44.22.3]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3F45419560AF for ; Thu, 29 May 2025 08:43:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748508195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VNJpldCw2UH8NkF7G4e03g/7hQAahAEVoeYY7BowVyI=; b=OF0kJB0a2bg6qQPGiJbtnFkxM0jCtU+5oZtYopz2kMOXYEcZZxNOpSBoB7cjetG2Mc9FGR k2hpjRKlIWcW50I2f4bk7/lCdxw3dL1ts+wEv+FCax/F7meAWTiP+Dj6nVPCbaAPQOIn6c 2w+0hBpfK2OOEuurH2Jtq0y9rFz1LJ8= X-MC-Unique: A_4AM7xUM_GVPRFNdOzxvA-1 X-Mimecast-MFC-AGG-ID: A_4AM7xUM_GVPRFNdOzxvA_1748508193 To: devel@lists.libvirt.org Subject: [PATCH 01/15] qcow2GetExtensions: Add debug logs for interesting fields in qcow2 header extension parser Date: Thu, 29 May 2025 10:42:55 +0200 Message-ID: <87801ab0c65af3afed58ced87ff6c6ef7d8a4ffa.1748507931.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Ru50VzwFYf02X48hya4W8z43K9ufnZNTGPr4RQoste0_1748508193 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ZQF4JA7YZYXOXVBMR2KSDFWJ5W57AXZU X-Message-ID-Hash: ZQF4JA7YZYXOXVBMR2KSDFWJ5W57AXZU X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748508348183116600 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Add debug statements which were useful in figuring out bugs in the qcow2 extension parser. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/storage_file/storage_file_probe.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/storage_file/storage_file_probe.c b/src/storage_file/stora= ge_file_probe.c index f5c50d4597..04a2dcd9aa 100644 --- a/src/storage_file/storage_file_probe.c +++ b/src/storage_file/storage_file_probe.c @@ -442,6 +442,10 @@ qcow2GetExtensions(const char *buf, * is stored at QCOW2v3_HDR_SIZE */ extension_end =3D virReadBufInt64BE(buf + QCOWX_HDR_BACKING_FILE_OFFSE= T); + + VIR_DEBUG("extension_start:%zu, extension_end:%zu, buf_size:%zu", + extension_start, extension_end, buf_size); + if (extension_end > buf_size) return -1; @@ -461,6 +465,8 @@ qcow2GetExtensions(const char *buf, unsigned int magic =3D virReadBufInt32BE(buf + offset); unsigned int len =3D virReadBufInt32BE(buf + offset + 4); + VIR_DEBUG("offset:%zu, len:%u, magic:0x%x", offset, len, magic); + offset +=3D 8; if ((offset + len) < offset) --=20 2.49.0