From nobody Mon Sep 8 21:35:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747916419; cv=none; d=zohomail.com; s=zohoarc; b=QEaFYjgQCjezxThz+fOyNovF2YJYoYJ5YrmEFuwx1+te2jmYZO59Yr8ysrXQdSuuTAo4sIOqL3tYkY/SSCK+OShCRu5MQAssxeIOzOzj6IKgx4ZhcSUVXoqZUvMDF7QIdAOC3ughze2oL0sQWpRH6BbcUM5xgvmqZzhtCRiuq3E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747916419; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=qd78QMixK1P6f+9LdR6KYPcGA35rFCcoLnoyHZZxEgY=; b=Ci8FWNMQYbKMIN8oE/4GOkbXVYcbrOMhLhULpO6NDKgvm1hf01gvcRDIxJk0BtDei9mq7sW9kd8yUp7LMBR+JPvrQ0hyZiHvklrjlDQv4XJqRJxR9RZhie/0HHB6eU6+cMqDLbK5YZou3ysRe4dQ0dAhrkAOnRcNHywU2lmi7NQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747916419958618.8709968745736; Thu, 22 May 2025 05:20:19 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 054A614D0; Thu, 22 May 2025 08:20:18 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id E2DD914EE; Thu, 22 May 2025 08:20:03 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id F1C4414C3; Thu, 22 May 2025 08:19:59 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 5726C14B7 for ; Thu, 22 May 2025 08:19:59 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-550-6NnHEp6ONLSOxQqbjA08Zg-1; Thu, 22 May 2025 08:19:57 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1D55519560A1 for ; Thu, 22 May 2025 12:19:57 +0000 (UTC) Received: from orkuz (unknown [10.43.3.115]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9C8761944DFF for ; Thu, 22 May 2025 12:19:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747916399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DotU37aZOPr5dXfYgzkTTZVX0dkkhOUzg3LMWooKvTQ=; b=G5Qw/BhGarUO67VXBgbh8UaWnRK0OxIVUqHrYxdjwm5wo+RUMs0NJhNBg8A82mY76vEfjG uM962A/R9lAGjxEH4JFuangtpAfGfb0RZYE+ZGMsJCfEYXMBNrT91zQ6YALRfGIL9vhmM2 FmEKaO8xrpgpnC24QEGt++tl2EEOW+w= X-MC-Unique: 6NnHEp6ONLSOxQqbjA08Zg-1 X-Mimecast-MFC-AGG-ID: 6NnHEp6ONLSOxQqbjA08Zg_1747916397 To: devel@lists.libvirt.org Subject: [PATCH] virsh: Do not print warnings with "error:" prefix Date: Thu, 22 May 2025 14:19:51 +0200 Message-ID: <87626a16b38c9a057350c4c842948feb5ca1a4c2.1747916391.git.jdenemar@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BB1k_flCP4Rfyt8Fv6eEwFLUNWWKC4FMhH8zPnkShbk_1747916397 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7SKTBK6WXSK6ZL32HOBBBALSDJ6UZBSM X-Message-ID-Hash: 7SKTBK6WXSK6ZL32HOBBBALSDJ6UZBSM X-MailFrom: jdenemar@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Jiri Denemark via Devel Reply-To: Jiri Denemark X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747916553648116600 Content-Type: text/plain; charset="utf-8" From: Jiri Denemark Both vshWarn and vshError are just wrappers around vshPrintStderr which properly propagates the message level to the log, but fails to honor it when printing on stderr. https://issues.redhat.com/browse/RHEL-79460 Signed-off-by: Jiri Denemark Reviewed-by: J=C3=A1n Tomko --- tools/vsh.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/vsh.c b/tools/vsh.c index 05845e2c1e..e892cbca22 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -2123,7 +2123,11 @@ vshPrintStderr(vshControl *ctl, * printing to stderr will not interleave correctly with stdout * unless we flush between every transition between streams. */ fflush(stdout); - fprintf(stderr, _("error: %1$s\n"), NULLSTR(str)); + + if (level =3D=3D VSH_ERR_WARNING) + fprintf(stderr, _("warning: %1$s\n"), NULLSTR(str)); + else + fprintf(stderr, _("error: %1$s\n"), NULLSTR(str)); fflush(stderr); } =20 --=20 2.49.0