From nobody Sun Dec 14 06:20:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1750708978; cv=none; d=zohomail.com; s=zohoarc; b=ndkZrvFwxDCSnQi9HlgyZOu/4MVDAe8ojyJuxDsSGnNfAlB3kyjLDCD/5ZxLxFThCbhvNyXlMZ48U3jsrJ0p1VLd6e6lMw/HoHXELcwfhnAd+CDr25iJ91Iw6Ry56tZH8rxi7pgRtwdgd4LmO+nKxTg21F0YtfxrZqgIR/haH+g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750708978; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=Bz4z+PUN5WbamCP+b7DJJDpeCqtG3Y0znlDHYr/9w90=; b=mMprvZWJbK+XR97AvMbl4vIVzbhDhJVGCRNV00gs6kQh5J1dTt53aeQR03bXQzL3z5t2GPpncQzkoL3xcx6Ex2LyPswVYKDlnrnikwB1lDy5ORfgMtxa9cPj1UKLxBT9WVAiGCgAxUg9H+t5Sz6wkaVRBUFicMnAmP9E8XQqjn0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 175070897844719.308074880751633; Mon, 23 Jun 2025 13:02:58 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 7C048B65; Mon, 23 Jun 2025 16:02:57 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id A6ADE12AB; Mon, 23 Jun 2025 15:59:49 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 0485911D0; Mon, 23 Jun 2025 15:59:43 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id EECEF11C6 for ; Mon, 23 Jun 2025 15:59:29 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-213-m7gmm10YNUyIlU2kb9MBMQ-1; Mon, 23 Jun 2025 15:59:28 -0400 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7CEAE19560AD for ; Mon, 23 Jun 2025 19:59:27 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.5]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B63F819560A3 for ; Mon, 23 Jun 2025 19:59:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750708769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2UXSiA+JYvYR/OxuhP5GMAAkwAeFBMygDfMCmyy1MEU=; b=foH6TlBnYyde1uc4wKrLpUmHQe9xV60GJbJh27gNR+XVUn0iwMmMGB1V3yzq7hToQEMKjB LPIA6HASV4l0Syl7unmij51+I5IyEE2qJJ2f8gA6L3gr6eI5ZyMO4Ldvpu4+PP74OCdbU/ VGblV+woWofBf0NgkeDaugR/N+mPGuY= X-MC-Unique: m7gmm10YNUyIlU2kb9MBMQ-1 X-Mimecast-MFC-AGG-ID: m7gmm10YNUyIlU2kb9MBMQ_1750708767 To: devel@lists.libvirt.org Subject: [PATCH v2 05/13] qemuxmlconftest: Distribute testing of 'removable' disk property Date: Mon, 23 Jun 2025 21:59:10 +0200 Message-ID: <855d0b6e404d8e69a66b91f89df074b622effeb2.1750705681.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: O2j6MH5Foei-Ad6VhxOkaLujJ21vV27vtv9LGvcbkYc_1750708767 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BTL2YHTCO4B2AZHTORVXBSF3DPE75FM2 X-Message-ID-Hash: BTL2YHTCO4B2AZHTORVXBSF3DPE75FM2 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1750708979526116600 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The 'removable' property is tested for 'usb' and 'scsi' disks. The test case for 'usb' disks already has another test case for this, so add testing of 'removable' SCSI disks into the 'disk-scsi' case and remove the 'disk-device-removable' case completely. Signed-off-by: Peter Krempa Reviewed-by: Jiri Denemark --- .../disk-device-removable.x86_64-latest.args | 40 -------------- .../disk-device-removable.x86_64-latest.xml | 54 ------------------- .../qemuxmlconfdata/disk-device-removable.xml | 32 ----------- .../disk-scsi.x86_64-latest.args | 2 +- tests/qemuxmlconfdata/disk-scsi.xml | 2 +- tests/qemuxmlconftest.c | 1 - 6 files changed, 2 insertions(+), 129 deletions(-) delete mode 100644 tests/qemuxmlconfdata/disk-device-removable.x86_64-late= st.args delete mode 100644 tests/qemuxmlconfdata/disk-device-removable.x86_64-late= st.xml delete mode 100644 tests/qemuxmlconfdata/disk-device-removable.xml diff --git a/tests/qemuxmlconfdata/disk-device-removable.x86_64-latest.args= b/tests/qemuxmlconfdata/disk-device-removable.x86_64-latest.args deleted file mode 100644 index e0701f4bd2..0000000000 --- a/tests/qemuxmlconfdata/disk-device-removable.x86_64-latest.args +++ /dev/null @@ -1,40 +0,0 @@ -LC_ALL=3DC \ -PATH=3D/bin \ -HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGuest1 \ -USER=3Dtest \ -LOGNAME=3Dtest \ -XDG_DATA_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.local/share \ -XDG_CACHE_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.cache \ -XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -/usr/bin/qemu-system-x86_64 \ --name guest=3DQEMUGuest1,debug-threads=3Don \ --S \ --object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes"}' \ --machine pc,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Dpc.ram,acpi= =3Doff \ --accel tcg \ --cpu qemu64 \ --m size=3D219136k \ --object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}'= \ --overcommit mem-lock=3Doff \ --smp 1,sockets=3D1,cores=3D1,threads=3D1 \ --uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --display none \ --no-user-config \ --nodefaults \ --chardev socket,id=3Dcharmonitor,fd=3D1729,server=3Don,wait=3Doff \ --mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ --rtc base=3Dutc \ --no-shutdown \ --boot strict=3Don \ --device '{"driver":"piix3-usb-uhci","id":"usb","bus":"pci.0","addr":"0x1.0= x2"}' \ --device '{"driver":"virtio-scsi-pci","id":"scsi0","bus":"pci.0","addr":"0x= 2"}' \ --blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest1","no= de-name":"libvirt-3-storage","read-only":false}' \ --device '{"driver":"ide-hd","bus":"ide.0","unit":0,"drive":"libvirt-3-stor= age","id":"ide0-0-0","bootindex":1}' \ --blockdev '{"driver":"file","filename":"/tmp/usbdisk.img","node-name":"lib= virt-2-storage","read-only":false}' \ --device '{"driver":"usb-storage","bus":"usb.0","port":"1","drive":"libvirt= -2-storage","id":"usb-disk0","removable":true}' \ --blockdev '{"driver":"file","filename":"/tmp/scsidisk.img","node-name":"li= bvirt-1-storage","read-only":false}' \ --device '{"driver":"scsi-hd","bus":"scsi0.0","channel":0,"scsi-id":0,"lun"= :1,"device_id":"drive-scsi0-0-0-1","drive":"libvirt-1-storage","id":"scsi0-= 0-0-1","removable":true}' \ --audiodev '{"id":"audio1","driver":"none"}' \ --device '{"driver":"virtio-balloon-pci","id":"balloon0","bus":"pci.0","add= r":"0x3"}' \ --sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ --msg timestamp=3Don diff --git a/tests/qemuxmlconfdata/disk-device-removable.x86_64-latest.xml = b/tests/qemuxmlconfdata/disk-device-removable.x86_64-latest.xml deleted file mode 100644 index 2fd3284dee..0000000000 --- a/tests/qemuxmlconfdata/disk-device-removable.x86_64-latest.xml +++ /dev/null @@ -1,54 +0,0 @@ - - QEMUGuest1 - c7a5fdbd-edaf-9455-926a-d65c16db1809 - 219136 - 219136 - 1 - - hvm - - - - qemu64 - - - destroy - restart - destroy - - /usr/bin/qemu-system-x86_64 - - - - -
- - - - - - - - - - -
- - -
- - -
- - - -
- - - -