From nobody Sat Dec 21 15:00:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1726744456323228.59620955552305; Thu, 19 Sep 2024 04:14:16 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id E667D158F; Thu, 19 Sep 2024 07:14:14 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 62C10144B; Thu, 19 Sep 2024 07:14:00 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 70F2313F7; Thu, 19 Sep 2024 07:13:56 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C762F13F6 for ; Thu, 19 Sep 2024 07:13:55 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-321-GjX3OmFyOKCT0wq8H6gDSQ-1; Thu, 19 Sep 2024 07:13:54 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2C7B61944D45 for ; Thu, 19 Sep 2024 11:13:53 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4861219560AA for ; Thu, 19 Sep 2024 11:13:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726744435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cQdd9y3QrZCcpAxqwi35u/2yGpPvJjwpwknW8wD0+rg=; b=GNouNeut/flBIz3tL4UvetyU8J6+u3t6gXnW8nvZHJpw7ouAsF8rQgoOSUjLNaOsjyKD+r ObXT/tUy2w5z0d6BSx6FC7uRLZck6y7pwQTkhszwudpzT643edTUbcJ9gsErKZucI9xpa2 7VuQclGDHhrIFaJIcSF8wRsAmJrFR8Y= X-MC-Unique: GjX3OmFyOKCT0wq8H6gDSQ-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH (pushed)] qemuBuildChardevCommand: Remove unused variable Date: Thu, 19 Sep 2024 13:13:50 +0200 Message-ID: <852380cef559e9cf08b651d59767a282cc9f99f2.1726744397.git.pkrempa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BSAGF3ACGUOP7DJRBTMPXLD2ZXFH2SY5 X-Message-ID-Hash: BSAGF3ACGUOP7DJRBTMPXLD2ZXFH2SY5 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1726744458002116600 Content-Type: text/plain; charset="utf-8" 'charstr' is unused since 36d06a5637f, breaking the build on some platforms. Remove it. Fixes: 36d06a5637f Signed-off-by: Peter Krempa --- Build-breaker fix. src/qemu/qemu_command.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index c2d65645c4..c20d033aea 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1300,7 +1300,6 @@ qemuBuildChardevCommand(virCommand *cmd, virQEMUCaps *qemuCaps) { qemuDomainChrSourcePrivate *chrSourcePriv =3D QEMU_DOMAIN_CHR_SOURCE_P= RIVATE(dev); - g_autofree char *charstr =3D NULL; switch ((virDomainChrType) dev->type) { case VIR_DOMAIN_CHR_TYPE_TCP: --=20 2.46.0