From nobody Mon Feb 9 11:07:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578594120; cv=none; d=zohomail.com; s=zohoarc; b=WrTNLLu254lUzf0qnEpNh5T8pHy6d0gZ8jnV7/L95F0o5/ToTKiUzIsLJIgK0TpNOdpcXeg1rCojyV7Chf0qWp9HvRv/boQXflJYfu/Ulh6QWILROfIzx4YZAqXr8y+GwxEbKchkBprgvRD1GOZrneznCYOzn1s0U9ytb1lWQag= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578594120; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pPo6k5IqAWSIpYo1mKKfEBqj2qioqTVusaHsSXgN1Dk=; b=DSMw5IcEZ43SY2+/CmajeKv76WEViARkMW3loO8pwontXmd77bKKI+vNpZOg6U+L8vIJ0fOmOPHEZhm+U1CTMEk0Kiep30riRsNvcbIen6jdnHN+NwVlYZatdLSPRu58zYnC603aJ4PA7y965Rc+tBbd1dq3WGF05sd6Yqx1JZ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 157859412041034.35732701164284; Thu, 9 Jan 2020 10:22:00 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-237-v-s6SrjnM5utdpBDOy5C5w-1; Thu, 09 Jan 2020 13:21:57 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8ED701902ECF; Thu, 9 Jan 2020 18:21:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6C58C691AD; Thu, 9 Jan 2020 18:21:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2C727503C9; Thu, 9 Jan 2020 18:21:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 009ILar0018285 for ; Thu, 9 Jan 2020 13:21:36 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1F5A19A84; Thu, 9 Jan 2020 18:21:36 +0000 (UTC) Received: from angien.redhat.com (unknown [10.43.2.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7331A7C3D1; Thu, 9 Jan 2020 18:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578594119; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=pPo6k5IqAWSIpYo1mKKfEBqj2qioqTVusaHsSXgN1Dk=; b=Y/2RaBkKVO9VtcMHZa+gdmJa2QKQDjj4hEisMMUfwrZ6U3NZ//nFAYyCxfve5O9s6PQ6Sq vRs9ZSnh9Bh40Tc1NK2wkwC8wKhvc7R0kWG4Q1jVhChPca5OaNC+uu/fYPOnGc5nXSQivS WjXJBZPbSFZ7P4VGVxexu5xGOkUeuHk= From: Peter Krempa To: libvir-list@redhat.com Date: Thu, 9 Jan 2020 19:21:13 +0100 Message-Id: <851790a87dee8f5762a77af57140da21a25dbe9c.1578593859.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [RFC PATCH 07/16] qemu: domain: Remove unused qemuDomainDiskNodeFormatLookup X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: v-s6SrjnM5utdpBDOy5C5w-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The function has no users now and there's no need for it as the common pattern is to look up the whole disk object anyways. Signed-off-by: Peter Krempa Reviewed-by: Eric Blake --- src/qemu/qemu_domain.c | 14 -------------- src/qemu/qemu_domain.h | 3 --- 2 files changed, 17 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 24e84a5966..4966f5ef36 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -12048,20 +12048,6 @@ qemuDomainDiskChangeSupported(virDomainDiskDefPtr = disk, } -/* Return the format node name for a given disk of an online guest */ -const char * -qemuDomainDiskNodeFormatLookup(virDomainObjPtr vm, - const char *disk) -{ - size_t i; - - for (i =3D 0; i < vm->def->ndisks; i++) { - if (STREQ(vm->def->disks[i]->dst, disk)) - return vm->def->disks[i]->src->nodeformat; - } - return NULL; -} - bool qemuDomainDiskBlockJobIsActive(virDomainDiskDefPtr disk) { diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index c6afc484f6..4e2ddf6880 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -864,9 +864,6 @@ int qemuDomainDetermineDiskChain(virQEMUDriverPtr drive= r, bool qemuDomainDiskChangeSupported(virDomainDiskDefPtr disk, virDomainDiskDefPtr orig_disk); -const char *qemuDomainDiskNodeFormatLookup(virDomainObjPtr vm, - const char *disk); - void qemuDomainGetImageIds(virQEMUDriverConfigPtr cfg, virDomainObjPtr vm, virStorageSourcePtr src, --=20 2.24.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list