From nobody Sun Feb 8 16:33:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606317928; cv=none; d=zohomail.com; s=zohoarc; b=NFa1AmVaabklqTnikmtdZt6edx2AMHdz4goHHBy/5dPi7ZokvRCMKIgKSOO7BD4sN8oqR+vm4udFz8Le5FMQpBJmYnCjfDHqjDqHvWKDwChryqLImWeLs9Okd3tL641QuZ0rxbYqc6EMAn5jLCJOA0mpRt/hagGzrSukFOrtc/0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606317928; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3qq5wYi+g1OPeKCDrcPjUsrFS92h8sYhy/GKp6/d2cY=; b=Q4nKgDorNA6hGTKiAL8/i5QTpqZ6EvsC3Zp4Xc8TqwzLvjRTyDzgRBETremT7no5R4VXUYPHTz8RlPlT4sFiyY2dFXPNlJaNxiKxc2gaeNEV8O5HaLGarYLXQ3odBjuEGkkInU7GOikjzkUOltT4gbm3nlNocuf9olVY/Jtb9tw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1606317928529928.731616279824; Wed, 25 Nov 2020 07:25:28 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-370-hd1EPZmHMBmpZWSdBIgugQ-1; Wed, 25 Nov 2020 10:25:23 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0ECE61934103; Wed, 25 Nov 2020 15:25:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D32275C1B4; Wed, 25 Nov 2020 15:25:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A13C01809CA7; Wed, 25 Nov 2020 15:25:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0APEbo7V020385 for ; Wed, 25 Nov 2020 09:37:50 -0500 Received: by smtp.corp.redhat.com (Postfix) id 8CA805D71B; Wed, 25 Nov 2020 14:37:50 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.192.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id 092205D6AC for ; Wed, 25 Nov 2020 14:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606317926; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=3qq5wYi+g1OPeKCDrcPjUsrFS92h8sYhy/GKp6/d2cY=; b=ZyDdKjCCNKMdhvxLmScVjJZjtU+AfHneEsmijuEVcrvTisBvP6DhMh9ZR7il0Lq/X6c9/z JQDbWNRk0K/jUVxbg/mC/PELinZjr/kFrSZSnOCQMZTD93Fs8oag4C0fCd+tRQ7oc2hQ05 YRo3bU8179x1fQ2WaFtXXYfXoUYp4Nw= X-MC-Unique: hd1EPZmHMBmpZWSdBIgugQ-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 1/4] qemu: move cgroup cpu period and quota defines to vircgroup.h Date: Wed, 25 Nov 2020 15:37:41 +0100 Message-Id: <850c2c46674b6958e86d8390db89ce23c2341216.1606314162.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina --- src/qemu/qemu_driver.c | 21 ++++++++------------- src/util/vircgroup.h | 5 +++++ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 391596ba11..0e0a165e76 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -126,11 +126,6 @@ VIR_LOG_INIT("qemu.qemu_driver"); =20 #define QEMU_NB_NUMA_PARAM 2 =20 -#define QEMU_SCHED_MIN_PERIOD 1000LL -#define QEMU_SCHED_MAX_PERIOD 1000000LL -#define QEMU_SCHED_MIN_QUOTA 1000LL -#define QEMU_SCHED_MAX_QUOTA 18446744073709551LL - #define QEMU_GUEST_VCPU_MAX_ID 4096 =20 #define QEMU_NB_BLKIO_PARAM 6 @@ -9364,7 +9359,7 @@ qemuDomainSetSchedulerParametersFlags(virDomainPtr do= m, =20 } else if (STREQ(param->field, VIR_DOMAIN_SCHEDULER_VCPU_PERIOD)) { SCHED_RANGE_CHECK(value_ul, VIR_DOMAIN_SCHEDULER_VCPU_PERIOD, - QEMU_SCHED_MIN_PERIOD, QEMU_SCHED_MAX_PERIOD= ); + VIR_CGROUP_CPU_PERIOD_MIN, VIR_CGROUP_CPU_PE= RIOD_MAX); =20 if (def && value_ul) { if ((rc =3D qemuSetVcpusBWLive(vm, priv->cgroup, value_ul,= 0))) @@ -9384,7 +9379,7 @@ qemuDomainSetSchedulerParametersFlags(virDomainPtr do= m, =20 } else if (STREQ(param->field, VIR_DOMAIN_SCHEDULER_VCPU_QUOTA)) { SCHED_RANGE_CHECK(value_l, VIR_DOMAIN_SCHEDULER_VCPU_QUOTA, - QEMU_SCHED_MIN_QUOTA, QEMU_SCHED_MAX_QUOTA); + VIR_CGROUP_CPU_QUOTA_MIN, VIR_CGROUP_CPU_QUO= TA_MAX); =20 if (def && value_l) { if ((rc =3D qemuSetVcpusBWLive(vm, priv->cgroup, 0, value_= l))) @@ -9404,7 +9399,7 @@ qemuDomainSetSchedulerParametersFlags(virDomainPtr do= m, =20 } else if (STREQ(param->field, VIR_DOMAIN_SCHEDULER_GLOBAL_PERIOD)= ) { SCHED_RANGE_CHECK(value_ul, VIR_DOMAIN_SCHEDULER_GLOBAL_PERIOD, - QEMU_SCHED_MIN_PERIOD, QEMU_SCHED_MAX_PERIOD= ); + VIR_CGROUP_CPU_PERIOD_MIN, VIR_CGROUP_CPU_PE= RIOD_MAX); =20 if (def && value_ul) { if ((rc =3D qemuSetGlobalBWLive(priv->cgroup, value_ul, 0)= )) @@ -9424,7 +9419,7 @@ qemuDomainSetSchedulerParametersFlags(virDomainPtr do= m, =20 } else if (STREQ(param->field, VIR_DOMAIN_SCHEDULER_GLOBAL_QUOTA))= { SCHED_RANGE_CHECK(value_l, VIR_DOMAIN_SCHEDULER_GLOBAL_QUOTA, - QEMU_SCHED_MIN_QUOTA, QEMU_SCHED_MAX_QUOTA); + VIR_CGROUP_CPU_QUOTA_MIN, VIR_CGROUP_CPU_QUO= TA_MAX); =20 if (def && value_l) { if ((rc =3D qemuSetGlobalBWLive(priv->cgroup, 0, value_l))) @@ -9444,7 +9439,7 @@ qemuDomainSetSchedulerParametersFlags(virDomainPtr do= m, =20 } else if (STREQ(param->field, VIR_DOMAIN_SCHEDULER_EMULATOR_PERIO= D)) { SCHED_RANGE_CHECK(value_ul, VIR_DOMAIN_SCHEDULER_EMULATOR_PERI= OD, - QEMU_SCHED_MIN_PERIOD, QEMU_SCHED_MAX_PERIOD= ); + VIR_CGROUP_CPU_PERIOD_MIN, VIR_CGROUP_CPU_PE= RIOD_MAX); =20 if (def && value_ul) { if ((rc =3D qemuSetEmulatorBandwidthLive(priv->cgroup, @@ -9465,7 +9460,7 @@ qemuDomainSetSchedulerParametersFlags(virDomainPtr do= m, =20 } else if (STREQ(param->field, VIR_DOMAIN_SCHEDULER_EMULATOR_QUOTA= )) { SCHED_RANGE_CHECK(value_l, VIR_DOMAIN_SCHEDULER_EMULATOR_QUOTA, - QEMU_SCHED_MIN_QUOTA, QEMU_SCHED_MAX_QUOTA); + VIR_CGROUP_CPU_QUOTA_MIN, VIR_CGROUP_CPU_QUO= TA_MAX); =20 if (def && value_l) { if ((rc =3D qemuSetEmulatorBandwidthLive(priv->cgroup, @@ -9486,7 +9481,7 @@ qemuDomainSetSchedulerParametersFlags(virDomainPtr do= m, =20 } else if (STREQ(param->field, VIR_DOMAIN_SCHEDULER_IOTHREAD_PERIO= D)) { SCHED_RANGE_CHECK(value_ul, VIR_DOMAIN_SCHEDULER_IOTHREAD_PERI= OD, - QEMU_SCHED_MIN_PERIOD, QEMU_SCHED_MAX_PERIOD= ); + VIR_CGROUP_CPU_PERIOD_MIN, VIR_CGROUP_CPU_PE= RIOD_MAX); =20 if (def && value_ul) { if ((rc =3D qemuSetIOThreadsBWLive(vm, priv->cgroup, value= _ul, 0))) @@ -9506,7 +9501,7 @@ qemuDomainSetSchedulerParametersFlags(virDomainPtr do= m, =20 } else if (STREQ(param->field, VIR_DOMAIN_SCHEDULER_IOTHREAD_QUOTA= )) { SCHED_RANGE_CHECK(value_l, VIR_DOMAIN_SCHEDULER_IOTHREAD_QUOTA, - QEMU_SCHED_MIN_QUOTA, QEMU_SCHED_MAX_QUOTA); + VIR_CGROUP_CPU_QUOTA_MIN, VIR_CGROUP_CPU_QUO= TA_MAX); =20 if (def && value_l) { if ((rc =3D qemuSetIOThreadsBWLive(vm, priv->cgroup, 0, va= lue_l))) diff --git a/src/util/vircgroup.h b/src/util/vircgroup.h index f7eed983cc..2a9b341985 100644 --- a/src/util/vircgroup.h +++ b/src/util/vircgroup.h @@ -230,6 +230,11 @@ int virCgroupGetCpuShares(virCgroupPtr group, unsigned= long long *shares); int virCgroupSetupCpuShares(virCgroupPtr cgroup, unsigned long long shares, unsigned long long *realValue); =20 +#define VIR_CGROUP_CPU_PERIOD_MIN 1000LL +#define VIR_CGROUP_CPU_PERIOD_MAX 1000000LL +#define VIR_CGROUP_CPU_QUOTA_MIN 1000LL +#define VIR_CGROUP_CPU_QUOTA_MAX 18446744073709551LL + int virCgroupSetCpuCfsPeriod(virCgroupPtr group, unsigned long long cfs_pe= riod); int virCgroupGetCpuCfsPeriod(virCgroupPtr group, unsigned long long *cfs_p= eriod); int virCgroupGetCpuPeriodQuota(virCgroupPtr cgroup, unsigned long long *pe= riod, --=20 2.26.2