From nobody Mon Feb 9 11:38:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612186773; cv=none; d=zohomail.com; s=zohoarc; b=YLYvjUtHr7gvNZdfqyU2WmA243coRntDYksiiyTuoaCRKdYwbvvqRyExWhnEx14gT2LD9AWxOhI4DQTE50gV3dAjZJS4MhIZbZWGjfzm+/cd6MLB0pNw32s4DM4sO4P4XRf8bJIZZ7FQzGvWG/guP0c6oHPJoJ1QrzwgPor24js= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612186773; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zbBNbI//gQ4U+XFFjXGv7fw7L/MCkRAl1A4+Y1WW9mU=; b=SlrF4QSRD2xOJBu1uph0H9PZisGVy3h5lXOBMCh4p62Q+y9Z3PtmVeKr2LZUqfipbwaVT/OewfuL9cZiCroEoDpndbcU4wkQqFAWnpYGFcczVqr5kPu9lRuzs4pq9u1iUIDRzkhYiZCl6jIMoZ+7rHJ70ybKtXTYl2U3vnlfQo4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1612186773822886.1253350157031; Mon, 1 Feb 2021 05:39:33 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-537-APQUO4ZPPmSsnOV_Pz2MCg-1; Mon, 01 Feb 2021 08:39:30 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7C22FCC627; Mon, 1 Feb 2021 13:39:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 59D9A39A64; Mon, 1 Feb 2021 13:39:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 235A45003B; Mon, 1 Feb 2021 13:39:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 111DdFsi023376 for ; Mon, 1 Feb 2021 08:39:15 -0500 Received: by smtp.corp.redhat.com (Postfix) id 61F3960C68; Mon, 1 Feb 2021 13:39:15 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id B467D60C66 for ; Mon, 1 Feb 2021 13:39:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612186772; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zbBNbI//gQ4U+XFFjXGv7fw7L/MCkRAl1A4+Y1WW9mU=; b=few39oBFEijdFgRfhwCSgHlz0RTETOBDaWVzcSDSb6invRr9Xmwpy/rxRriqgzekHedb0Z gKe85Hs9ZFJPGY2+K/1MGdR1EBAHU95vlqd4UpqX4X0NXNIO6ugsMMT7TgTJGHcU+2QYpE mD2GU3iOjyZzxKoiagq8OAz8RgfLiB4= X-MC-Unique: APQUO4ZPPmSsnOV_Pz2MCg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 04/14] libxlMakeNetworkDiskSrc: Avoid use of VIR_DISPOSE_N Date: Mon, 1 Feb 2021 14:38:56 +0100 Message-Id: <84c9c83d91a0d51d3032beacf598c8423fb9c60f.1612186636.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Clear the secret right after use with memset. Signed-off-by: Peter Krempa --- src/libxl/libxl_conf.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index cb1fd7df7d..b2fcb21324 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -998,14 +998,15 @@ static int libxlMakeNetworkDiskSrc(virStorageSourcePtr src, char **srcstr) { virConnectPtr conn =3D NULL; - uint8_t *secret =3D NULL; VIR_AUTODISPOSE_STR base64secret =3D NULL; - size_t secretlen =3D 0; char *username =3D NULL; int ret =3D -1; *srcstr =3D NULL; if (src->auth && src->protocol =3D=3D VIR_STORAGE_NET_PROTOCOL_RBD) { + g_autofree uint8_t *secret =3D NULL; + size_t secretlen =3D 0; + username =3D src->auth->username; if (!(conn =3D virConnectOpen("xen:///system"))) goto cleanup; @@ -1017,6 +1018,7 @@ libxlMakeNetworkDiskSrc(virStorageSourcePtr src, char= **srcstr) /* RBD expects an encoded secret */ base64secret =3D g_base64_encode(secret, secretlen); + memset(secret, 0, secretlen); } if (!(*srcstr =3D libxlMakeNetworkDiskSrcStr(src, username, base64secr= et))) @@ -1025,7 +1027,6 @@ libxlMakeNetworkDiskSrc(virStorageSourcePtr src, char= **srcstr) ret =3D 0; cleanup: - VIR_DISPOSE_N(secret, secretlen); virObjectUnref(conn); return ret; } --=20 2.29.2