From nobody Tue Sep 9 03:19:48 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747323110; cv=none; d=zohomail.com; s=zohoarc; b=YnyizH12BHi16B0sWTQLeUShh2ELvXcxchhd5fYINYdCWr2Zgcdeb0niwGgJ4W0eLgWvgQNsiMusTsjOYeI6T4FCTN3Gr6FNScCcDF1EXc9A2jEpgZb/VASRutoNkuNRWtqIwXCgiwW9qJCRBqcYoQDI3qIxWWvYNPq7I+4ltx4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747323110; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=Q5tdZjVrNk7oErlxfwuT8WGEi7w23GI5Dvek/etv50g=; b=CcXjxpmP3MoCwuFOSNtZBwSFGriLYwX0Fu3+GExffH0X1qnMtWdR87JTPKwhZEJiN0xOosnnj+2b5yeUV2ToNRgKrh2+NkdD95tKDfrQzSU3n8JATESEGN1WEgntbOC6xsMrlFxHwQ2DuOzOHcw/qKIto/JmKXyVSTdDbUpvo6M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747323110364648.8004150485739; Thu, 15 May 2025 08:31:50 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 5C04E1411; Thu, 15 May 2025 11:31:49 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id D3C141326; Thu, 15 May 2025 11:29:42 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 23FE513F2; Thu, 15 May 2025 11:29:38 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8FEBC11B8 for ; Thu, 15 May 2025 11:29:22 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-HSxWifpiMKmm45zEexb4HQ-1; Thu, 15 May 2025 11:29:20 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B4EB0195608E for ; Thu, 15 May 2025 15:29:19 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.37]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B3C6E18001D8; Thu, 15 May 2025 15:29:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747322962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n4BwjgJB39jRSVy0RGpvtnuwRb9raXp2zeSbNSCh75s=; b=PkjEZgMNgzz7mwaa79BOPcw/eR3HSBDjleTYYHs6rv+qg8bK4sGIrZ2NyCMe3ZR9qrtM6U DJ52g0kKpq9f0oiB5O5fdQ205P3faod5SMMqZqoPscSw2fIsU1waHVTE3TQoROkM4Tde+G EI0Y7GKZbI6yo7Nb2SlQgEk2LA2Oyrk= X-MC-Unique: HSxWifpiMKmm45zEexb4HQ-1 X-Mimecast-MFC-AGG-ID: HSxWifpiMKmm45zEexb4HQ_1747322959 To: devel@lists.libvirt.org Subject: [PATCH 05/17] qemuBuildCommandLine: Drop 'snapshot' argument Date: Thu, 15 May 2025 17:28:50 +0200 Message-ID: <8495423f77c787e33cc8d76d8e6d7e4bcf66c0f6.1747322588.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -KiptWveCRYTCYSKRpeLzJoYbhz4x6Pe3AwZV7PQ8CY_1747322959 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: YIOVS5X43IZCSMRPD3TMOGPUW4JUTIZS X-Message-ID-Hash: YIOVS5X43IZCSMRPD3TMOGPUW4JUTIZS X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Peter Krempa X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747323112213116600 Content-Type: text/plain; charset="utf-8" From: Peter Krempa After recent refactors that removed legacy way to revert snapshots we no longer need to know the snapshot state during commandline build. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 5 ++--- src/qemu/qemu_command.h | 1 - src/qemu/qemu_process.c | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index bf03561fde..1ee4aa4829 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -10471,7 +10471,6 @@ qemuBuildCompatDeprecatedCommandLine(virCommand *cm= d, virCommand * qemuBuildCommandLine(virDomainObj *vm, const char *migrateURI, - virDomainMomentObj *snapshot, virNetDevVPortProfileOp vmop, size_t *nnicindexes, int **nicindexes) @@ -10485,8 +10484,8 @@ qemuBuildCommandLine(virDomainObj *vm, virDomainDef *def =3D vm->def; virQEMUCaps *qemuCaps =3D priv->qemuCaps; - VIR_DEBUG("Building qemu commandline for def=3D%s(%p) migrateURI=3D%s = snapshot=3D%p vmop=3D%d", - def->name, def, migrateURI, snapshot, vmop); + VIR_DEBUG("Building qemu commandline for def=3D%s(%p) migrateURI=3D%s = vmop=3D%d", + def->name, def, migrateURI, vmop); if (qemuBuildCommandLineValidate(driver, def) < 0) return NULL; diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h index a386c34f20..2d43cf5506 100644 --- a/src/qemu/qemu_command.h +++ b/src/qemu/qemu_command.h @@ -43,7 +43,6 @@ VIR_ENUM_DECL(qemuSoundCodec); virCommand * qemuBuildCommandLine(virDomainObj *vm, const char *migrateURI, - virDomainMomentObj *snapshot, virNetDevVPortProfileOp vmop, size_t *nnicindexes, int **nicindexes); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 5f2203dd13..46a33036b7 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8046,7 +8046,7 @@ qemuProcessLaunch(virConnectPtr conn, if (!(cmd =3D qemuBuildCommandLine(vm, incoming ? "defer" : NULL, - snapshot, vmop, + vmop, &nnicindexes, &nicindexes))) goto cleanup; @@ -8712,7 +8712,6 @@ qemuProcessCreatePretendCmdBuild(virDomainObj *vm, { return qemuBuildCommandLine(vm, migrateURI, - NULL, VIR_NETDEV_VPORT_PROFILE_OP_NO_OP, NULL, NULL); --=20 2.49.0