From nobody Sun Feb 8 22:08:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1688478039; cv=none; d=zohomail.com; s=zohoarc; b=UyGpzXwLEJUCz2xvsMzLZd+P52x8VcePT/SjjpumRfVZw9RIgzHz3jqK+LFenU5TtjWmeZEQD6ZYIlEXkh1aim8CypU+x7rF7fuAWuuV6TK22PUsQR7y4fbcaXTW5vxLoFQVXo4dsGWIGI+9VdAK0YHulwwBoK1JiZJhmPbDZ1o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1688478039; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=J4J6QpURZzjlhEvgI10mjndWWXv+dekkZ3VYod3knF0=; b=iLJUBb0cwzPIOUjRqARPmbKM9TxCDVtY/ihFraz3QL9vAUmGVQx1yCcCNAfEDsFkiQarx4ydCzg/9K+smlxjCLIlqkFvgMLFf1KEW1msUIR8PQ1D4aS5SGaTJU7IgCjOFP7RzNJLSY/Rf/NLHSTm5bmPhatv0okED8cI3Mqq8g4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1688478039589737.1769436590997; Tue, 4 Jul 2023 06:40:39 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-614-DWJfiSXuMUqISxtDBAYS-w-1; Tue, 04 Jul 2023 09:40:34 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BB6DD830DB5; Tue, 4 Jul 2023 13:40:30 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id A6685C1ED98; Tue, 4 Jul 2023 13:40:30 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 880291946589; Tue, 4 Jul 2023 13:40:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 4D2D61946588 for ; Tue, 4 Jul 2023 13:40:29 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 2E73C4021522; Tue, 4 Jul 2023 13:40:29 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id ADBA54021530 for ; Tue, 4 Jul 2023 13:40:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688478038; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=J4J6QpURZzjlhEvgI10mjndWWXv+dekkZ3VYod3knF0=; b=T/Dk/BXs3A61RvFGgX+R9Pq43vYw3ta7jwEnXnHd+xDJtiqMwOTWIY/wh1HP1Z132STdS3 WG+Rvo2linsjEX0T0S034p0no5Hb71ynYbA2ln1tIuPra79usgwfJEfujvwhTxwFBVVbH4 b7zkRszPVTfN/ACaUv+1slXIcX0yJ/4= X-MC-Unique: DWJfiSXuMUqISxtDBAYS-w-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 10/10] qemuTestDriverInit: Don't autopopulate qemu capabilities when initializing driver Date: Tue, 4 Jul 2023 15:40:19 +0200 Message-ID: <84860771b43b10127d3b9eaab76fb3f8ca2e1908.1688477951.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1688478040553100001 Content-Type: text/plain; charset="utf-8" In an effort to use strictly real capability testing all tests were converted to do insertion of their own capabilities when required, thus we don't need to popluate the capabilities. This will also promote using proper capabilities based on what the test is trying to achieve. Signed-off-by: Peter Krempa --- tests/testutilsqemu.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index e0b58b1d5d..16b773a768 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -428,7 +428,6 @@ int qemuTestDriverInit(virQEMUDriver *driver) virSecurityManager *mgr =3D NULL; char statedir[] =3D STATEDIRTEMPLATE; char configdir[] =3D CONFIGDIRTEMPLATE; - g_autoptr(virQEMUCaps) emptyCaps =3D NULL; memset(driver, 0, sizeof(*driver)); @@ -499,11 +498,6 @@ int qemuTestDriverInit(virQEMUDriver *driver) if (!driver->xmlopt) goto error; - /* Populate the capabilities cache with fake empty caps */ - emptyCaps =3D virQEMUCapsNew(); - if (qemuTestCapsCacheInsert(driver->qemuCapsCache, emptyCaps) < 0) - goto error; - if (!(mgr =3D virSecurityManagerNew("none", "qemu", VIR_SECURITY_MANAGER_PRIVILEGED))) goto error; --=20 2.41.0