From nobody Mon Feb 2 07:30:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1769611247; cv=none; d=zohomail.com; s=zohoarc; b=JLqCnXFitNVnGOSoFyf/1tki5VzpzNK3vbZ/Z2TtI2LIcq8eBpEWy1xFitWeZ5PMxeCMeWwV4dijwSRpz9SFbw4CEhx8JhIFq1+QkGJWOWliWMd60w/c39ybiBcJl8Uc+mBXQEvCSWOxv/GqRYwecfacmNFwmqXsbXSUMZL7a+I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769611247; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=nfVhtsZlaFJttYmzE8flY8f0DD8fT1Z/plPdoPqhuMs=; b=M3MkoEg2ofPBOFoUdxTua1xkPFPcUIo3YJRveXKUBXsl2StJiux2cLW3UrdL5aE+k7Iv+lMiDZBuW/HI1h3o+t1b1kKbeKcUk2evCb5D4jcfU0oEcoZBz35PZteL42Xu/jLVOpSd89cp6cP40IqTTox7OjFZdlE+EJollb6iOvg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1769611247368259.15789418211034; Wed, 28 Jan 2026 06:40:47 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id CBE5E43EC7; Wed, 28 Jan 2026 09:40:46 -0500 (EST) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 7630A43FAF; Wed, 28 Jan 2026 09:31:22 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 6A15041A3C; Wed, 28 Jan 2026 09:31:18 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 96038419B0 for ; Wed, 28 Jan 2026 09:30:56 -0500 (EST) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-481-s_T18w_yMp2768quXpIrww-1; Wed, 28 Jan 2026 09:30:54 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E60FF19775AE for ; Wed, 28 Jan 2026 14:30:53 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5018E195419A for ; Wed, 28 Jan 2026 14:30:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769610656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nfVhtsZlaFJttYmzE8flY8f0DD8fT1Z/plPdoPqhuMs=; b=AlONG3uVm0WkehZ2A0Irv3DIkBTCF/+NtApkzHFut9srrBbcSvdON2WrZaETdBLO24lx0b 9sUXYPtrl0HFKLZ3glcmLgOk/B+KclPrUMY91zD3dOcX940h6ZxOT64T51Mv8b3WW3RYIH 68AVnnfW9hjxbbIX57jwdSGdobkmasU= X-MC-Unique: s_T18w_yMp2768quXpIrww-1 X-Mimecast-MFC-AGG-ID: s_T18w_yMp2768quXpIrww_1769610654 To: devel@lists.libvirt.org Subject: [PATCH 07/20] network: Introduce networkValidateTests() Date: Wed, 28 Jan 2026 15:30:28 +0100 Message-ID: <847060c002724f5ceb4d05c13045c7eb0fed60dc.1769610369.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7gcl5dIFQjH76CWg44utpEOp_sVhnKtAx6VR15vkCiE_1769610654 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: G2ESBUQX5C7B7QKPXVXMWQE4WJQLA2GP X-Message-ID-Hash: G2ESBUQX5C7B7QKPXVXMWQE4WJQLA2GP X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1769611250401154100 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik The aim of this internal API is to wrap networkValidate() and it is meant to be called from our tests. Signed-off-by: Michal Privoznik --- src/network/bridge_driver.c | 22 +++++++++++++++++++++- src/network/bridge_driver_priv.h | 3 +++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index e7a4e5e1b7..9636984390 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -2827,6 +2827,17 @@ networkBridgeNameValidate(virNetworkObjList *nets, } =20 =20 +/** + * networkValidate: + * @driver: network driver + * @def: network definition + * + * Validates network definition and fills up blanks. + * Callers, but tests, must provide valid @driver to ensure + * unique bridge name. + * + * Returns: 0 on success, -1 otherwise (with error reported). + */ static int networkValidate(virNetworkDriverState *driver, virNetworkDef *def) @@ -2852,8 +2863,10 @@ networkValidate(virNetworkDriverState *driver, case VIR_NETWORK_FORWARD_OPEN: /* if no bridge name was given in the config, find a name * unused by any other libvirt networks and assign it. + * All callers MUST provide valid @driver, except for tests. */ - if (networkBridgeNameValidate(driver->networks, def) < 0) + if (driver && + networkBridgeNameValidate(driver->networks, def) < 0) return -1; =20 virNetworkSetBridgeMacAddr(def); @@ -3104,6 +3117,13 @@ networkValidate(virNetworkDriverState *driver, } =20 =20 +int +networkValidateTests(virNetworkDef *def) +{ + return networkValidate(NULL, def); +} + + static virNetworkPtr networkCreateXMLFlags(virConnectPtr conn, const char *xml, diff --git a/src/network/bridge_driver_priv.h b/src/network/bridge_driver_p= riv.h index c7d1d8268d..0fdb1d715e 100644 --- a/src/network/bridge_driver_priv.h +++ b/src/network/bridge_driver_priv.h @@ -26,3 +26,6 @@ networkDnsmasqConfContents(virNetworkObj *obj, =20 bool networkNeedsDnsmasq(const virNetworkDef* def); + +int +networkValidateTests(virNetworkDef *def); --=20 2.52.0