From nobody Sun Feb 8 23:26:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1648823926; cv=none; d=zohomail.com; s=zohoarc; b=WQ7wyq7ma4mx88vq5GkzeNb20gnklcvmYi2oKVqVHaBG9r65QS5u1O2Jb6Fd3eZ7JvODbaJwoH3hkJshjMqgAmSV9ElyQrrYGgrn4LnFf5Uib6+fspKoCm5fhreN0lifC5ShRLD7lvYlTopxfqTqdRIDfvLLFz3E4yUS6tObXB0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1648823926; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xlkSuI6CPeW7pMNAk8DoFlimFwfuN5fCs7q4rZW6oS4=; b=FuIQWHxYAFfh2XlLE2BiH46OeEbtMX9pb3hDnwd/1SxXH7VxI6c7wXXDE4I3rBqsGzcim/0soAHavz0hEBUUNZr9Nrr9lWPHeahw/Y5oM0J6lM+11FkRS4khNdsEJjBekrw6mXHA3rPlTyLKQZXDit8/uZzsiGLLqCIpHoFcUz0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1648823926679917.1477278151332; Fri, 1 Apr 2022 07:38:46 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-629-i6Zg0JMgNGmh1B-n-Qp7eQ-1; Fri, 01 Apr 2022 10:38:43 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 753E5100BAA4; Fri, 1 Apr 2022 14:38:41 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5FE7A400E553; Fri, 1 Apr 2022 14:38:41 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 24629194035B; Fri, 1 Apr 2022 14:38:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1F4F21940359 for ; Fri, 1 Apr 2022 14:38:39 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 13E0E40BAEE; Fri, 1 Apr 2022 14:38:39 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.180]) by smtp.corp.redhat.com (Postfix) with ESMTP id AFA49403372 for ; Fri, 1 Apr 2022 14:38:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648823925; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=xlkSuI6CPeW7pMNAk8DoFlimFwfuN5fCs7q4rZW6oS4=; b=CDG5gjFelCLapDE2Jl/1sHgI/ulYMkER9Lem1985t4xqKd8yhcNqd+KrSg450G4nUrqPXM O3no6BdisBSAcqZ6ShFxiaqHl51Qc/eIrU2hh2NAt/c7Bn1uHG5n/QmU30CR/6d+G1FrOw uIas2ogvY2ysm0IZmeHlLQLu9wLliNs= X-MC-Unique: i6Zg0JMgNGmh1B-n-Qp7eQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 3/4] ch: Explicitly forbid live changing nodeset for strict numatune Date: Fri, 1 Apr 2022 16:38:34 +0200 Message-Id: <83c4ede9d23b69169d81332debf39f27ba61fee8.1648823888.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1648823927994100002 Content-Type: text/plain; charset="utf-8"; x-default="true" This is similar to v7.10.0-354-g06f405c627 except this time it fixes CH driver. With strict numatune we can't guarantee that all memory is moved to new location. Therefore, let's forbid moving memory in that case. However, allow it for restrictive mode, which is documented to be best effort. Signed-off-by: Michal Privoznik --- src/ch/ch_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index 2fe7aba9d0..34ce0c1a0c 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -1519,7 +1519,7 @@ chDomainSetNumaParamsLive(virDomainObj *vm, size_t i =3D 0; =20 if (virDomainNumatuneGetMode(vm->def->numa, -1, &mode) =3D=3D 0 && - mode !=3D VIR_DOMAIN_NUMATUNE_MEM_STRICT) { + mode !=3D VIR_DOMAIN_NUMATUNE_MEM_RESTRICTIVE) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("change of nodeset for running domain requires st= rict numa mode")); return -1; --=20 2.35.1