From nobody Sat Feb 7 05:52:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620315100; cv=none; d=zohomail.com; s=zohoarc; b=nowovYT2jYSROSsGQW59C33SHnEcZb8fP1KUz+M+ukgEEs5zsTSadFpUJ3NgiuyUA81iJ9XN30bCfX+WX6WvuE/JMg3fe1NtoQR8NezC27z+8J7f5LPFZQ3hxVVxsWCf9h4KxUyX5PdoSZfm+2ezTv+qsYgPLPWCaLThDHZrFRs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620315100; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oVLFHgzDLtEd/Wh0/bT1WT4J5RRvXflFZ5JEFrWC7y4=; b=Y7yVQZyHsE5Jqf9m+gkILxMJWydUrRiyzeKEHoBGZHDnwRbPVWISla3FffgRLhF28KEmZ1iQojr+lcSx972lGj/lOB7+4vTFsY59hTwQuvn3LwKVUjToWFivgQS8ib6s+3JSZPdy7EO4iHnZdUMQAo4zliFNpLjhcKbEEeiMKxA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 162031510096538.5665055308458; Thu, 6 May 2021 08:31:40 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-429-Q-S69n_dMEivgSpbKrO2WA-1; Thu, 06 May 2021 11:31:35 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E9FB593A807; Thu, 6 May 2021 15:31:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CC5D11349A; Thu, 6 May 2021 15:31:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9A4EE180B651; Thu, 6 May 2021 15:31:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 146FVKbE011409 for ; Thu, 6 May 2021 11:31:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id 959D11059582; Thu, 6 May 2021 15:31:20 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id EDC261002EF0 for ; Thu, 6 May 2021 15:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620315098; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=oVLFHgzDLtEd/Wh0/bT1WT4J5RRvXflFZ5JEFrWC7y4=; b=CWAJmtAlFWb4wRTSfoIKxoFO6njMCadUUbL3F2fitvMl1GmMkFahYg+y7OGKt76nWnVGcB KMmkM34BPgFH/9DRwbQ/q9kn1yBbnjrl57PFwTcSf41ipWCp5HqhLtwn1mT8Vvc2Jxepsr 52uhDpNKmnjWRnuo3FKdOPVX7Fx//aM= X-MC-Unique: Q-S69n_dMEivgSpbKrO2WA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 09/17] virDomainBackupDiskDefParseXML: Fill default backup state after parsing it Date: Thu, 6 May 2021 17:31:01 +0200 Message-Id: <83ae551b93d289c05ae48805f6304180741a71c9.1620314826.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Set the backup mode to VIR_TRISTATE_BOOL_YES after virXMLPropTristateBool left it set to VIR_TRISTATE_BOOL_ABSENT. This will allow fixing virXMLPropTristateBool to always initialize @result. Signed-off-by: Peter Krempa --- src/conf/backup_conf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/conf/backup_conf.c b/src/conf/backup_conf.c index 7f176b783f..ac92bd4f26 100644 --- a/src/conf/backup_conf.c +++ b/src/conf/backup_conf.c @@ -121,12 +121,13 @@ virDomainBackupDiskDefParseXML(xmlNodePtr node, return -1; } - def->backup =3D VIR_TRISTATE_BOOL_YES; - if (virXMLPropTristateBool(node, "backup", VIR_XML_PROP_NONE, &def->backup) < 0) return -1; + if (def->backup =3D=3D VIR_TRISTATE_BOOL_ABSENT) + def->backup =3D VIR_TRISTATE_BOOL_YES; + /* don't parse anything else if backup is disabled */ if (def->backup =3D=3D VIR_TRISTATE_BOOL_NO) return 0; --=20 2.30.2