From nobody Sun Feb 8 22:43:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1687849041; cv=none; d=zohomail.com; s=zohoarc; b=MOjMot7G6Tkm7l7yGOlkuUWcQdTHGmzBn8XQxNCY9np+0lT/x8zPvVHyAQNhqPmcgvhwssiB5qIKCht1jwEJUBam3eaLgvyqAPUMFKtVJSwGnvihjZ0dya7sfXD+/m+KSFA4e+Rgoc7nVwZxvllorsl8z3UTkhIzQeZLoz4xSUE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1687849041; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=/EaAKMf2r9ZY/0hM31S1+OVaI+P8nfe8XE1TlR7oOBY=; b=bSqb9kCRL9fwJObO+uXdDsin+oeurzOJqSdq055+WPP7aRAH0Z4vAJYNTBpv9hgdtl/4u/abUBRsMDAsd2e4ovmLA4LlNX0b2+fL/SSi4qRMaMWQya6qxLWoNhh1SMa1visHDunhU1JnI+WP94AN1vKGU9wdYyiTlS2qWEXkHCM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1687849041015590.9984040404715; Mon, 26 Jun 2023 23:57:21 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-363-JLpdoviwO5Wj4uBy68MHbw-1; Tue, 27 Jun 2023 02:57:16 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E8F538631DB; Tue, 27 Jun 2023 06:57:13 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 29690111F3B0; Tue, 27 Jun 2023 06:57:11 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D7F051946587; Tue, 27 Jun 2023 06:57:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 411811946586 for ; Tue, 27 Jun 2023 06:57:04 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 2C3FE515541; Tue, 27 Jun 2023 06:57:04 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id C7B4D48FB01 for ; Tue, 27 Jun 2023 06:57:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687849039; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/EaAKMf2r9ZY/0hM31S1+OVaI+P8nfe8XE1TlR7oOBY=; b=FHXvZ6eluNxIdJKmNqjJgeOQT6RCNI1rqm/OMpeiG3S9IWpgpFpylgxoa3ig3kI1ttLiIQ gOVuPDFGv+z3bNL/apVBcsY6LR7HnU9cCjBZp5PHvui8eIs542OsJGN+1/99cpMaVrRGL+ qobLMUbe+uwOA9lT8KinsU5V7e8pJ9M= X-MC-Unique: JLpdoviwO5Wj4uBy68MHbw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] qemu_passt: Actually use @logfd Date: Tue, 27 Jun 2023 08:57:03 +0200 Message-Id: <83686f1eea1a001a37a92f2c054ffb2689c43a40.1687849013.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1687849042209100001 Content-Type: text/plain; charset="utf-8"; x-default="true" In one of my previous commits I've introduced @logfd variable that was supposed to hold FD of passt logfile. But I've forgot to assign the qemuDomainOpenFile() retval to it. Fixes: 8511b96a319836700b4829816cdae27c3630060d Signed-off-by: Michal Privoznik --- Pushed as trivial. src/qemu/qemu_passt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_passt.c b/src/qemu/qemu_passt.c index 25b22d8ad9..3679bf75fc 100644 --- a/src/qemu/qemu_passt.c +++ b/src/qemu/qemu_passt.c @@ -204,9 +204,9 @@ qemuPasstStart(virDomainObj *vm, /* The logFile location is not restricted to a per-domain director= y. It * can be anywhere. Pre-create it as passt may not have enough per= ms to * do so. */ - if (qemuDomainOpenFile(cfg, vm->def, net->backend.logFile, - O_CREAT | O_TRUNC | O_APPEND | O_RDWR, - &needUnlink) < 0) { + if ((logfd =3D qemuDomainOpenFile(cfg, vm->def, net->backend.logFi= le, + O_CREAT | O_TRUNC | O_APPEND | O_R= DWR, + &needUnlink)) < 0) { return -1; } =20 --=20 2.39.3