From nobody Mon Apr 29 03:09:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1588682410; cv=none; d=zohomail.com; s=zohoarc; b=GhkjrctQeM8PQSV28lvbp29v/33OGE0NM0Wd2GKp2dmp/yFLuZP0KheiT7RlkJCBUcDafB6BqzvYXFTusVsAAEZl0Q2ZOYTzAPUb/uQBHmYJSlgCMH80BToKQgW6rPOnMagCK9k0DA29h2jLv6hAw0H9c2+KGgkQkHX0s4fLrAg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588682410; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=k0jBmNcawbHHRLCPqSQ0cfHsyBqr0S0iCMMQKJ0gcNs=; b=BDKDbt+K/W32/vxblotwfPH1xEXyzHLhDCCPRxKzX6MoIUetsXI2twvCQzCLDsV1fyrD57rKOgIJ3mgOBVdfBLxVb51803ptRv4dzWBqhyImTbSGthlLr9U0eAUmG8CMAjuO4JQxm9KOpX1E4U3SxwKNFYee0Hk8IUC2bAp2u10= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1588682410495734.9695582803545; Tue, 5 May 2020 05:40:10 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-9RStWUJsNh6iwHbCG147dA-1; Tue, 05 May 2020 08:40:06 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5DD55801504; Tue, 5 May 2020 12:40:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A404B5D9D5; Tue, 5 May 2020 12:39:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 341CD4CAA0; Tue, 5 May 2020 12:39:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 045CdAZB013161 for ; Tue, 5 May 2020 08:39:10 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1063E7052E; Tue, 5 May 2020 12:39:10 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.193.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 561EE70542; Tue, 5 May 2020 12:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588682409; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=k0jBmNcawbHHRLCPqSQ0cfHsyBqr0S0iCMMQKJ0gcNs=; b=DNH7iSk9ewTXPbBDBDaa//ExvDDmVXZcbKEFrfCBjXs54qr7HCU/VYtU4zhSASXRe8LAtk 2V3hFWQBgtTNCbjoHftLSsqSt8ipFZqWfsLCfvQWg+Z0ag8SsldmpAQEyJYkaa77peEjcc n5lDjPhgM16Ek3HeVmSxGNdAdK5Y1Vw= X-MC-Unique: 9RStWUJsNh6iwHbCG147dA-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] virt-host-validate-bhyve.c: Reintroduce @ret to virHostValidateBhyve() Date: Tue, 5 May 2020 14:39:00 +0200 Message-Id: <8366030afcbf7d954f384c23630f3ef7c51c4f37.1588682331.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" This partially reverts fe65e9c8b50c9029cba0e8c386162d293cd443d2. In the referenced commit I removed @ret from virHostValidateBhyve() thinking it wasn't used when in fact it is - it's usage is hidden under MODULE_STATUS_WARN(). Reintroduce the variable back. Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 --- tools/virt-host-validate-bhyve.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/virt-host-validate-bhyve.c b/tools/virt-host-validate-bh= yve.c index 3e8cc59a38..2f0ec1e36c 100644 --- a/tools/virt-host-validate-bhyve.c +++ b/tools/virt-host-validate-bhyve.c @@ -47,6 +47,7 @@ =20 int virHostValidateBhyve(void) { + int ret =3D 0; int fileid =3D 0; struct kld_file_stat stat; bool vmm_loaded =3D false, if_tap_loaded =3D false; @@ -72,5 +73,5 @@ int virHostValidateBhyve(void) MODULE_STATUS_WARN(if_bridge, "bridged networking will not work"); MODULE_STATUS_WARN(nmdm, "nmdm console will not work"); =20 - return 0; + return ret; } --=20 2.26.2