From nobody Mon Feb 9 02:47:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1725893344137990.1397082923322; Mon, 9 Sep 2024 07:49:04 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id DB9CE1806; Mon, 9 Sep 2024 10:49:02 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 441D4199F; Mon, 9 Sep 2024 10:46:46 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 099F7191E; Mon, 9 Sep 2024 10:46:38 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C63CF1931 for ; Mon, 9 Sep 2024 10:46:26 -0400 (EDT) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-4upFFE7PNGmTYD3UZx14mA-1; Mon, 09 Sep 2024 10:46:25 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4D34B1955DC3 for ; Mon, 9 Sep 2024 14:46:24 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.7]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 759A21956086 for ; Mon, 9 Sep 2024 14:46:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725893186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=337V5Pi519r+Aob2dHQqmXh+Hu5FeW/OjtAhe2qUiCY=; b=cb8oiOMlEf49eX8YqJSc3TIerZNAXF9v88V2/b3wSowRmYGwkYUAm8UIdA1ML7y/uEEJPL n9+G4J/W5NyFUq5FMFQwoufpjTNRoyKo//me2c/+HqwT6Ul9IgNyMZ8tHMs4B9nl6vj4bj 7d8G3/3blIQRmqDywEM0lCWanD16Tt0= X-MC-Unique: 4upFFE7PNGmTYD3UZx14mA-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 8/9] virDiskNameParse: Fix integer overflow in disk name parsing Date: Mon, 9 Sep 2024 16:46:09 +0200 Message-ID: <8334351171790e63d6b62ef559fc99106e7a5cea.1725893134.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 5NILUAAF4FC4AN6PMDRHAB33F6KOIK22 X-Message-ID-Hash: 5NILUAAF4FC4AN6PMDRHAB33F6KOIK22 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1725893344855116600 Content-Type: text/plain; charset="utf-8" The conversion to index entails multiplication and accumulation by user provided data which can easily overflow use VIR_MULTIPLY_ADD_IS_OVERFLOW to check if the string is valid. Closes: https://gitlab.com/libvirt/libvirt/-/issues/674 Signed-off-by: Peter Krempa --- src/util/virutil.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/util/virutil.c b/src/util/virutil.c index dc5009f11d..6c89a48e51 100644 --- a/src/util/virutil.c +++ b/src/util/virutil.c @@ -338,11 +338,17 @@ int virDiskNameParse(const char *name, int *disk, int= *partition) return -1; for (i =3D 0; *ptr; i++) { + int c =3D *ptr - 'a'; + if (!g_ascii_islower(*ptr)) break; - idx =3D (idx + (i < 1 ? 0 : 1)) * 26; - idx +=3D *ptr - 'a'; + idx =3D (idx + (i < 1 ? 0 : 1)); + + if (VIR_MULTIPLY_ADD_IS_OVERFLOW(INT_MAX, idx, 26, c)) + return -1; + + idx =3D idx * 26 + c; ptr++; } --=20 2.46.0