From nobody Mon Sep 8 20:03:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1740406952496107.02584685669865; Mon, 24 Feb 2025 06:22:32 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 4E4E31AD7; Mon, 24 Feb 2025 09:22:31 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 89B461BA3; Mon, 24 Feb 2025 09:22:16 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 2CA6B1758; Mon, 24 Feb 2025 09:22:14 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 814ED174A for ; Mon, 24 Feb 2025 09:22:13 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-359-4V1i2rORPBqhK9HYQgDhbA-1; Mon, 24 Feb 2025 09:22:11 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9D6DE19783B2 for ; Mon, 24 Feb 2025 14:22:10 +0000 (UTC) Received: from orkuz (unknown [10.43.3.115]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 29ED61800358 for ; Mon, 24 Feb 2025 14:22:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740406933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qANTHJdna/2Lp3O6rf62LH3pPRgAJLW/MYNhKzqof8k=; b=KRZAW51v7NqEbKfao3cTUHgaXCA6smiZBV3db8sEZCOzG39SMs+yKJisQXNjbDhldq3hmW /EvbJS7yr3Ut7o1GsK/s0TpnE6F3+2hi7n9W5gQa8dUPbmZijpPZOzOVHijrSUsGwKYZXQ YfAf2xy0+xVfH3sKXmjbpXA9YLsBThQ= X-MC-Unique: 4V1i2rORPBqhK9HYQgDhbA-1 X-Mimecast-MFC-AGG-ID: 4V1i2rORPBqhK9HYQgDhbA_1740406930 From: Jiri Denemark To: devel@lists.libvirt.org Subject: [PATCH] cpu: Do not call g_strv_contains on NULL list Date: Mon, 24 Feb 2025 15:22:07 +0100 Message-ID: <82ab7b16b162bc0a751ebcb7325ca6ea9d7cfec1.1740406927.git.jdenemar@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: l8VEVeDurgUAq5uf9TNCjul23jKuGkmRXdJsUgWVN7w_1740406930 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: LZDW6Y5CM5JYZMFWNJWV53LKGXUB7PX4 X-Message-ID-Hash: LZDW6Y5CM5JYZMFWNJWV53LKGXUB7PX4 X-MailFrom: jdenemar@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1740406956110019100 Content-Type: text/plain; charset="utf-8" When virCPUx86UpdateLive checks whether a feature was added to a CPU model after the model was already released (vmx-* features in most Intel models), the following assert could be logged by glib: g_strv_contains: assertion 'strv !=3D NULL' failed While most of our CPU models have a non-empty list of added feature, new models added in 2024 and versioned variants of older models have addedFeatures =3D=3D NULL. Fixes: e622970c8785ec1f7e142d72f792d89f870e07d0 Signed-off-by: Jiri Denemark Reviewed-by: Michal Privoznik --- src/cpu/cpu_x86.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 67c88ae3b7..32aa01bc14 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -3212,6 +3212,7 @@ virCPUx86UpdateLive(virCPUDef *cpu, * behaved before the features were added. */ if (!explicit && + model->addedFeatures && g_strv_contains((const char **) model->addedFeatures, feature-= >name)) ignore =3D true; =20 --=20 2.48.1