From nobody Thu Dec 18 08:09:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1574261338; cv=none; d=zoho.com; s=zohoarc; b=mzxEWMsWYfMfgSwRA4I8OUO5bCX/uxxAa9qZpCiXczEzU20972sladagZx2PvIgIj0iUoVKs/Ub4gRle4tE0etVMU0xz0ssLp7v+6/+4IYYKdyvKRsAezUDIx3f05cFq7Lu9DaC9K+hiI+hlUUf55nVkamBPtQpayOsJ93AYIAY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1574261338; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zNZkl635e4Pa/x72eSkKhgNORs/G9h+gIvXI19vbDwk=; b=CPDzj907bBdYaasxH90dNn0x07FsuKkuDDjwjAweDOD0Jk/+64bX577CyduORoftaSbVy2dTOxTu1UGx+OQGyFHd3S64XTy2H3d0Yj3+6/WyFa2l4QxWzrLf9jiPIjOnJt/wvEkV76nTyyUnHUQVAVJD0AHkilHL8mndmfAYQOI= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1574261338543594.0358295065578; Wed, 20 Nov 2019 06:48:58 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-159-VPZpl_aSM72nP16uo-nc1w-1; Wed, 20 Nov 2019 09:48:55 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 716668026BB; Wed, 20 Nov 2019 14:48:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 381FD1037ACE; Wed, 20 Nov 2019 14:48:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EB6E81808878; Wed, 20 Nov 2019 14:48:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xAKEmfsS004853 for ; Wed, 20 Nov 2019 09:48:41 -0500 Received: by smtp.corp.redhat.com (Postfix) id E09331037AD4; Wed, 20 Nov 2019 14:48:41 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.43.2.149]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6B5F31037ACE for ; Wed, 20 Nov 2019 14:48:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574261337; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zNZkl635e4Pa/x72eSkKhgNORs/G9h+gIvXI19vbDwk=; b=aSFtgzkRGI801yH6/GYkqlJ7QM8HDpiKqhLFB9svo/hVeHd4vllbfVC8jW905N4GjrKDsu 1BSHKHzfqQmlh80SiFe9s/3KEoFLIrgMUBFJkv/EQxuEHkIUQkmSLql5C+j7Wf40BcipuU zhKqQTri69zbWR9ZnAc7N1lXgePjJzU= From: Pavel Hrdina To: libvir-list@redhat.com Date: Wed, 20 Nov 2019 15:48:21 +0100 Message-Id: <8208e79f82a177ff569dbadb38f70133e6ac8f8b.1574261216.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 08/14] use g_ascii_isprint instead of c_isprint from gnulib X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: VPZpl_aSM72nP16uo-nc1w-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina --- src/qemu/qemu_agent.c | 3 +-- src/qemu/qemu_monitor.c | 3 +-- src/util/virstring.c | 4 ++-- tools/vsh-table.c | 3 +-- 4 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index e6add56cd6..5fa8d24a91 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -146,7 +146,6 @@ VIR_ONCE_GLOBAL_INIT(qemuAgent); =20 =20 #if DEBUG_RAW_IO -# include static char * qemuAgentEscapeNonPrintable(const char *text) { @@ -155,7 +154,7 @@ qemuAgentEscapeNonPrintable(const char *text) for (i =3D 0; text[i] !=3D '\0'; i++) { if (text[i] =3D=3D '\\') virBufferAddLit(&buf, "\\\\"); - else if (c_isprint(text[i]) || text[i] =3D=3D '\n' || + else if (g_ascii_isprint(text[i]) || text[i] =3D=3D '\n' || (text[i] =3D=3D '\r' && text[i+1] =3D=3D '\n')) virBufferAddChar(&buf, text[i]); else diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index cdad5c955d..ae649108d7 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -199,14 +199,13 @@ VIR_ENUM_IMPL(qemuMonitorDumpStatus, =20 =20 #if DEBUG_RAW_IO -# include static char * qemuMonitorEscapeNonPrintable(const char *text) { size_t i; virBuffer buf =3D VIR_BUFFER_INITIALIZER; for (i =3D 0; text[i] !=3D '\0'; i++) { - if (c_isprint(text[i]) || + if (g_ascii_isprint(text[i]) || text[i] =3D=3D '\n' || (text[i] =3D=3D '\r' && text[i + 1] =3D=3D '\n')) virBufferAddChar(&buf, text[i]); diff --git a/src/util/virstring.c b/src/util/virstring.c index 40c83841e9..a66b406298 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -1350,7 +1350,7 @@ virStringIsPrintable(const char *str) size_t i; =20 for (i =3D 0; str[i]; i++) - if (!c_isprint(str[i])) + if (!g_ascii_isprint(str[i])) return false; =20 return true; @@ -1369,7 +1369,7 @@ virStringBufferIsPrintable(const uint8_t *buf, size_t i; =20 for (i =3D 0; i < buflen; i++) - if (!c_isprint(buf[i])) + if (!g_ascii_isprint(buf[i])) return false; =20 return true; diff --git a/tools/vsh-table.c b/tools/vsh-table.c index 28072c9719..a2365b2c32 100644 --- a/tools/vsh-table.c +++ b/tools/vsh-table.c @@ -25,7 +25,6 @@ #include #include #include -#include "c-ctype.h" =20 #include "viralloc.h" #include "virbuffer.h" @@ -244,7 +243,7 @@ vshTableSafeEncode(const char *s, size_t *width) * Not valid multibyte sequence -- maybe it's * printable char according to the current locales. */ - if (!c_isprint(*p)) { + if (!g_ascii_isprint(*p)) { g_snprintf(buf, HEX_ENCODE_LENGTH + 1, "\\x%02x", *p); buf +=3D HEX_ENCODE_LENGTH; *width +=3D HEX_ENCODE_LENGTH; --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list