From nobody Sun Feb 8 23:42:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1596407094; cv=none; d=zohomail.com; s=zohoarc; b=nN+rvk9yWwepmAlrdrw3mE/VZLlrsIXkg1CS+yvNbyeQA474SSYuWI3PAoX/HayMQNuJQKiy/kFL4vrGUlowZxwRXCMoxzVr44c+7xwTSGHpot23qfn6kMqsNqeJSYTZ5i4JUA/XEmB/nNul9Z42VL6q4+bQTl8OFnpIvteWz2M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596407094; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=//PuMqqBhogIY2Fcpx1qZ1u7uYPtijhAqgbm2o9Bv+A=; b=bBubrFfeTr8JjFKcHto2mbUwGiKKiE/Jw7CJO5PeiNrFRTXc2P5pIJBItjFnEWIPnE+2OI6qxLtRN1OoqzSO2v5qzs/67aKdZPm74/4a0YPrX9e8XaUGcw2jbtsnQM3QA/fdfUSeBpB9nbl2j7LLQzcwZaXMQC+/Sak5LP5su78= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1596407094491298.0429994116389; Sun, 2 Aug 2020 15:24:54 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-505-eVWAjAkJP66EU5T4zMsfYA-1; Sun, 02 Aug 2020 18:24:51 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D9C3880BCAB; Sun, 2 Aug 2020 22:24:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BA12A87E2E; Sun, 2 Aug 2020 22:24:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8AB6A9A10E; Sun, 2 Aug 2020 22:24:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 072MOaZo011775 for ; Sun, 2 Aug 2020 18:24:36 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5EEDD5D9DC; Sun, 2 Aug 2020 22:24:36 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id AE9905D9D5 for ; Sun, 2 Aug 2020 22:24:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596407093; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=//PuMqqBhogIY2Fcpx1qZ1u7uYPtijhAqgbm2o9Bv+A=; b=HYXLjcBcTcrVxwHW5gCbfTYpOyYJjn6DXpH6P0NYUbD8HV/6UOXWWbmDLjm2FPD6yCEWQW afQFAVVlcUXNBbfJemi1G3qrXhuOuLvaRRKOeDyYjNiMVrP1gyq2ll3I+0wwkRnCVcgaMW nIpf0jfRS9TrCo32GtIFcg0BXbdfMEw= X-MC-Unique: eVWAjAkJP66EU5T4zMsfYA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 5/6] util: virlog: unexport virLogVMessage Date: Mon, 3 Aug 2020 00:24:23 +0200 Message-Id: <81d9955f07dc79d0026f09b12ffc77fb0ea763f0.1596407039.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Last usage out of virlog.c was removed by commit 91268c715cf0293f0751de0450e4d0c06bea18d8 node_device_udev: remove deprecated logging function Also drop the virbuffer.h include - it seems it was never used for anything else than the transitive stdarg.h include. Signed-off-by: J=C3=A1n Tomko --- src/libvirt_private.syms | 1 - src/util/virlog.c | 3 ++- src/util/virlog.h | 9 --------- 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index eea31a736d..1fae05057e 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2474,7 +2474,6 @@ virLogSetFilters; virLogSetFromEnv; virLogSetOutputs; virLogUnlock; -virLogVMessage; =20 =20 # util/virmacaddr.h diff --git a/src/util/virlog.c b/src/util/virlog.c index 983c2565ad..322f9599f6 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -493,7 +493,8 @@ virLogSourceUpdate(virLogSourcePtr source) * Call the libvirt logger with some information. Based on the configurati= on * the message may be stored, sent to output or just discarded */ -void +static void +G_GNUC_PRINTF(7, 0) virLogVMessage(virLogSourcePtr source, virLogPriority priority, const char *filename, diff --git a/src/util/virlog.h b/src/util/virlog.h index feb2f85904..9913a194fd 100644 --- a/src/util/virlog.h +++ b/src/util/virlog.h @@ -22,7 +22,6 @@ #pragma once =20 #include "internal.h" -#include "virbuffer.h" =20 #ifdef PACKAGER_VERSION # ifdef PACKAGER @@ -199,14 +198,6 @@ void virLogMessage(virLogSourcePtr source, const char *funcname, virLogMetadataPtr metadata, const char *fmt, ...) G_GNUC_PRINTF(7, 8); -void virLogVMessage(virLogSourcePtr source, - virLogPriority priority, - const char *filename, - int linenr, - const char *funcname, - virLogMetadataPtr metadata, - const char *fmt, - va_list vargs) G_GNUC_PRINTF(7, 0); =20 bool virLogProbablyLogMessage(const char *str); virLogOutputPtr virLogOutputNew(virLogOutputFunc f, --=20 2.26.2