From nobody Mon Feb 9 08:04:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1728653756744789.201305722973; Fri, 11 Oct 2024 06:35:56 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A7D9C1446; Fri, 11 Oct 2024 09:35:55 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 532C016D3; Fri, 11 Oct 2024 09:33:29 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3AF021380; Fri, 11 Oct 2024 09:33:25 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id BBDE713D3 for ; Fri, 11 Oct 2024 09:33:12 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-oxO41ySXOuG14KoybAcN5w-1; Fri, 11 Oct 2024 09:33:11 -0400 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 56F7C1956096 for ; Fri, 11 Oct 2024 13:33:10 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.12]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7713A19560AA for ; Fri, 11 Oct 2024 13:33:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728653592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5UcazoJLYkTsyqNbWWi8Dy9jJyDcwyr05BrIa2CKlhk=; b=IRbsdHR/8DixJOavDkGUFHt3XrLgeyRh2x4/FfLWZpb6SnVMXCg/LPEYg+FmLNwVtdRCy1 uNIptqodki/1UjUEamkywtM2GcOVVmOWG4Cv23HVQz7/BkVzWAFAtqPMN2GXFcrJs+elU/ K8ONa65cfBgzYMQnWwM2pu3UOt5Yp4Y= X-MC-Unique: oxO41ySXOuG14KoybAcN5w-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 03/10] qemublocktest: Mark 'gluster' case in image creation test as deprecated Date: Fri, 11 Oct 2024 15:32:56 +0200 Message-ID: <81c56542a5b9b58ea5175754b50b29b281dca617.1728653516.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: MHHPI3JA2PU2KXFBSCI74J3B4L3CUWLY X-Message-ID-Hash: MHHPI3JA2PU2KXFBSCI74J3B4L3CUWLY X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1728653758093116600 Content-Type: text/plain; charset="utf-8" The gluster protocol backend will be deprecated as of qemu-9.2. Allow it for now in the QMP schema validator and mark them to be dropped once gluster is removed. Signed-off-by: Peter Krempa --- tests/qemublocktest.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/qemublocktest.c b/tests/qemublocktest.c index f8e9b73c6a..7ffa445c37 100644 --- a/tests/qemublocktest.c +++ b/tests/qemublocktest.c @@ -455,6 +455,8 @@ struct testQemuImageCreateData { virJSONValue *schemaroot; virQEMUDriver *driver; virQEMUCaps *qemuCaps; + + bool deprecated; }; static const char *testQemuImageCreatePath =3D abs_srcdir "/qemublocktestd= ata/imagecreate/"; @@ -528,7 +530,7 @@ testQemuImageCreate(const void *opaque) return -1; if (testQEMUSchemaValidate(formatprops, data->schemaroot, data->sc= hema, - false, &debug) < 0) { + data->deprecated, &debug) < 0) { g_autofree char *debugmsg =3D virBufferContentAndReset(&debug); VIR_TEST_VERBOSE("blockdev-create format json does not conform= to QAPI schema"); VIR_TEST_DEBUG("json:\n%s\ndoes not match schema. Debug output= :\n %s", @@ -543,7 +545,7 @@ testQemuImageCreate(const void *opaque) return -1; if (testQEMUSchemaValidate(protocolprops, data->schemaroot, data->= schema, - false, &debug) < 0) { + data->deprecated, &debug) < 0) { g_autofree char *debugmsg =3D virBufferContentAndReset(&debug); VIR_TEST_VERBOSE("blockdev-create protocol json does not confo= rm to QAPI schema"); VIR_TEST_DEBUG("json:\n%s\ndoes not match schema. Debug output= :\n %s", @@ -1209,7 +1211,10 @@ mymain(void) TEST_IMAGE_CREATE("qcow2-backing-raw-slice", "raw-slice"); TEST_IMAGE_CREATE("qcow2-backing-qcow2-slice", "qcow2-slice"); + /* 'gluster' is deprecated as of qemu-9.2, once removed this tests can= be dropped too */ + imagecreatedata.deprecated =3D true; TEST_IMAGE_CREATE("network-gluster-qcow2", NULL); + imagecreatedata.deprecated =3D false; TEST_IMAGE_CREATE("network-rbd-qcow2", NULL); TEST_IMAGE_CREATE("network-ssh-qcow2", NULL); --=20 2.46.2