From nobody Mon Feb 2 18:08:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1715264669808815.139692519947; Thu, 9 May 2024 07:24:29 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 821AC1B77; Thu, 9 May 2024 10:24:28 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 9353D1B84; Thu, 9 May 2024 10:23:57 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9995F1B34; Thu, 9 May 2024 10:23:54 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 19C6C1B3F for ; Thu, 9 May 2024 10:23:51 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-126-tU6NJpwAMG-YlzqmvWKkIg-1; Thu, 09 May 2024 10:23:49 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 33D301C004E8 for ; Thu, 9 May 2024 14:23:49 +0000 (UTC) Received: from orkuz (unknown [10.43.3.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id EDF4C419BAAE for ; Thu, 9 May 2024 14:23:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: tU6NJpwAMG-YlzqmvWKkIg-1 From: Jiri Denemark To: devel@lists.libvirt.org Subject: [PATCH] network: Register dnsmasq with resolved only when really requested Date: Thu, 9 May 2024 16:23:35 +0200 Message-ID: <815548ed7af8b9e0573fa4072bfcc17568aa67a5.1715264615.git.jdenemar@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: WMUZEW7JP5MKNHPW2R4SGGTMEIK4LMBU X-Message-ID-Hash: WMUZEW7JP5MKNHPW2R4SGGTMEIK4LMBU X-MailFrom: jdenemar@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1715264671841100001 An incorrect check for domainRegister caused the DNS server for a virtual domain to be registered with systemd-resolved even if register=3D'no' attribute was present. Only omitting the attribute completely would disable the registration. Reported-by: Daniel P. Berrang=C3=A9 Signed-off-by: Jiri Denemark Reviewed-by: Daniel P. Berrang=C3=A9 --- src/network/bridge_driver.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index d89700c6ee..e5f9ecf9e8 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -2016,7 +2016,9 @@ networkStartNetworkVirtual(virNetworkDriverState *dri= ver, =20 dnsmasqStarted =3D true; =20 - if (def->domain && def->domainRegister && dnsServer) { + if (def->domain && + def->domainRegister =3D=3D VIR_TRISTATE_BOOL_YES && + dnsServer) { unsigned int link; int rc; =20 --=20 2.45.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org