From nobody Mon Feb 9 19:30:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559748722; cv=none; d=zoho.com; s=zohoarc; b=kv0fdd4h9PtPIMIA5Wa1ybopMSjsxAjRXcK7I6sYjvau6fkl1wY7F8/tjnesYhZVP32yl8GevuGEmOFtpMxcuxAiFcoRpgUbSFbswpOtxwZ7+XRjBK4u2VxvNwGKG53QKMKik+50jWKYOPlDDzIYt8YSQ7F7kgkROYsXLDXHaWs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559748722; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=/y+EktaBs03aIlH3R7h6LJumXWA4IaokPcyrVgKBIQw=; b=HcA+PZPOMGYDmYXec4rJGOG6EMiyqWLw+B14RJIJwTi+Ln3bmaFB1JGTarpecxwEs54E5ZVF1NjCk4mnXIePAa+AGEjIcSE3/uff+uuEucHPUZCcj+jviRpMVJeMgsi4teAwu5ss69ntNbZoaGqVVyp5BDD39ye6xXWpMai0hG0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1559748722745457.30727526248245; Wed, 5 Jun 2019 08:32:02 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EF84218DF7B; Wed, 5 Jun 2019 15:32:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C3D062E02A; Wed, 5 Jun 2019 15:31:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8A5531806B0F; Wed, 5 Jun 2019 15:31:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x55FSnje012971 for ; Wed, 5 Jun 2019 11:28:49 -0400 Received: by smtp.corp.redhat.com (Postfix) id 871CA17F22; Wed, 5 Jun 2019 15:28:49 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id 10D775F7C0 for ; Wed, 5 Jun 2019 15:28:48 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Wed, 5 Jun 2019 17:28:34 +0200 Message-Id: <806b6bedfb2ae48b37f465e2d1deef9d2a631b53.1559748399.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 12/13] qemu: snapshot: Return early if there's nothing to snapshot X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 05 Jun 2019 15:32:01 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Skip actual snapshot creation code if we have 0 disks to snapshot. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_driver.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 5b6d3bb795..b7f5142605 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -15259,6 +15259,12 @@ qemuDomainSnapshotCreateDiskActive(virQEMUDriverPt= r driver, &diskdata, &ndiskdata) < 0) goto cleanup; + /* check whether there's anything to do */ + if (ndiskdata =3D=3D 0) { + ret =3D 0; + goto cleanup; + } + /* Based on earlier qemuDomainSnapshotPrepare, all disks in this list= are * now either VIR_DOMAIN_SNAPSHOT_LOCATION_NONE, or * VIR_DOMAIN_SNAPSHOT_LOCATION_EXTERNAL with a valid file name and --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list