From nobody Fri Dec 12 14:06:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1765363333; cv=none; d=zohomail.com; s=zohoarc; b=QEwTToaQUqO/uACzEzBMM47dtZU318vhKq+ZD/1nKTI0uI1gN45FJqUXxmlqoFgdU5+bx2z37etNi541zelMuBl0kn3gk2J1x6eUa8jvg4DB/ClEGXGQhrYcYu9UuRMjkwOu7dFmhZPZli2prvAFEpURuJVngYqzvb6jrxhJ3Ro= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1765363333; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=bDLjRjKIDkFrCEiS07KjuuTIR0LInuQnNJIyNVKOPTo=; b=HzFUyk9QMIGOmqLTN0a1IHdoQCoqaE8tKCgXxWwfTgck8cUgcOtwGn2aZZpryFgCoLSD+te5HN6KnY/Yo22la5iGTK518QYNrJFaVsse+u95ZDHLJPJgDDWe2XF52rtPTyHC11kJ0EgDMYUsQ9f4aYLJ/s9ooplaAaSG6sTwy7E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1765363333109266.07475092465495; Wed, 10 Dec 2025 02:42:13 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 10EEC41C9A; Wed, 10 Dec 2025 05:42:06 -0500 (EST) Received: from [172.19.199.80] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 0CDC841E58; Wed, 10 Dec 2025 05:39:51 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 35D2A41B41; Wed, 10 Dec 2025 05:32:41 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8F76741B42 for ; Wed, 10 Dec 2025 05:32:40 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-423-q8zAR_03MI-iJLyJJdgK-A-1; Wed, 10 Dec 2025 05:32:39 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 51A0C18002DE for ; Wed, 10 Dec 2025 10:32:38 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.44.22.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9DD4930001A5 for ; Wed, 10 Dec 2025 10:32:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765362760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bDLjRjKIDkFrCEiS07KjuuTIR0LInuQnNJIyNVKOPTo=; b=Ay8CX3kjX59I/yd6vANU+h1qq5WsesA73tu/8O3M/4JlFvaO008x/axF8SfX+W2vKnxFTY gkrakW4I2xGKc3VSSXaKxmM4UviBbhS1hv/R9YMAyI3WXFV8k8ltv2AJVex5CcCmdBwUh2 x42XiyQSoUx63LJKAalfdpAyKwcmM1M= X-MC-Unique: q8zAR_03MI-iJLyJJdgK-A-1 X-Mimecast-MFC-AGG-ID: q8zAR_03MI-iJLyJJdgK-A_1765362758 To: devel@lists.libvirt.org Subject: [PATCH 04/10] qemuDomainEventEmitJobCompleted: Remove 'driver' argument Date: Wed, 10 Dec 2025 11:32:25 +0100 Message-ID: <7e49299c6f1cd2b613d7c4504ff2bc64c87a1d20.1765362608.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3SlUBrONMWIZpvZRdYoYAyBGAYhTgMjmZs1mKvmrREA_1765362758 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CQFOECROLIZRAWGQ3PLFWW6W4OG4MGBD X-Message-ID-Hash: CQFOECROLIZRAWGQ3PLFWW6W4OG4MGBD X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1765363333529158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa We pass in 'vm' which contains it in the private data. Signed-off-by: Peter Krempa --- src/qemu/qemu_backup.c | 2 +- src/qemu/qemu_domainjob.c | 6 +++--- src/qemu/qemu_domainjob.h | 3 +-- src/qemu/qemu_migration.c | 4 ++-- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c index c3566bcd57..44514d08fc 100644 --- a/src/qemu/qemu_backup.c +++ b/src/qemu/qemu_backup.c @@ -619,7 +619,7 @@ qemuBackupJobTerminate(virDomainObj *vm, vm->job->completed->status =3D jobstatus; vm->job->completed->errmsg =3D g_strdup(priv->backup->errmsg); - qemuDomainEventEmitJobCompleted(priv->driver, vm); + qemuDomainEventEmitJobCompleted(vm); } g_clear_pointer(&priv->backup, virDomainBackupDefFree); diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c index afea1ea57a..e5236c9778 100644 --- a/src/qemu/qemu_domainjob.c +++ b/src/qemu/qemu_domainjob.c @@ -95,9 +95,9 @@ qemuDomainAsyncJobPhaseFromString(virDomainAsyncJob job, void -qemuDomainEventEmitJobCompleted(virQEMUDriver *driver, - virDomainObj *vm) +qemuDomainEventEmitJobCompleted(virDomainObj *vm) { + qemuDomainObjPrivate *priv =3D vm->privateData; virObjectEvent *event; virTypedParameterPtr params =3D NULL; int nparams =3D 0; @@ -113,7 +113,7 @@ qemuDomainEventEmitJobCompleted(virQEMUDriver *driver, } event =3D virDomainEventJobCompletedNewFromObj(vm, params, nparams); - virObjectEventStateQueue(driver->domainEventState, event); + virObjectEventStateQueue(priv->driver->domainEventState, event); } diff --git a/src/qemu/qemu_domainjob.h b/src/qemu/qemu_domainjob.h index c3de401aa5..bd6731abb5 100644 --- a/src/qemu/qemu_domainjob.h +++ b/src/qemu/qemu_domainjob.h @@ -66,8 +66,7 @@ const char *qemuDomainAsyncJobPhaseToString(virDomainAsyn= cJob job, int qemuDomainAsyncJobPhaseFromString(virDomainAsyncJob job, const char *phase); -void qemuDomainEventEmitJobCompleted(virQEMUDriver *driver, - virDomainObj *vm); +void qemuDomainEventEmitJobCompleted(virDomainObj *vm); void qemuDomainObjAbortAsyncJob(virDomainObj *obj); void qemuDomainObjSetJobPhase(virDomainObj *obj, diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 32afc788ad..b2d67a1e74 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -4122,7 +4122,7 @@ qemuMigrationSrcComplete(virQEMUDriver *driver, VIR_DOMAIN_EVENT_STOPPED, VIR_DOMAIN_EVENT_STOPPED_MIG= RATED); virObjectEventStateQueue(driver->domainEventState, event); - qemuDomainEventEmitJobCompleted(driver, vm); + qemuDomainEventEmitJobCompleted(vm); priv->preMigrationMemlock =3D 0; } @@ -7313,7 +7313,7 @@ qemuMigrationSrcToFile(virQEMUDriver *driver, virDoma= inObj *vm, if (compressor && virCommandWait(compressor, NULL) < 0) goto cleanup; - qemuDomainEventEmitJobCompleted(driver, vm); + qemuDomainEventEmitJobCompleted(vm); ret =3D 0; cleanup: --=20 2.52.0