From nobody Mon Feb 9 10:30:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1667314983; cv=none; d=zohomail.com; s=zohoarc; b=ePZiml25xZQabuEwZu7pQ5B88hJLMZzSaRsT3e//aJb7+axIvWeTmtqDEg0S+B8+/7WHJCbLiDN2D+G06ejg5VJkrWqasdguhxWK2uj/N+KGUDiQbi628iK9/iezfE/bBVF0osS8LecGMmFFbRXLyrTPzIdZhldj3YpnCrvG8JY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1667314983; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=N3XwJLiwx89fwYHyfAJ+gQtq3IYC5Gd8+NnMmA1wrgg=; b=BohtdP7NujnQsgmln3sEWhNoP03e7XzHqv0NpEet5T0iK4sxOEpOPR7ZtLy9Ayu5gXFJElaTj/5RpYsdnMe6KOr+ovu/dIAhqtICzQ0Un+owYVlHjbeVTWsumc1eAj2sc50lFEaiadCJrWxE7TUqN8aJkZMaOAsZKXjiEX7BE+g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1667314983548600.3259837990496; Tue, 1 Nov 2022 08:03:03 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-661-uJe5CnPlMWyypbk9-qLSbA-1; Tue, 01 Nov 2022 11:02:58 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 22A3880A0AE; Tue, 1 Nov 2022 15:02:40 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0E026492B18; Tue, 1 Nov 2022 15:02:40 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D9CE019465B3; Tue, 1 Nov 2022 15:02:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3C2291946A42 for ; Tue, 1 Nov 2022 15:02:39 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 2EB6B2166BC4; Tue, 1 Nov 2022 15:02:39 +0000 (UTC) Received: from speedmetal.redhat.com (ovpn-208-3.brq.redhat.com [10.40.208.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC6C72166B2D for ; Tue, 1 Nov 2022 15:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667314981; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=N3XwJLiwx89fwYHyfAJ+gQtq3IYC5Gd8+NnMmA1wrgg=; b=Ty7sopMSZlMsNTwMMHDEyf9TNXKLPwI5oNgKxz+HNV4whK5l9eLvFobnGg9vcGidBQkeXT svqteG56gij1vHLzTLfExWL+FXmLP4TOuZX52MyhHt/GqMZyKY1CjsWxP2C8UhZZVSUs8B 4sswzPmg4CFxisl6YxR+rTmRIY9SLs4= X-MC-Unique: uJe5CnPlMWyypbk9-qLSbA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 02/11] conf: domain: Remove pointless XML node name validation in virSysinfoBIOSParseXML Date: Tue, 1 Nov 2022 16:02:16 +0100 Message-Id: <7d94c1640c6aa1b2d9cee7e6042bc7f511b7ba21.1667314911.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1667314984051100001 Content-Type: text/plain; charset="utf-8" The only caller passes 'node' argument originating from an XPath lookup for the 'bios' element, so there's no point in checking it once more. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 15db12876e..eab2e98792 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -12140,12 +12140,6 @@ virSysinfoBIOSParseXML(xmlNodePtr node, ctxt->node =3D node; - if (!virXMLNodeNameEqual(node, "bios")) { - virReportError(VIR_ERR_XML_ERROR, "%s", - _("XML does not contain expected 'bios' element")); - return -1; - } - def->vendor =3D virXPathString("string(entry[@name=3D'vendor'])", ctxt= ); def->version =3D virXPathString("string(entry[@name=3D'version'])", ct= xt); def->date =3D virXPathString("string(entry[@name=3D'date'])", ctxt); --=20 2.37.3