From nobody Mon Feb 9 09:24:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1725893311212479.55019567805334; Mon, 9 Sep 2024 07:48:31 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 231761920; Mon, 9 Sep 2024 10:48:30 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 86A43194E; Mon, 9 Sep 2024 10:46:42 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id B6E741897; Mon, 9 Sep 2024 10:46:36 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8519A182B for ; Mon, 9 Sep 2024 10:46:24 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-315-faXasFQvNNCVsy1XaZlbIw-1; Mon, 09 Sep 2024 10:46:22 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 35DC619541A1 for ; Mon, 9 Sep 2024 14:46:20 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.7]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 637CF195608A for ; Mon, 9 Sep 2024 14:46:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725893184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8OpktioIrizRPAaN9DMOuVSWbmVuSZK6Zb1CDuPq52k=; b=gdgN/j5udWmnKdA+jbG7DkQC/RGz7bizGSlDSoRwbo2yjPUPX/+fDYcxZcyncjPWk46Bu1 9qU2pK2Ds1POZVd+Of1oN9aqDLuTQfjToqA9od3U4OvSk38mQfesLFt+7ujsX+xujMnC2A NhHlyG1z/L2dPM0LHKHCv7gtqa8wV0w= X-MC-Unique: faXasFQvNNCVsy1XaZlbIw-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 5/9] virDomainFeaturesDefParse: Add comment warning about features being specified repeatedly Date: Mon, 9 Sep 2024 16:46:06 +0200 Message-ID: <7d5ee2eb3b5aa42c284fc30a25d2793ad71c0494.1725893134.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BAY6WTHXCNRLNCOMNBMIXC47C3V2D2ZQ X-Message-ID-Hash: BAY6WTHXCNRLNCOMNBMIXC47C3V2D2ZQ X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1725893312700116600 Content-Type: text/plain; charset="utf-8" Few of the handlers didn't take that possibility into account. Warn others. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0f0488f3a2..cf4b1b2aef 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -16849,6 +16849,8 @@ virDomainFeaturesDefParse(virDomainDef *def, return -1; } + /* Beware that users can specify the given feature multiple times,= so + * the parser must be able to handle that */ switch ((virDomainFeature) val) { case VIR_DOMAIN_FEATURE_ACPI: case VIR_DOMAIN_FEATURE_PAE: --=20 2.46.0