From nobody Tue Dec 16 13:50:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1743166561; cv=none; d=zohomail.com; s=zohoarc; b=NOJdbJy2JELyz289Bd+l/Q3vZ62St+4QXynHRxFtxG9YJAAHm/nQ9lGIiQl9PFe1qd1mltHkfu3VSGz3XztjJ83s2qDNF4kNp/yh/Frl13DJSQPk3Q8DGHH0UGYI5839LH5mwnoMtnLKpNXphZYXkm9/wALZ+SBNSWRULMIcD4I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743166561; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=cux3F0blSBj+ZsrMhqQTaXxJJhXosm1QS+QW90rPh3g=; b=UmVtX53nnO5cviXuBPCiBjAgDIYc5Nfer7Hq80cQV8XPPe+LaQdID4AhErbk69+yKg/2og9h322nypm00CNzrofK1aANjMkf0256y0H46thCZJmAFyN+hghy4qPkimzPbQm610hRAGfq+8+Po4gT+gqxs4S9cqcw4wMJNTfOzlo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1743166561853264.8610900710461; Fri, 28 Mar 2025 05:56:01 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id EB09E1223; Fri, 28 Mar 2025 08:56:00 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id F05581378; Fri, 28 Mar 2025 08:53:13 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id CFE6B1253; Fri, 28 Mar 2025 08:53:10 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id DB26112FB for ; Fri, 28 Mar 2025 08:52:52 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-53-DjrVwkLMO1KEaTMwtpszvA-1; Fri, 28 Mar 2025 08:52:51 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 76B9B180087D for ; Fri, 28 Mar 2025 12:52:50 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.8]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 663311828AAA; Fri, 28 Mar 2025 12:52:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743166372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZiVnAvV0Qh+cl8XlOKv79HdIGyZYRsdbsGOyjDHrhHU=; b=aTkNcDOyhRRcSbTV1B7nFl0SGXPICbjqXu6EgojouTHqfD++QJ5Tc69yvsV8sgwmTE61oJ K+WCfcmreaPOmNaNOcs9UQhpCMTvCsd4gkFsrcAJxNkNTyVluDvM/qKPQ5qnJDEeKzmjRK a9uNsd2Bi1+XyJ/To4/RllvfCj4890A= X-MC-Unique: DjrVwkLMO1KEaTMwtpszvA-1 X-Mimecast-MFC-AGG-ID: DjrVwkLMO1KEaTMwtpszvA_1743166370 To: devel@lists.libvirt.org Subject: [PATCH 8/8] qemu: monitor: Improve field annotations in QEMU_CHECK_MONITOR Date: Fri, 28 Mar 2025 13:52:34 +0100 Message-ID: <7ca7babfcd4806f362a28ffeac3a55670f3845eb.1743166287.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2Duv2fkOW3ylB9ZH52SsCjBPrnPfd9mg_GeYxojksM0_1743166370 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: K7FKUE75IDWZAQC42G5MSHVJ356RUMZV X-Message-ID-Hash: K7FKUE75IDWZAQC42G5MSHVJ356RUMZV X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Peter Krempa X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1743166564050019100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The macro checking monitor object state also logs information such as the monitor object pointer and the number of the monitor FD. Name the field 'monfd' instead of 'fd' as it's confusing when debugging FD pasing via monitor. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 6249dc8299..fc215def13 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -80,7 +80,7 @@ VIR_LOG_INIT("qemu.qemu_monitor"); _("monitor must not be NULL")); \ exit; \ } \ - VIR_DEBUG("mon:%p vm:%p fd:%d", mon, mon->vm, mon->fd); \ + VIR_DEBUG("mon:%p vm:%p monfd:%d", mon, mon->vm, mon->fd); \ } while (0) /* Check monitor and return NULL on error */ --=20 2.49.0