From nobody Thu Apr 16 20:37:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1745264348; cv=none; d=zohomail.com; s=zohoarc; b=nFLHFYVklZzWtcZdONgN7CHJks5pkrsrfoag8GYIKoRPVXSERkTQVavtkl2zloF+p0bf/TPERuqFqSnxIZR3Y9b2UYjwKneWQUAUdNJvdJ7TQVGkSNHVSq/t5PdaE/JKk6wiByQF3ryQxxjWBDIzVLjZL8TB2mP6IH5ZoeA3GCY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1745264348; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=aQ/mU2Z3+tFF3wDVM5KpOwUUmS/h8G9bqQeumhY7uZQ=; b=SF1HoVilQjJl81N2Db5KlQBesKeBtYNGU0QFS/gtesmYDjlr5jym8FKhGmNwgxSMkJo+va5lICeGRjp7qyJw1gGEdTAUiIQ6cMOFxgG1WW9ge2dl+JE65yiRHiLNj8w3BzQNQXXjLdTha+FQYTGkE7Q9wrWmsVgOP7wnW3ysxXg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1745264348739197.54005045151666; Mon, 21 Apr 2025 12:39:08 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9F26DCD1; Mon, 21 Apr 2025 15:39:07 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 03D54C61; Mon, 21 Apr 2025 15:38:44 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id E4EDFBF8; Mon, 21 Apr 2025 15:38:39 -0400 (EDT) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 85B21BD4 for ; Mon, 21 Apr 2025 15:38:38 -0400 (EDT) Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-39c0e0bc733so3535963f8f.1 for ; Mon, 21 Apr 2025 12:38:38 -0700 (PDT) Received: from [192.168.0.10] (75-169-2-37.slkc.qwest.net. [75.169.2.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c50bf5774sm69392275ad.93.2025.04.21.12.38.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Apr 2025 12:38:36 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1745264317; x=1745869117; darn=lists.libvirt.org; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=aQ/mU2Z3+tFF3wDVM5KpOwUUmS/h8G9bqQeumhY7uZQ=; b=SOchL5ms6fwbal+3x15f31ixqEm49Vb+rk82MsMKoN5MD16yYUZcOGVi/QkDPX/W4v ZcmSALvNeoHrrHYxaO6gV9qh7NuvCYMYMwaZdOBOTISkhVpocGhqjuY6yZag+ZJlUEm4 eufHI4LKc46we6CFx5AVKTl2b7dafSi7Ld3llyc2FZ8mPt3zYpSd76gT0z3vKQAFWiyP syOMKCvlUCgo9WDX1wLq7iQfzNhspUpb6/tMGnnT1tntu/6C4hx9Z02O3i+C5C3/BkEa CIfAw8Vc6gHWRVg/NpNBViHeAqcC23FC28LvNdsbZPKW9xkPL5bRvJIAZRm1/n6Pw2n/ XgZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745264317; x=1745869117; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=aQ/mU2Z3+tFF3wDVM5KpOwUUmS/h8G9bqQeumhY7uZQ=; b=a67GWIIH6KZSKFYlLzu1lTYJfMG6jIDl4WDx/a3uv0S47FBS1I/tJqu9nij4sDzlTp uXTHz/rLmYq/W51DG2D2un4iPY7QB7BvSrY+nv7XPQ0RbhSPMs+dVA0VRV6sst7KX3cl J4Bfq3Bycjr5LurqxuPJy72vnuENEa2ZjZ0co4YevtQttF79N+xFuW2PiyDiJOS6NBT1 Muw/6e8vR1jHMo+y1YPkuSq54UsL99loX6aclQgdtjvW6rS/uGyAfMFdzEnmJL1VW+kM rLvlxv3laJWztPZMp/sIW1+CGHfMdtKEy34a7UqqpZiU+Ghm6YECntw4UeKxebVOABQx T96w== X-Gm-Message-State: AOJu0Yya/ylepObA05hxXKurBvvSUUig1OGXV85fUx0I5nmH5NX7PIIB /loFZAu1iO/9inN+55+hrMLULbv6hU/uQIYyv8PIPvx3nvEj0kYKs2y0ZegTEhdgNarJ91nFnhH D X-Gm-Gg: ASbGnctQx+ktM5v5V+6B7RzctIEnK297EWnZjw35POgjHTAHIT7uPcdS7W50r8CZ6kE +bp1j1dCFUxANZHZPtcJWuhgBue+zmedmdu1uTCtH4O8/PRipCIu8Brpv08Ip6OX9IOO/AUty3y Up3Vn3xxMvRZ00UOlIADuV9yUa2tIvHFK0O3CAQANvzEJA8UF3td2L1+jwOgfuvVoqEtlzbPpyU 44TsS1QOTR2GfvbqkVrbmJW3yY6Jm5dtvyQ+56eml1fdJD3q6R1LlhABaD4Zre2U0Z9nmU9soMy c9lRTx8R6nXVCSkpmYyTniH6QP5B74xzut1zs3FoS5SM9151/6hiL+J0SDf+z2o= X-Google-Smtp-Source: AGHT+IHUHvXxqqzG2cPCa6Kn5KzQ0oj+M3JjZprpVy1rPZbn1vkfDqlwRZBfiCDnycX+P2kDvz3LaQ== X-Received: by 2002:a5d:64ae:0:b0:390:e7c1:59c4 with SMTP id ffacd0b85a97d-39efba50a80mr11238784f8f.13.1745264317255; Mon, 21 Apr 2025 12:38:37 -0700 (PDT) Message-ID: <7c56e3b1-225f-40c0-a5ae-ce61c8a51ae4@suse.com> Date: Mon, 21 Apr 2025 13:38:35 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: devel@lists.libvirt.org Subject: Question about SEV* guests and automatic firmware selection Content-Transfer-Encoding: quoted-printable Message-ID-Hash: U33UEJEXZGZEWOLGVAA5UWPLYY4WHEHT X-Message-ID-Hash: U33UEJEXZGZEWOLGVAA5UWPLYY4WHEHT X-MailFrom: jfehlig@suse.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Jim Fehlig via Devel Reply-To: Jim Fehlig X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745264353781019100 Content-Type: text/plain; charset="utf-8"; format="flowed" Hi All, While investigating an internal bug report, we noticed that a minimal firmw= are=20 auto-selection configuration along with SEV* fails to find a match. E.g. th= e=20 following config hvm 0x07 ... Fails with "Unable to find 'efi' firmware that is compatible with the curre= nt=20 configuration". A firmware that should match has the following json descrip= tion { "description": "UEFI firmware for x86_64, with AMD SEV", "interface-types": [ "uefi" ], "mapping": { "device": "flash", "mode": "stateless", "executable": { "filename": "/usr/share/qemu/ovmf-x86_64-sev.bin", "format": "raw" } }, "targets": [ { "architecture": "x86_64", "machines": [ "pc-q35-*" ] } ], "features": [ "acpi-s4", "amd-sev", "amd-sev-es", "amd-sev-snp", "verbose-dynamic" ], "tags": [ ] } Auto-selection works fine if I specify a 'stateless' firmware, e.g. amend t= he=20 above config with hvm Being unfamiliar with the firmware auto-selection code, I tried the below n= aive=20 hack, which only led to test failures and the subsequent runtime error "una= ble=20 to find any master var store for loader: /usr/share/qemu/ovmf-x86_64-sev.bi= n".=20 Should auto-selection work with the minimal config, or is it expected that = user=20 also specify a stateless firmware? Regards, Jim diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c index 2d0ec0b4fa..660b74141a 100644 --- a/src/qemu/qemu_firmware.c +++ b/src/qemu/qemu_firmware.c @@ -1293,15 +1293,17 @@ qemuFirmwareMatchDomain(const virDomainDef *def, return false; } - if (loader && loader->stateless =3D=3D VIR_TRISTATE_BOOL_YES) { - if (flash->mode !=3D QEMU_FIRMWARE_FLASH_MODE_STATELESS) { - VIR_DEBUG("Discarding loader without stateless flash"); - return false; - } - } else { - if (flash->mode !=3D QEMU_FIRMWARE_FLASH_MODE_SPLIT) { - VIR_DEBUG("Discarding loader without split flash"); - return false; + if (loader) { + if (loader->stateless =3D=3D VIR_TRISTATE_BOOL_YES) { + if (flash->mode !=3D QEMU_FIRMWARE_FLASH_MODE_STATELESS) { + VIR_DEBUG("Discarding loader without stateless flash"); + return false; + } + } else if (loader->stateless =3D=3D VIR_TRISTATE_BOOL_NO) { + if (flash->mode !=3D QEMU_FIRMWARE_FLASH_MODE_SPLIT) { + VIR_DEBUG("Discarding loader without split flash"); + return false; + } } }