From nobody Sun Feb 8 18:32:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582897225; cv=none; d=zohomail.com; s=zohoarc; b=JNfQhlTizHgXjnrjO35nmjZCFsO/A8Ep/gB6EE+MBvG4I2KxrRu5YOeDayaagfsSY3yNKKrjPgXQBjbpUiYspmGFYLkyF26rCuVcoPf2agO09En7qyzmEDWBjt4LEgB0T15gmykcqFMEt0FMV3134NIuxceKfA/ywWGEERaRdvM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582897225; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=x0oUtNTxe+lZsq6U3j8EUxgEa7XQbQpMoYjI2imOevs=; b=jbdnkKw3oKZz+zdZhmcwMjesKkWYt2ze7fQhiV/ZRZGzNjvuoEmV/Add7MqGdEtfDlhrzuA27chlQY8yXSudaVQfR3HDI5lC89/Qkgp23/Ej8j/NZaS04qgUGU0czT7KL7d+4cdpZ0+fU2Q1EYvqy7CsfxEXgJcJm0fKY4a8DGc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1582897225719931.507836633888; Fri, 28 Feb 2020 05:40:25 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-323--3rYpo23MFSURhd1RyMmzQ-1; Fri, 28 Feb 2020 08:40:22 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B7092100550E; Fri, 28 Feb 2020 13:40:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5C8A89299F; Fri, 28 Feb 2020 13:40:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 67C1F84481; Fri, 28 Feb 2020 13:40:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 01SDe8lM025669 for ; Fri, 28 Feb 2020 08:40:08 -0500 Received: by smtp.corp.redhat.com (Postfix) id C7607101D493; Fri, 28 Feb 2020 13:40:08 +0000 (UTC) Received: from angien.redhat.com (unknown [10.43.2.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4E6201001B2C for ; Fri, 28 Feb 2020 13:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582897224; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=x0oUtNTxe+lZsq6U3j8EUxgEa7XQbQpMoYjI2imOevs=; b=TwOxyhHmmy/l1B7oQPCQiv9poycTipeT4aQ7ZZhO6bfQM6RiWVJOTlx9u2bDw1bFhmokCH oD852aO5r4eGcSLXNExOCovAGBq9Sjia64lxC67d147KigkMVGwpkiJlUzN62hTG9uh6C0 pbZOLIMbyXxrDsPf1JPOYrHbd7chk5I= X-MC-Unique: -3rYpo23MFSURhd1RyMmzQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 5/8] qemuCheckpointDiscardBitmaps: Use correct field for checkpoint bitmap name Date: Fri, 28 Feb 2020 14:39:57 +0100 Message-Id: <7b4c6d4fd3ebffdbe273e3f46f2c968af7b5a5cf.1582895792.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The code deleting checkpoints needs the name of the parent checkpoint's disk's bitmap but was using the disk alias instead. This would create wrong bitmaps after deleting some checkpoints. Signed-off-by: Peter Krempa --- src/qemu/qemu_checkpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c index 32b0ab0faf..378f6c147e 100644 --- a/src/qemu/qemu_checkpoint.c +++ b/src/qemu/qemu_checkpoint.c @@ -283,7 +283,7 @@ qemuCheckpointDiscardBitmaps(virDomainObjPtr vm, * ancestor. */ if ((parentchkdisk =3D qemuCheckpointFindActiveDiskInParent(vm, pa= rent, chkdisk-= >name))) - parentbitmap =3D parentchkdisk->name; + parentbitmap =3D parentchkdisk->bitmap; if (qemuCheckpointDiscardDiskBitmaps(domdisk->src, blockNamedNodeD= ata, chkdisk->bitmap, parentbitmap, --=20 2.24.1