From nobody Thu Apr 18 11:22:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1565712529; cv=none; d=zoho.com; s=zohoarc; b=duXBXH6qFkMPjFZ1g1Wp3O/ybChRl2E7FwmuhIw3/r95xiRtgOqSY+X/k0DbPRU3fW5w3ccr3G6blQqVhMI+acwLiZrhnR1xklrVMi1n7n3IrLhYPn263t2XW/OHb2/Scf48rBpOL6o5JdrzAftWPwtO5IKCVT26pGR+Msj2pOM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565712529; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=OKM3gjxFjr/MSpyiLSJGbLJ5/amfBWEOLH7Pd/eB8NE=; b=LrhK8TWvhEc04jpZ4d3r5Z2XQk01Y09/sDYpNhR+H6kNtuWP1jtsNXb8/JDEL4zEsbWv/eQzvgFqTMpIaG59gOwsb61FsKF/hDwSdkxnLTS1S2FoDpT/ZdNFhf3oIdHISLDeRSGRXsGU98RzwdGtsucb0wln+qeZdMyv5uA9sK4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1565712529637701.5851255373271; Tue, 13 Aug 2019 09:08:49 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 22FF320ABB; Tue, 13 Aug 2019 16:08:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E916510013A1; Tue, 13 Aug 2019 16:08:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A5BF4180BA99; Tue, 13 Aug 2019 16:08:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x7DG8hpb011744 for ; Tue, 13 Aug 2019 12:08:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id 272DF18E35; Tue, 13 Aug 2019 16:08:43 +0000 (UTC) Received: from virval.usersys.redhat.com (unknown [10.43.2.188]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F114C804D7 for ; Tue, 13 Aug 2019 16:08:40 +0000 (UTC) Received: by virval.usersys.redhat.com (Postfix, from userid 500) id 40EDA100100; Tue, 13 Aug 2019 18:08:39 +0200 (CEST) From: Jiri Denemark To: libvir-list@redhat.com Date: Tue, 13 Aug 2019 18:08:36 +0200 Message-Id: <7ad3856a15fc98ac8db83b1bb9f7fac0c989e6d4.1565712419.git.jdenemar@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/3] qemu: Clarify error message in qemuMigrationSrcIsSafe X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 13 Aug 2019 16:08:48 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The original message was logically incorrect: cache !=3D none or cache !=3D directsync is always true. But even replacing "or" with "and" doesn't make it more readable for humans. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index c2570f7303..2bd1a464bf 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1266,7 +1266,7 @@ qemuMigrationSrcIsSafe(virDomainDefPtr def, =20 virReportError(VIR_ERR_MIGRATE_UNSAFE, "%s", _("Migration may lead to data corruption if disks" - " use cache !=3D none or cache !=3D directsync")); + " use cache other than none or directsync")); return false; } =20 --=20 2.22.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list