From nobody Mon Sep 16 19:15:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1720093964377886.0558967129164; Thu, 4 Jul 2024 04:52:44 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 491511239; Thu, 4 Jul 2024 07:52:43 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 93D801254; Thu, 4 Jul 2024 07:52:27 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 0FF89E5C; Thu, 4 Jul 2024 07:52:24 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8F41AE5C for ; Thu, 4 Jul 2024 07:52:23 -0400 (EDT) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-189-HO1pg87kPx-LO-CGjnC1vg-1; Thu, 04 Jul 2024 07:52:22 -0400 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 407491955F0D for ; Thu, 4 Jul 2024 11:52:21 +0000 (UTC) Received: from ajulis-thinkpadt14gen4.remote.csb (unknown [10.43.2.246]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 82772195605F for ; Thu, 4 Jul 2024 11:52:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720093943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2DO1xUQlo9HRwy3sYK1HBK3c0HNonmp18pv2OUr/IWQ=; b=QhR+jVbnf8gISgjLRl2nCB23K7GGIpwIN8YmF+SqZJk0RSfNjPk48q03OP6HEDcsAP6J0B qQfHjK7Bjyxsc7mSPCRtL5pUnvtidISex7c+rxP/7Y9jG0UOVgODGQnx33xGmWDWhdmWMu RbizcoYketNECsf0G9+2jURn/nUB4bE= X-MC-Unique: HO1pg87kPx-LO-CGjnC1vg-1 From: Adam Julis To: devel@lists.libvirt.org Subject: [PATCH] domain_conf: comment not match the code below Date: Thu, 4 Jul 2024 13:52:17 +0200 Message-ID: <7a56aae2f6ca5ebec5aa028c2d8e4e3b8bb99023.1720093881.git.ajulis@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: YV7NW343VQIJWJXNEXVQKBHMMJMTYI3V X-Message-ID-Hash: YV7NW343VQIJWJXNEXVQKBHMMJMTYI3V X-MailFrom: ajulis@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1720093964573100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The outdated comment refers to a non-existent member in the virDomainObj structure. Signed-off-by: Adam Julis Reviewed-by: Michal Privoznik --- src/conf/domain_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7033b4e9fe..115862bbde 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -4449,7 +4449,7 @@ virDomainObjGetDefs(virDomainObj *vm, * @live: set to true if live config was returned (may be omitted) * * Helper function to resolve @flags and return the correct domain pointer - * object. This function returns one of @vm->def or @vm->persistentDef + * object. This function returns one of @vm->def or @vm->newDef * according to @flags. @live is set to true if the live vm config will be * returned. This helper should be used only in APIs that guarantee * that @flags contains exactly one of VIR_DOMAIN_AFFECT_LIVE or @@ -4489,7 +4489,7 @@ virDomainObjGetOneDefState(virDomainObj *vm, * @flags: for virDomainModificationImpact * * Helper function to resolve @flags and return the correct domain pointer - * object. This function returns one of @vm->def or @vm->persistentDef + * object. This function returns one of @vm->def or @vm->newDef * according to @flags. This helper should be used only in APIs that guara= ntee * that @flags contains exactly one of VIR_DOMAIN_AFFECT_LIVE or * VIR_DOMAIN_AFFECT_CONFIG and not both. --=20 2.45.2