From nobody Sat Dec 21 16:02:58 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1704735148297261.0868201104721; Mon, 8 Jan 2024 09:32:28 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 2EFD41AD6; Mon, 8 Jan 2024 12:32:27 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 5B1801B7B; Mon, 8 Jan 2024 12:08:52 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id C63F51A5A; Mon, 8 Jan 2024 12:08:27 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 808E81A18 for ; Mon, 8 Jan 2024 12:06:51 -0500 (EST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-y-Bi8-ZVMn-59edVYutZTg-1; Mon, 08 Jan 2024 12:06:48 -0500 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 80A708370E3 for ; Mon, 8 Jan 2024 17:06:48 +0000 (UTC) Received: from orkuz (unknown [10.45.226.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id 44734492BE6 for ; Mon, 8 Jan 2024 17:06:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: y-Bi8-ZVMn-59edVYutZTg-1 From: Jiri Denemark To: devel@lists.libvirt.org Subject: [libvirt PATCH 3/6] qemu: Rename remoteCaps parameter in qemuMigrationParamsCheck Date: Mon, 8 Jan 2024 18:06:39 +0100 Message-ID: <79ba68969181a34f764c2f92c01eaf0d3877ac41.1704733372.git.jdenemar@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: TBNBFCDQLECWB6GOQNEXSANDE73H4LAS X-Message-ID-Hash: TBNBFCDQLECWB6GOQNEXSANDE73H4LAS X-MailFrom: jdenemar@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1704735149910100001 The migration cookie contains two bitmaps of migration capabilities: supported and automatic. qemuMigrationParamsCheck expects the letter so lets make it more obvious by renaming the parameter as remoteAuto. Signed-off-by: Jiri Denemark Reviewed-by: Peter Krempa --- src/qemu/qemu_migration_params.c | 6 +++--- src/qemu/qemu_migration_params.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_par= ams.c index b02a8af8d5..f441c59d67 100644 --- a/src/qemu/qemu_migration_params.c +++ b/src/qemu/qemu_migration_params.c @@ -1290,7 +1290,7 @@ int qemuMigrationParamsCheck(virDomainObj *vm, int asyncJob, qemuMigrationParams *migParams, - virBitmap *remoteCaps) + virBitmap *remoteAuto) { qemuDomainJobPrivate *jobPriv =3D vm->job->privateData; qemuMigrationCapability cap; @@ -1323,8 +1323,8 @@ qemuMigrationParamsCheck(virDomainObj *vm, if (qemuMigrationParamsAlwaysOn[i].party !=3D party) { bool remote =3D false; =20 - if (remoteCaps) - ignore_value(virBitmapGetBit(remoteCaps, cap, &remote)= ); + if (remoteAuto) + ignore_value(virBitmapGetBit(remoteAuto, cap, &remote)= ); =20 if (!remote) { VIR_DEBUG("Not enabling migration capability '%s'; it = is " diff --git a/src/qemu/qemu_migration_params.h b/src/qemu/qemu_migration_par= ams.h index 5857673227..44f5c2a882 100644 --- a/src/qemu/qemu_migration_params.h +++ b/src/qemu/qemu_migration_params.h @@ -142,7 +142,7 @@ int qemuMigrationParamsCheck(virDomainObj *vm, int asyncJob, qemuMigrationParams *migParams, - virBitmap *remoteCaps); + virBitmap *remoteAuto); =20 void qemuMigrationParamsReset(virDomainObj *vm, --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org