From nobody Sun Dec 14 06:38:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1751547305; cv=none; d=zohomail.com; s=zohoarc; b=HdbJFIYlC5LTarfSszrJE76DBWVyt9uCf5VyS1hxIunxP0cbSv/WKveOVTe7+SZpUZqtBwYNwCzHmL4/rUCcYM4g/fykai3lALzgCosNnMmZlehWOj9EJHK3fU/7/z4fnJWqTq3UU7Y00LM7AWJeIWqqJkWUS7UHQfxCmxacsuc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751547305; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=XW/9AVTSVPwGgMKJb4rTc/LKRzs0jo4ssZlTmtvW5a8=; b=J1eZ5Hwl3zimEZIwsTbZGlOjTYBByUEToocg1gB7D6iiHSXzL4Gvvi+70IXpomsq6fEWhAxH+9ls9ThnIa5v8nO+MZMG5ckQh4bQ6bHh7/5JYrqr/ed7Wd6mizWKu07ijc+0TBN+QhujGHHzDJ+tS5WVfrsDR769tJYXTOfZfRc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1751547305246708.9087621664439; Thu, 3 Jul 2025 05:55:05 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3E0E111F2; Thu, 3 Jul 2025 08:55:04 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id CF4921240; Thu, 3 Jul 2025 08:51:12 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id BF37312A4; Thu, 3 Jul 2025 08:51:07 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3115DE72 for ; Thu, 3 Jul 2025 08:50:50 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-47-ZWK3kGUkOleEHg1HyoOJvw-1; Thu, 03 Jul 2025 08:50:48 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A0411180034E for ; Thu, 3 Jul 2025 12:50:47 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D4CD11956048 for ; Thu, 3 Jul 2025 12:50:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751547049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=75AJ2PyK/zrCQLdDJLmiSkQl35Sw1SCmL14LAoHmJuU=; b=ijlc9NX107PcV2ib/V2Y092VX+CDQUh3z4R+sV7bIUFskm+EvH20HZo0KyrDYmlbkGXpHK ZegctanwJMyU/TAxKQnBukXzXLTWFclyw2DS8rNjDZHEtRxJZYo09/ITy6dTbab+PxXysJ I3iXc6Qo9PPTh6dttjzO5EsVdKTseLk= X-MC-Unique: ZWK3kGUkOleEHg1HyoOJvw-1 X-Mimecast-MFC-AGG-ID: ZWK3kGUkOleEHg1HyoOJvw_1751547047 To: devel@lists.libvirt.org Subject: [PATCH 09/10] virDomainDriverAutoShutdownDoSave: Don't attempt to save transient VMs Date: Thu, 3 Jul 2025 14:50:32 +0200 Message-ID: <798352ba725d863968541f9ca185cea7135d4bdc.1751546915.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KDciPr7gLc9mtgS3CgAudcIKNxU3Jolxjva0-YPpcWY_1751547047 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KE63KIDEEOL6MC5QWNV7STPTMYVU7PFM X-Message-ID-Hash: KE63KIDEEOL6MC5QWNV7STPTMYVU7PFM X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1751547306174116600 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Commit 84bb136c31e added code that intended to skip the save of transient domains but did so only in the setup part where we pause the VMS. The second loop that actually attempts to save the VM was not modified so we'd still try saving them: Jul 03 14:15:13 andariel virtqemud[247210]: auto-shutdown: unable to perfo= rm managed save of 'cd3': Requested operation is not valid: cannot do manag= ed save for transient domain Fixes: 84bb136c31e Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina --- src/hypervisor/domain_driver.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/hypervisor/domain_driver.c b/src/hypervisor/domain_driver.c index cce6c64d1b..d8ccee40d5 100644 --- a/src/hypervisor/domain_driver.c +++ b/src/hypervisor/domain_driver.c @@ -779,6 +779,10 @@ virDomainDriverAutoShutdownDoSave(virDomainPtr *domain= s, } for (i =3D 0; i < numDomains; i++) { + if ((transient[i] && cfg->trySave =3D=3D VIR_DOMAIN_DRIVER_AUTO_SH= UTDOWN_SCOPE_PERSISTENT) || + (!transient[i] && cfg->trySave =3D=3D VIR_DOMAIN_DRIVER_AUTO_S= HUTDOWN_SCOPE_TRANSIENT)) + continue; + virSystemdNotifyStatus("Saving '%s' (%zu of %zu)", virDomainGetName(domains[i]), i + 1, numDom= ains); VIR_INFO("Saving '%s'", virDomainGetName(domains[i])); --=20 2.49.0