From nobody Tue Oct 22 22:21:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1694699990; cv=none; d=zohomail.com; s=zohoarc; b=TQb2cxjoFj7qh6q+LoLLpqpS8cv6WtV8epFzBjbo5nL9t9HVKSNSrA3ts0BbEihZsm1UplAXJtNcnY1SL7aVTOfwsvymkO2JMwVdgL3IOw5beP3xCQK2y0VLj4hbuJbz7bRyL3q/T+i62tm6HA09Sqa3SBkPVSTt+JFqTn4O8LA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694699990; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=b+UITTKA0hOlYSHPd0E396/sZUhYhdZUjoAglBC+rz0=; b=D2rst8+t6R83IA1Akua3lVDw9Y3k8RSihqXvScMFVZzBFSGUWD9pqI/Lr6201HZ3l4H+loUK+wGepK4Yva+cEemfcg0lxqAkUUevUHBybXl5EmNBNDEm3fMPggUSL/OUZvxz0zYXG+HVKB8sGL3w636L8cO49Eyy738bvTvsA2I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 169469999080392.97123588418413; Thu, 14 Sep 2023 06:59:50 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-606-wq-Y8sSBNzCmuKGv92wGiQ-1; Thu, 14 Sep 2023 09:56:42 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EB7391052224; Thu, 14 Sep 2023 13:56:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id D541421CAC7A; Thu, 14 Sep 2023 13:56:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A72E319466F8; Thu, 14 Sep 2023 13:56:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8F19719465B8 for ; Thu, 14 Sep 2023 13:56:27 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 7F33D40C6EC0; Thu, 14 Sep 2023 13:56:27 +0000 (UTC) Received: from maggie.brq.redhat.com (unknown [10.43.2.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2718640C6ECA for ; Thu, 14 Sep 2023 13:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694699989; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=b+UITTKA0hOlYSHPd0E396/sZUhYhdZUjoAglBC+rz0=; b=Itjts1qsPIHyEfWW06jVzGt9fQcatrhEoSNHV9iiFvX166Q/bxd0Mim4zbKngGaZN6F8oE ZwCIEQ2HUUUlUTB3j9ZCef5fZ/t1c7dNwTVZXGNOlEowN3kKupTD9cnWzfpEJBt8NorSys 9nMBdtXnXTlBcYxNCeIM8mWOcCuMtWE= X-MC-Unique: wq-Y8sSBNzCmuKGv92wGiQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 04/20] qemu: Drop needless typecast to virDomainFSDriverType Date: Thu, 14 Sep 2023 15:56:05 +0200 Message-ID: <79200ca30499c9dd2ea2f2d3db42349563ff5491.1694699681.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694699991034100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The 'fsdriver' member of _virDomainFSDef is already declared of virDomainFSDriverType type. Hence, there is no need to typecast the variable when passing to switch() statements. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 4 ++-- src/qemu/qemu_domain_address.c | 2 +- src/qemu/qemu_validate.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index e84374b4cf..f9e4de9bd7 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -831,7 +831,7 @@ qemuBuildVirtioDevGetConfigDev(const virDomainDeviceDef= *device, break; =20 case VIR_DOMAIN_DEVICE_FS: - switch ((virDomainFSDriverType) device->data.fs->fsdriver) { + switch (device->data.fs->fsdriver) { case VIR_DOMAIN_FS_DRIVER_TYPE_DEFAULT: case VIR_DOMAIN_FS_DRIVER_TYPE_PATH: case VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE: @@ -2434,7 +2434,7 @@ qemuBuildFilesystemCommandLine(virCommand *cmd, size_t i; =20 for (i =3D 0; i < def->nfss; i++) { - switch ((virDomainFSDriverType) def->fss[i]->fsdriver) { + switch (def->fss[i]->fsdriver) { case VIR_DOMAIN_FS_DRIVER_TYPE_DEFAULT: case VIR_DOMAIN_FS_DRIVER_TYPE_PATH: case VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE: diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index e5f0a9e883..01f44a4991 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu/qemu_domain_address.c @@ -707,7 +707,7 @@ qemuDomainDeviceCalculatePCIConnectFlags(virDomainDevic= eDef *dev, break; =20 case VIR_DOMAIN_DEVICE_FS: - switch ((virDomainFSDriverType) dev->data.fs->fsdriver) { + switch (dev->data.fs->fsdriver) { case VIR_DOMAIN_FS_DRIVER_TYPE_DEFAULT: case VIR_DOMAIN_FS_DRIVER_TYPE_PATH: case VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE: diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 5bae56b00f..c7deac6251 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -4286,7 +4286,7 @@ qemuValidateDomainDeviceDefFS(virDomainFSDef *fs, return -1; } =20 - switch ((virDomainFSDriverType) fs->fsdriver) { + switch (fs->fsdriver) { case VIR_DOMAIN_FS_DRIVER_TYPE_DEFAULT: case VIR_DOMAIN_FS_DRIVER_TYPE_PATH: break; --=20 2.41.0