From nobody Sun Feb 8 23:41:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1566852323; cv=none; d=zoho.com; s=zohoarc; b=mddbxSu4K1eCPF5v8qDlAGeYR9KnUGXtQaRe+jFADsIbfivZqsS+UpmWjxSLOkmxi8EX6aZ3O68xDBkF5yqG+c/nm4OoDGqDFPAiHwDovGJ9TgZM/iFZhHsq6KwfxQm9BK3L3On11QzRbNNtEyQVLax16S0bZlvCVjCXQqhGD+w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566852323; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=xaeI2mF8zteokkomboNqiiuENkzcYy8/Ze+WaGIs9to=; b=MLBqIhMWm8yOKQSBQVkOk7d73X6tAHAmZp/th7GgEIGgUju7bz0NNPhKLaQaIQm+nMAh1lxNEI0/XXuTaOhW098CCH33uQVE21F2VT7aCom8a1S1lhBB2Ml1VxfCGyish3J+/GtVFOtLdVCgPgMKkyQA/rkXbEcL0CWEcknQjUM= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1566852323896462.035669787076; Mon, 26 Aug 2019 13:45:23 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B6EA38980F8; Mon, 26 Aug 2019 20:45:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8A7E85C22F; Mon, 26 Aug 2019 20:45:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 40909180BA98; Mon, 26 Aug 2019 20:45:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x7QKjLsd020216 for ; Mon, 26 Aug 2019 16:45:21 -0400 Received: by smtp.corp.redhat.com (Postfix) id 175D56CE5B; Mon, 26 Aug 2019 20:45:21 +0000 (UTC) Received: from icr.brq.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 929B46CE58 for ; Mon, 26 Aug 2019 20:45:18 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Mon, 26 Aug 2019 22:44:53 +0200 Message-Id: <781b9f6af341ac5f2dadd2747d02ef44822be829.1566852239.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 4/7] qemuBuildSoundCommandLine: reduce scope of codecstr X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.67]); Mon, 26 Aug 2019 20:45:23 +0000 (UTC) Copy the declaration into the smallest blocks it's used in and mark it as VIR_AUTOFREE. Signed-off-by: J=C3=A1n Tomko --- src/qemu/qemu_command.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 06ac184f0d..bd6beb0e52 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4471,9 +4471,9 @@ qemuBuildSoundCommandLine(virCommandPtr cmd, virCommandAddArg(cmd, str); if (sound->model =3D=3D VIR_DOMAIN_SOUND_MODEL_ICH6 || sound->model =3D=3D VIR_DOMAIN_SOUND_MODEL_ICH9) { - char *codecstr =3D NULL; =20 for (j =3D 0; j < sound->ncodecs; j++) { + VIR_AUTOFREE(char *) codecstr =3D NULL; virCommandAddArg(cmd, "-device"); if (!(codecstr =3D qemuBuildSoundCodecStr(sound, sound->codecs[j], @@ -4482,9 +4482,9 @@ qemuBuildSoundCommandLine(virCommandPtr cmd, =20 } virCommandAddArg(cmd, codecstr); - VIR_FREE(codecstr); } if (j =3D=3D 0) { + VIR_AUTOFREE(char *) codecstr =3D NULL; virDomainSoundCodecDef codec =3D { VIR_DOMAIN_SOUND_CODEC_TYPE_DUPLEX, 0 @@ -4497,7 +4497,6 @@ qemuBuildSoundCommandLine(virCommandPtr cmd, =20 } virCommandAddArg(cmd, codecstr); - VIR_FREE(codecstr); } } } --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list