From nobody Thu Apr 2 22:18:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774515910; cv=none; d=zohomail.com; s=zohoarc; b=ALzbekELl7k9mKOClcvdK/ry+xyRfV3+jVe7tqudpfni0ZorwbUW3NEudzg5t98pZkMBiZH8Yh3oq5N/y8X62bOdXMKptuyQs9Oyn2R6R9Dlj4SMkaLQwLnGig5v6+UGLySr+p+Bqu9mFhropkILsrHV37YEoVLGIPnat6p0B54= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774515910; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=nSx4c7UZRb/4rmZ78xVezXxDedU6ySPWXnwDWt2zbU8=; b=OXclnoNJLtDbLvHMnJrDfl6BGnZRwZwPaHfoduuXo0TRkn6lO8kSC/be3PMnEmqCFzvuRYGji/g1jP8j0D4Xy5NlEvHCmz1FafBvsJrN6Na5Y76u/Y/WxvuFehfkt6IIxCqllLVm7GJyDOLmnH2YkiouZatd1lv8QnrUcvUVlNg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774515910776381.21360796022566; Thu, 26 Mar 2026 02:05:10 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id D7BB33F377; Thu, 26 Mar 2026 05:05:09 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 87AC43FA60; Thu, 26 Mar 2026 05:04:38 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id D797A3F2F8; Thu, 26 Mar 2026 05:04:33 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 049C73F27C for ; Thu, 26 Mar 2026 05:04:32 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-498-xMtvC8B7OPuFhJ7iKfrOUw-1; Thu, 26 Mar 2026 05:04:30 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E0E5B1956062 for ; Thu, 26 Mar 2026 09:04:29 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4953F19560B1 for ; Thu, 26 Mar 2026 09:04:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774515872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nSx4c7UZRb/4rmZ78xVezXxDedU6ySPWXnwDWt2zbU8=; b=IfdUowo1mv4oH96KIzQPNp8CmA2wgESE4adTC1FKYheRGyyBWjS7WjvUuHjyAP2LK54iAa pBiShVeLz7i1D8CzsTVQjFfltR3q57MKP7y/B9/W6pbPJi4BPyalARpvi0t6f4nAgS7eKC MpByniZk9Q9iph1eddORCYrfGgQpb1g= X-MC-Unique: xMtvC8B7OPuFhJ7iKfrOUw-1 X-Mimecast-MFC-AGG-ID: xMtvC8B7OPuFhJ7iKfrOUw_1774515870 To: devel@lists.libvirt.org Subject: [PATCH] virxml: Fix virXMLPropTristateBoolAllowDefault() documentation Date: Thu, 26 Mar 2026 10:04:24 +0100 Message-ID: <77f96eed62f7138267ad1ecf43844a43dab95be8.1774515864.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: W9QF48I0cjnZZv77CsWm313u2pzlOTm0jnQyhH1KiE4_1774515870 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: PRWPMMZ75ICF3462G45QWBD36E2NFAXV X-Message-ID-Hash: PRWPMMZ75ICF3462G45QWBD36E2NFAXV X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774515918192154100 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik The documentation to virXMLPropTristateBoolAllowDefault() refers to itself while it meant to refer to virXMLPropTristateBool(). Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/util/virxml.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/util/virxml.c b/src/util/virxml.c index 274f072598..beb5301378 100644 --- a/src/util/virxml.c +++ b/src/util/virxml.c @@ -525,13 +525,13 @@ virXMLPropTristateBool(xmlNodePtr node, } =20 =20 -/* Same as virXMLPropTristateBoolAllowDefault, but will accept the - * value 'default' and convert it to VIR_TRISTATE_BOOL_ABSENT instead - * of rejecting it with an error. Should only be used for backwards - * compatibility reasons, and specifically to parse XML files where a - * property having value VIR_TRISTATE_BOOL_ABSENT has historically - * resulted in it being formatted with value 'default' instead of - * being omitted entirely */ +/* Same as virXMLPropTristateBool, but will accept the value 'default' + * and convert it to VIR_TRISTATE_BOOL_ABSENT instead of rejecting it + * with an error. Should only be used for backwards compatibility + * reasons, and specifically to parse XML files where a property + * having value VIR_TRISTATE_BOOL_ABSENT has historically resulted in + * it being formatted with value 'default' instead of being omitted + * entirely. */ int virXMLPropTristateBoolAllowDefault(xmlNodePtr node, const char *name, --=20 2.52.0