From nobody Mon Feb 9 20:32:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1632496887; cv=none; d=zohomail.com; s=zohoarc; b=Nh4aR+dRb1uVtHnRWlBTghklW70JnZl85/X48Hv7K5rRrX/NIOOjZ8oC6HSs3XhFvnoi8pi2JcWXbV6CVofLfK/Ucm9uffolcWQSdAs4sRTund4ekQqHuj+q+jloxbDtVDH07bJe3VH74exgs9TZaoaqpoPL/M4skHt6BHK7pgY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632496887; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QR+/S/D0IiAGATHPeqZdlwLT2+FYjELqjjakkJS5XCY=; b=TLcG1Zh8ekqXcfzVX2lqa9GDQPnx3C5yvWvMWfzSC72OQ2kRkm4M/RRzQOyV/qT6UY8Fq0QIr702TiSX+Et2ohPB3blryAeMk4GO69Same0Cok9oR3dtjiR9qouUwp6fH/d/VARYlACpuC+fT32wtVGk2BwHKjKuu7/e277tzmY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1632496887660909.6962865014765; Fri, 24 Sep 2021 08:21:27 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-585-lRSFApaLMlqbO4Ej1Ytr3A-1; Fri, 24 Sep 2021 11:21:25 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 30CB78145EE; Fri, 24 Sep 2021 15:21:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E33885D9DE; Fri, 24 Sep 2021 15:21:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7C6044EA2F; Fri, 24 Sep 2021 15:21:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 18OFIPJu026668 for ; Fri, 24 Sep 2021 11:18:25 -0400 Received: by smtp.corp.redhat.com (Postfix) id 25051177C0; Fri, 24 Sep 2021 15:18:25 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.43.2.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F2F45172D for ; Fri, 24 Sep 2021 15:18:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632496886; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=QR+/S/D0IiAGATHPeqZdlwLT2+FYjELqjjakkJS5XCY=; b=dzNhzV0DffBA2TvkFh05ARHPZWr5zNRPkAR/wFlIhASCMpn/5BuzqLNygT3SZaktQCqMMY CEieTGLAd68ICaGtNvlz/GY3ToCAWYYiRgU+Pwj2hdttm+zHXl58L8BlqM54OvKXm65cus EcRrSSwWV0sbRv1ClJQ/tJu5U+J0w2M= X-MC-Unique: lRSFApaLMlqbO4Ej1Ytr3A-1 From: Kristina Hanicova To: libvir-list@redhat.com Subject: [PATCH v2 7/7] virsh: domain: remove else branch Date: Fri, 24 Sep 2021 17:17:50 +0200 Message-Id: <77aee018132c1753d5c0e3edf2a4ca397b7993a7.1632495763.git.khanicov@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1632496888813100003 Content-Type: text/plain; charset="utf-8" I removed else branches after return/break as they are not necessary and the code looks cleaner without them. Signed-off-by: Kristina Hanicova --- tools/virsh-domain.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 94ed786751..ca8f08d949 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -11046,12 +11046,12 @@ cmdMigrateCompCache(vshControl *ctl, const vshCmd= *cmd) return false; =20 rc =3D vshCommandOptULongLong(ctl, cmd, "size", &size); - if (rc < 0) { + if (rc < 0) + return false; + + if (rc !=3D 0 && + (virDomainMigrateSetCompressionCache(dom, size, 0) < 0)) return false; - } else if (rc !=3D 0) { - if (virDomainMigrateSetCompressionCache(dom, size, 0) < 0) - return false; - } =20 if (virDomainMigrateGetCompressionCache(dom, &size, 0) < 0) return false; @@ -11432,11 +11432,9 @@ cmdDomDisplay(vshControl *ctl, const vshCmd *cmd) =20 /* We got what we came for so return successfully */ ret =3D true; - if (!all) { + if (!all) break; - } else { - vshPrint(ctl, "\n"); - } + vshPrint(ctl, "\n"); } =20 if (!ret) { --=20 2.31.1